Re: [PATCH 1/1] net: ethernet: qlogic: set error code on failure

2016-12-05 Thread David Miller
From: "Mintz, Yuval" Date: Sun, 4 Dec 2016 07:29:58 + >> From: Pan Bian >> >> When calling dma_mapping_error(), the value of return variable rc is 0. >> And when the call returns an unexpected value, rc is not set to a negative >> errno. Thus, it will return 0 on the error path, and its cal

RE: [PATCH 1/1] net: ethernet: qlogic: set error code on failure

2016-12-03 Thread Mintz, Yuval
> From: Pan Bian > > When calling dma_mapping_error(), the value of return variable rc is 0. > And when the call returns an unexpected value, rc is not set to a negative > errno. Thus, it will return 0 on the error path, and its callers cannot detect > the bug. This patch fixes the bug, assigning