Re: [PATCH 0/2] of: fsl/fman: reuse the fixed node parsing code

2015-08-12 Thread Stas Sergeev
12.08.2015 18:27, Madalin-Cristian Bucur пишет: Then I could call only of_* functions but the end result would be the same and of_phy_register_fixed_phy() would not justify its existence that much... You didn't say you wanted to obsolete the of_phy_register_fixed_phy(). Since it is there (and e

RE: [PATCH 0/2] of: fsl/fman: reuse the fixed node parsing code

2015-08-12 Thread Madalin-Cristian Bucur
> -Original Message- > From: Stas Sergeev [mailto:s...@list.ru] > But have you looked into the patch I pointed previously? > https://lkml.org/lkml/2015/7/20/711 > You code will likely clash with it because my patch extends > of_phy_register_fixed_link(). > I admin I failed to grasp the

Re: [PATCH 0/2] of: fsl/fman: reuse the fixed node parsing code

2015-08-12 Thread Stas Sergeev
12.08.2015 17:43, Madalin-Cristian Bucur пишет: -Original Message- From: Stas Sergeev [mailto:s...@list.ru] 12.08.2015 16:26, Madalin-Cristian Bucur пишет: I've tried to make the smallest changes that allow me to retrieve those without modifying existing API. Why is it important to hide

RE: [PATCH 0/2] of: fsl/fman: reuse the fixed node parsing code

2015-08-12 Thread Madalin-Cristian Bucur
> -Original Message- > From: Stas Sergeev [mailto:s...@list.ru] > > 12.08.2015 16:26, Madalin-Cristian Bucur пишет: > >>> I've tried to make the smallest changes that allow me to retrieve those > >>> without modifying existing API. > >>> Why is it important to hide the default values from t

Re: [PATCH 0/2] of: fsl/fman: reuse the fixed node parsing code

2015-08-12 Thread Stas Sergeev
12.08.2015 16:26, Madalin-Cristian Bucur пишет: I've tried to make the smallest changes that allow me to retrieve those without modifying existing API. Why is it important to hide the default values from the MAC driver? My worry is that the fixed values are not really fixed, and therefore are no

RE: [PATCH 0/2] of: fsl/fman: reuse the fixed node parsing code

2015-08-12 Thread Madalin-Cristian Bucur
> -Original Message- > From: Stas Sergeev [mailto:s...@list.ru] > > 11.08.2015 19:33, Madalin-Cristian Bucur пишет: > > + Joakim, Shaohui > > > >> -Original Message- > >> From: Stas Sergeev [mailto:s...@list.ru] > >> > >> 08.08.2015 20:32, Florian Fainelli пишет: > >>> CC'ing Stas,

Re: [PATCH 0/2] of: fsl/fman: reuse the fixed node parsing code

2015-08-11 Thread Stas Sergeev
11.08.2015 19:33, Madalin-Cristian Bucur пишет: + Joakim, Shaohui -Original Message- From: Stas Sergeev [mailto:s...@list.ru] 08.08.2015 20:32, Florian Fainelli пишет: CC'ing Stas, Hi. Le 08/05/15 07:42, Madalin Bucur a écrit : The FMan MAC configuration code needs the speed and d

RE: [PATCH 0/2] of: fsl/fman: reuse the fixed node parsing code

2015-08-11 Thread Madalin-Cristian Bucur
+ Joakim, Shaohui > -Original Message- > From: Stas Sergeev [mailto:s...@list.ru] > > 08.08.2015 20:32, Florian Fainelli пишет: > > CC'ing Stas, > Hi. > > > Le 08/05/15 07:42, Madalin Bucur a écrit : > >> The FMan MAC configuration code needs the speed and duplex > information > >> for f

Re: [PATCH 0/2] of: fsl/fman: reuse the fixed node parsing code

2015-08-11 Thread Stas Sergeev
08.08.2015 20:32, Florian Fainelli пишет: CC'ing Stas, Hi. Le 08/05/15 07:42, Madalin Bucur a écrit : The FMan MAC configuration code needs the speed and duplex information for fixed-link interfaces that is parsed now by the of function of_phy_register_fixed_link(). This parses the fixed-link

Re: [PATCH 0/2] of: fsl/fman: reuse the fixed node parsing code

2015-08-08 Thread Florian Fainelli
CC'ing Stas, Le 08/05/15 07:42, Madalin Bucur a écrit : > The FMan MAC configuration code needs the speed and duplex information > for fixed-link interfaces that is parsed now by the of function > of_phy_register_fixed_link(). This parses the fixed-link parameters but > does not expose to the call