On Thu, May 11, 2017 at 4:37 PM, Mintz, Yuval wrote:
>> > For the most part - I'm almost all in favor of this change.
>> > But just to make it clear - the actual fix could have been a one-liner,
>> > right?
>> > The rest are style changes.
>
>> Correct. Having the correct length in the memset is
> > For the most part - I'm almost all in favor of this change.
> > But just to make it clear - the actual fix could have been a one-liner,
> > right?
> > The rest are style changes.
> Correct. Having the correct length in the memset is a sufficient fix for the
> warning,
> but it felt wrong to
On Thu, May 11, 2017 at 4:03 PM, Mintz, Yuval wrote:
>> register, which went subtly wrong due to the wrong size in a memset():
>>
>> ethernet/qlogic/qed/qed_init_fw_funcs.c: In function
>> 'qed_set_rfs_mode_disable':
>> ethernet/qlogic/qed/qed_init_fw_funcs.c:993:3: error: '*((void
>> *)&ramline+4
> register, which went subtly wrong due to the wrong size in a memset():
>
> ethernet/qlogic/qed/qed_init_fw_funcs.c: In function
> 'qed_set_rfs_mode_disable':
> ethernet/qlogic/qed/qed_init_fw_funcs.c:993:3: error: '*((void
> *)&ramline+4)' is used uninitialized in this function [-Werror=uninitia
