Re: [PATCH] net: qlcnic: clean up sysfs error codes

2015-05-28 Thread David Miller
From: Vladimir Zapolskiy Date: Fri, 29 May 2015 04:13:46 +0300 > Hello David, > > On 29.05.2015 02:28, David Miller wrote: >> From: Vladimir Zapolskiy >> Date: Tue, 26 May 2015 03:49:45 +0300 >> >>> Replace confusing QL_STATUS_INVALID_PARAM == -1 == -EPERM with -EINVAL >>> and QLC_STATUS_UNSUP

Re: [PATCH] net: qlcnic: clean up sysfs error codes

2015-05-28 Thread Vladimir Zapolskiy
Hello David, On 29.05.2015 02:28, David Miller wrote: > From: Vladimir Zapolskiy > Date: Tue, 26 May 2015 03:49:45 +0300 > >> Replace confusing QL_STATUS_INVALID_PARAM == -1 == -EPERM with -EINVAL >> and QLC_STATUS_UNSUPPORTED_CMD == -2 == -ENOENT with -EOPNOTSUPP, the >> latter error code is ar

Re: [PATCH] net: qlcnic: clean up sysfs error codes

2015-05-28 Thread David Miller
From: Vladimir Zapolskiy Date: Tue, 26 May 2015 03:49:45 +0300 > Replace confusing QL_STATUS_INVALID_PARAM == -1 == -EPERM with -EINVAL > and QLC_STATUS_UNSUPPORTED_CMD == -2 == -ENOENT with -EOPNOTSUPP, the > latter error code is arguable, but it is already used in the driver, > so let it be her

RE: [PATCH] net: qlcnic: clean up sysfs error codes

2015-05-28 Thread Rajesh Borundia
>-Original Message- >From: dept_hsg_linux_nic_dev-boun...@qlclistserver.qlogic.com >[mailto:dept_hsg_linux_nic_dev-boun...@qlclistserver.qlogic.com] On >Behalf Of Vladimir Zapolskiy >Sent: Tuesday, May 26, 2015 6:20 AM >To: David Miller; Shahed Shaikh; Dept-GE Linux NIC Dev >Cc: netdev >Sub

RE: [PATCH] net: qlcnic: clean up sysfs error codes

2015-05-25 Thread Rajesh Borundia
>-Original Message- >From: dept_hsg_linux_nic_dev-boun...@qlclistserver.qlogic.com >[mailto:dept_hsg_linux_nic_dev-boun...@qlclistserver.qlogic.com] On >Behalf Of Vladimir Zapolskiy >Sent: Tuesday, May 26, 2015 6:20 AM >To: David Miller; Shahed Shaikh; Dept-GE Linux NIC Dev >Cc: netdev >Sub