RE: [PATCH] net: phy: adds backplane driver for Freescale's PCS PHY

2015-12-29 Thread Shaohui Xie
Hello Florian, Thanks for reviewing the patch! > > +struct training_state_machine { > > + bool bin_m1_late_early; > > + bool bin_long_late_early; > > + bool bin_m1_stop; > > + bool bin_long_stop; > > + bool tx_complete; > > + bool an_ok; > > + bool link_up; > > + bool running; >

Re: [PATCH] net: phy: adds backplane driver for Freescale's PCS PHY

2015-12-28 Thread Florian Fainelli
Le 18/12/2015 01:30, shh@gmail.com a écrit : [snip] > +struct training_state_machine { > + bool bin_m1_late_early; > + bool bin_long_late_early; > + bool bin_m1_stop; > + bool bin_long_stop; > + bool tx_complete; > + bool an_ok; > + bool link_up; > + bool runnin

RE: [PATCH] net: phy: adds backplane driver for Freescale's PCS PHY

2015-12-22 Thread Shaohui Xie
> > I did missed the device tree binding documentation. > > This driver expected a property "lane-instance" in mdio bus node, and > > "lane-handle" and "lane-range" properties in phy node. > > > > The "lane-instance" indicates what the phy should be probed as, > > 1000BASE-KX or 10GBASE-KR, seems p

Re: [PATCH] net: phy: adds backplane driver for Freescale's PCS PHY

2015-12-22 Thread Andrew Lunn
> I did missed the device tree binding documentation. > This driver expected a property "lane-instance" in mdio bus node, and > "lane-handle" and "lane-range" properties in phy node. > > The "lane-instance" indicates what the phy should be probed as, > 1000BASE-KX or 10GBASE-KR, seems phy node is

RE: [PATCH] net: phy: adds backplane driver for Freescale's PCS PHY

2015-12-21 Thread Shaohui Xie
> On Fri, Dec 18, 2015 at 05:30:54PM +0800, shh@gmail.com wrote: > > +static int fsl_backplane_probe(struct phy_device *phydev) { > > + struct fsl_xgkr_inst *xgkr_inst; > > + struct device_node *child, *parent, *lane_node; > > + const char *lane_name; > > + int len; > > + int ret; > >

Re: [PATCH] net: phy: adds backplane driver for Freescale's PCS PHY

2015-12-18 Thread Andrew Lunn
On Fri, Dec 18, 2015 at 05:30:54PM +0800, shh@gmail.com wrote: > +static int fsl_backplane_probe(struct phy_device *phydev) > +{ > + struct fsl_xgkr_inst *xgkr_inst; > + struct device_node *child, *parent, *lane_node; > + const char *lane_name; > + int len; > + int ret; > +

Re: [PATCH] net: phy: adds backplane driver for Freescale's PCS PHY

2015-12-18 Thread kbuild test robot
Hi Shaohui, [auto build test ERROR on net/master] [also build test ERROR on v4.4-rc5 next-20151217] url: https://github.com/0day-ci/linux/commits/shh-xie-gmail-com/net-phy-adds-backplane-driver-for-Freescale-s-PCS-PHY/20151218-181424 config: um-allmodconfig (attached as .config) reproduce: