..@vger.kernel.org
> Subject: Re: [PATCH] net: mvneta: fix handling of the Tx descriptor counter
>
> On Mon, Nov 13, 2017 at 11:54:14PM +0900, David Miller wrote:
> > From: Simon Guinot
> > Date: Mon, 13 Nov 2017 15:51:15 +0100
> >
> > > IIUC the driver s
On Mon, Nov 13, 2017 at 11:54:14PM +0900, David Miller wrote:
> From: Simon Guinot
> Date: Mon, 13 Nov 2017 15:51:15 +0100
>
> > IIUC the driver stops the queue if a threshold of 316 Tx descriptors is
> > reached (default and worst value).
>
> That's a lot of latency.
OK, then I'll keep the "tx
From: Simon Guinot
Date: Mon, 13 Nov 2017 15:51:15 +0100
> IIUC the driver stops the queue if a threshold of 316 Tx descriptors is
> reached (default and worst value).
That's a lot of latency.
On Sat, Nov 11, 2017 at 06:45:04PM +0900, David Miller wrote:
> From: Simon Guinot
> Date: Wed, 8 Nov 2017 17:58:35 +0100
>
> > @@ -2413,8 +2416,7 @@ static int mvneta_tx(struct sk_buff *skb, struct
> > net_device *dev)
> > if (txq->count >= txq->tx_stop_threshold)
> >
From: Simon Guinot
Date: Wed, 8 Nov 2017 17:58:35 +0100
> @@ -2413,8 +2416,7 @@ static int mvneta_tx(struct sk_buff *skb, struct
> net_device *dev)
> if (txq->count >= txq->tx_stop_threshold)
> netif_tx_stop_queue(nq);
>
> - if (!skb->xmit_more
Hi Simon,
Until now it seems to work. No issues so far.
Regards and Thanks
Sven
Am Thu, 9 Nov 2017 20:19:42 +0100
schrieb Andreas Tobler :
> Hi Simon,
>
>
> On 08.11.17 18:17, Simon Guinot wrote:
> > Hi Sven and Andreas,
> >
> > Please, can you try with this patch ?
>
> Today we, my
Hi Simon,
On 08.11.17 18:17, Simon Guinot wrote:
Hi Sven and Andreas,
Please, can you try with this patch ?
Today we, my son and I, repeated the failing scenario and we were able
to show that our scenario behaves stable after you patch being applied.
Thanks for taking care of this issue.
Hi Sven and Andreas,
Please, can you try with this patch ?
Thanks.
Simon
On Wed, Nov 08, 2017 at 05:58:35PM +0100, Simon Guinot wrote:
> The mvneta controller provides a 8-bit register to update the pending
> Tx descriptor counter. Then, a maximum of 255 Tx descriptors can be
> added at once. I
From: Simon Guinot
> Sent: 08 November 2017 16:59
>
> The mvneta controller provides a 8-bit register to update the pending
> Tx descriptor counter. Then, a maximum of 255 Tx descriptors can be
> added at once. In the current code the mvneta_txq_pend_desc_add function
> assumes the caller takes ca
