Re: [PATCH] net: ethernet: ti: cpsw: allow to configure min tx packet size

2018-11-29 Thread Grygorii Strashko
Hi All, On 11/28/18 7:22 PM, David Miller wrote: > From: Andrew Lunn > Date: Thu, 29 Nov 2018 01:28:35 +0100 > >> On Wed, Nov 28, 2018 at 04:43:40PM -0600, Grygorii Strashko wrote: >>> Hi Andrew, >>> >>> On 11/28/18 4:02 PM, Andrew Lunn wrote: > This is dynamic configuration related to ALE V

Re: [PATCH] net: ethernet: ti: cpsw: allow to configure min tx packet size

2018-11-29 Thread Lad, Prabhakar
Hi Andrew, On Mon, Nov 26, 2018 at 2:27 AM Andrew Lunn wrote: > > On Sun, Nov 25, 2018 at 05:43:15PM -0600, Grygorii Strashko wrote: > > For proper VLAN packets forwarding CPSW driver uses min tx packet size of > > 64bytes (VLAN_ETH_ZLEN, excluding ETH_FCS) which was corrected by > > commit 9421c

RE: [PATCH] net: ethernet: ti: cpsw: allow to configure min tx packet size

2018-11-29 Thread David Laight
From: Grygorii Strashko > Sent: 25 November 2018 23:43 > > For proper VLAN packets forwarding CPSW driver uses min tx packet size of > 64bytes (VLAN_ETH_ZLEN, excluding ETH_FCS) which was corrected by > commit 9421c9015047 ("net: ethernet: ti: cpsw: fix min eth packet size"). > > Unfortunately, t

Re: [PATCH] net: ethernet: ti: cpsw: allow to configure min tx packet size

2018-11-28 Thread David Miller
From: Andrew Lunn Date: Thu, 29 Nov 2018 01:28:35 +0100 > On Wed, Nov 28, 2018 at 04:43:40PM -0600, Grygorii Strashko wrote: >> Hi Andrew, >> >> On 11/28/18 4:02 PM, Andrew Lunn wrote: >> >> This is dynamic configuration related to ALE VLAN entries and >> >> I do not see the way to support its a

Re: [PATCH] net: ethernet: ti: cpsw: allow to configure min tx packet size

2018-11-28 Thread Andrew Lunn
On Wed, Nov 28, 2018 at 04:43:40PM -0600, Grygorii Strashko wrote: > Hi Andrew, > > On 11/28/18 4:02 PM, Andrew Lunn wrote: > >> This is dynamic configuration related to ALE VLAN entries and > >> I do not see the way to support its auto-detection with current driver, > >> unfortunately. > > > > I

Re: [PATCH] net: ethernet: ti: cpsw: allow to configure min tx packet size

2018-11-28 Thread Grygorii Strashko
Hi Andrew, On 11/28/18 4:02 PM, Andrew Lunn wrote: >> This is dynamic configuration related to ALE VLAN entries and >> I do not see the way to support its auto-detection with current driver, >> unfortunately. > > I think you can subscribe to switchdev events which will tell you. Thanks a lot for

Re: [PATCH] net: ethernet: ti: cpsw: allow to configure min tx packet size

2018-11-28 Thread Andrew Lunn
> This is dynamic configuration related to ALE VLAN entries and > I do not see the way to support its auto-detection with current driver, > unfortunately. I think you can subscribe to switchdev events which will tell you. Andrew

Re: [PATCH] net: ethernet: ti: cpsw: allow to configure min tx packet size

2018-11-28 Thread Grygorii Strashko
On 11/27/18 10:49 PM, Andrew Lunn wrote: >> [1] https://e2e.ti.com/support/arm/sitara_arm/f/791/t/701669 > > Reading this, the interesting part is: > > My guess would be that the driver would have to track the > configuration of the switch hardware to correctly pad the > fram

Re: [PATCH] net: ethernet: ti: cpsw: allow to configure min tx packet size

2018-11-27 Thread Andrew Lunn
> [1] https://e2e.ti.com/support/arm/sitara_arm/f/791/t/701669 Reading this, the interesting part is: My guess would be that the driver would have to track the configuration of the switch hardware to correctly pad the frame. Have you tried that? Andrew

Re: [PATCH] net: ethernet: ti: cpsw: allow to configure min tx packet size

2018-11-27 Thread Grygorii Strashko
Hi Andrew, On 11/25/18 8:27 PM, Andrew Lunn wrote: > On Sun, Nov 25, 2018 at 05:43:15PM -0600, Grygorii Strashko wrote: >> For proper VLAN packets forwarding CPSW driver uses min tx packet size of >> 64bytes (VLAN_ETH_ZLEN, excluding ETH_FCS) which was corrected by >> commit 9421c9015047 ("net: et

Re: [PATCH] net: ethernet: ti: cpsw: allow to configure min tx packet size

2018-11-25 Thread Andrew Lunn
On Sun, Nov 25, 2018 at 05:43:15PM -0600, Grygorii Strashko wrote: > For proper VLAN packets forwarding CPSW driver uses min tx packet size of > 64bytes (VLAN_ETH_ZLEN, excluding ETH_FCS) which was corrected by > commit 9421c9015047 ("net: ethernet: ti: cpsw: fix min eth packet size"). > > Unfortu