t; Subject: Re: [PATCH] igb: reinit_locked() should be called with rtnl_lock
>
> >
> > So will you be sending a v2 of your patch to include the second fix?
>
> Yes, I am working on it. Just to confirm, v2 should include both fixes, right?
Correct.
>
> So will you be sending a v2 of your patch to include the second fix?
Yes, I am working on it. Just to confirm, v2 should include both fixes, right?
Thanks,
Francesco
> -Original Message-
> From: Francesco Ruggeri
> Sent: Thursday, July 2, 2020 12:35
> To: Kirsher, Jeffrey T
> Cc: Jakub Kicinski ; David Miller ;
> open list ; netdev ;
> intel-wired-...@lists.osuosl.org
> Subject: Re: [PATCH] igb: reinit_locked() should
> Do not worry about the other Intel drivers, I have our developers looking at
> each of our drivers for the locking issue.
>
> @David Miller - I am picking up this patch
There seems to be a second race, independent from the
original one, that results in a divide error:
kworker reboot -f
> -Original Message-
> From: Francesco Ruggeri
> Sent: Monday, June 29, 2020 21:51
> To: Jakub Kicinski
> Cc: open list ; netdev
> ; intel-wired-...@lists.osuosl.org; David Miller
> ; Kirsher, Jeffrey T
> Subject: Re: [PATCH] igb: reinit_locked() should
> Would you mind adding a fixes tag here? Probably:
>
> Fixes: 9d5c824399de ("igb: PCI-Express 82575 Gigabit Ethernet driver")
That seems to be the commit that introduced the driver in 2.6.25.
I am not familiar with the history of the driver to tell if this was a day 1
problem or if it became an i
On Mon, 29 Jun 2020 14:18:01 -0700 Francesco Ruggeri wrote:
> We observed a panic in igb_reset_task caused by this race condition
> when doing a reboot -f:
>
> kworker reboot -f
>
> igb_reset_task
> igb_reinit_locked
> igb_down
> napi_synchronize
>
