Re: [PATCH] TIPC: fix tipc_link_create error handling

2007-07-26 Thread David Miller
From: Florian Westphal <[EMAIL PROTECTED]> Date: Wed, 25 Jul 2007 00:02:56 +0200 > if printbuf allocation or tipc_node_attach_link() fails, invalid > references to the link are left in the associated node and bearer > structures. > Fix by allocating printbuf early and moving timer initialization >

RE: [PATCH] TIPC: fix tipc_link_create error handling

2007-07-23 Thread Stephens, Allan
Hi Florian: Changes look pretty good to me. I'd also recommend deferring the call to k_init_timer() to the same point as your list_add_tail() call. (If you don't, then there should really be a k_term_timer() call in the clean up code that handles a failure of tipc_node_attach_link().) Regards,