Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-06-19 Thread Jakub Kicinski
On Tue, 19 Jun 2018 16:37:15 -0500, Bjorn Helgaas wrote: > On Fri, May 25, 2018 at 09:02:23AM -0500, Bjorn Helgaas wrote: > > On Thu, May 24, 2018 at 06:20:15PM -0700, Jakub Kicinski wrote: > > > Hi Bjorn! > > > > > > On Thu, 24 May 2018 18:57:48 -0500, Bjorn Helgaas wrote: > > > > On Mon, Apr

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-06-19 Thread Bjorn Helgaas
On Fri, May 25, 2018 at 09:02:23AM -0500, Bjorn Helgaas wrote: > On Thu, May 24, 2018 at 06:20:15PM -0700, Jakub Kicinski wrote: > > Hi Bjorn! > > > > On Thu, 24 May 2018 18:57:48 -0500, Bjorn Helgaas wrote: > > > On Mon, Apr 02, 2018 at 03:46:52PM -0700, Jakub Kicinski wrote: > > > > Some user sp

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-05-29 Thread Don Dutile
On 05/25/2018 05:05 PM, Jakub Kicinski wrote: On Fri, 25 May 2018 09:02:23 -0500, Bjorn Helgaas wrote: On Thu, May 24, 2018 at 06:20:15PM -0700, Jakub Kicinski wrote: On Thu, 24 May 2018 18:57:48 -0500, Bjorn Helgaas wrote: On Mon, Apr 02, 2018 at 03:46:52PM -0700, Jakub Kicinski wrote: Some

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-05-29 Thread Don Dutile
On 05/25/2018 04:46 PM, Bjorn Helgaas wrote: On Fri, May 25, 2018 at 03:27:52PM -0400, Don Dutile wrote: On 05/25/2018 10:02 AM, Bjorn Helgaas wrote: On Thu, May 24, 2018 at 06:20:15PM -0700, Jakub Kicinski wrote: Hi Bjorn! On Thu, 24 May 2018 18:57:48 -0500, Bjorn Helgaas wrote: On Mon, Apr

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-05-25 Thread Bjorn Helgaas
On Fri, May 25, 2018 at 02:05:21PM -0700, Jakub Kicinski wrote: > On Fri, 25 May 2018 09:02:23 -0500, Bjorn Helgaas wrote: > > On Thu, May 24, 2018 at 06:20:15PM -0700, Jakub Kicinski wrote: > > > On Thu, 24 May 2018 18:57:48 -0500, Bjorn Helgaas wrote: > > > > On Mon, Apr 02, 2018 at 03:46:52PM

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-05-25 Thread Jakub Kicinski
On Fri, 25 May 2018 09:02:23 -0500, Bjorn Helgaas wrote: > On Thu, May 24, 2018 at 06:20:15PM -0700, Jakub Kicinski wrote: > > On Thu, 24 May 2018 18:57:48 -0500, Bjorn Helgaas wrote: > > > On Mon, Apr 02, 2018 at 03:46:52PM -0700, Jakub Kicinski wrote: > > > > Some user space depends on enabli

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-05-25 Thread Bjorn Helgaas
On Fri, May 25, 2018 at 03:27:52PM -0400, Don Dutile wrote: > On 05/25/2018 10:02 AM, Bjorn Helgaas wrote: > > On Thu, May 24, 2018 at 06:20:15PM -0700, Jakub Kicinski wrote: > > > Hi Bjorn! > > > > > > On Thu, 24 May 2018 18:57:48 -0500, Bjorn Helgaas wrote: > > > > On Mon, Apr 02, 2018 at 03:46:

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-05-25 Thread Don Dutile
On 05/25/2018 10:02 AM, Bjorn Helgaas wrote: On Thu, May 24, 2018 at 06:20:15PM -0700, Jakub Kicinski wrote: Hi Bjorn! On Thu, 24 May 2018 18:57:48 -0500, Bjorn Helgaas wrote: On Mon, Apr 02, 2018 at 03:46:52PM -0700, Jakub Kicinski wrote: Some user space depends on enabling sriov_totalvfs nu

RE: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-05-25 Thread Keller, Jacob E
@lists.osuosl.org > Subject: Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0 > > [+cc liquidio, benet, fm10k maintainers: > > The patch below will affect you if your driver calls > pci_sriov_set_totalvfs(dev, 0); > > Previously that caused a subse

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-05-25 Thread Bjorn Helgaas
[+cc liquidio, benet, fm10k maintainers: The patch below will affect you if your driver calls pci_sriov_set_totalvfs(dev, 0); Previously that caused a subsequent pci_sriov_get_totalvfs() to return the totalVFs value from the SR-IOV capability. After this patch, it will return 0, whic

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-05-25 Thread Bjorn Helgaas
On Thu, May 24, 2018 at 06:20:15PM -0700, Jakub Kicinski wrote: > Hi Bjorn! > > On Thu, 24 May 2018 18:57:48 -0500, Bjorn Helgaas wrote: > > On Mon, Apr 02, 2018 at 03:46:52PM -0700, Jakub Kicinski wrote: > > > Some user space depends on enabling sriov_totalvfs number of VFs > > > to not fail, e.g

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-05-24 Thread Jakub Kicinski
Hi Bjorn! On Thu, 24 May 2018 18:57:48 -0500, Bjorn Helgaas wrote: > On Mon, Apr 02, 2018 at 03:46:52PM -0700, Jakub Kicinski wrote: > > Some user space depends on enabling sriov_totalvfs number of VFs > > to not fail, e.g.: > > > > $ cat .../sriov_totalvfs > .../sriov_numvfs > > > > For devices

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-05-24 Thread Bjorn Helgaas
Hi Jakub, On Mon, Apr 02, 2018 at 03:46:52PM -0700, Jakub Kicinski wrote: > Some user space depends on enabling sriov_totalvfs number of VFs > to not fail, e.g.: > > $ cat .../sriov_totalvfs > .../sriov_numvfs > > For devices which VF support depends on loaded FW we have the > pci_sriov_{g,s}et_

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-04-02 Thread Jakub Kicinski
On Fri, 30 Mar 2018 09:54:37 -0700, Alexander Duyck wrote: > On Fri, Mar 30, 2018 at 4:49 AM, Christoph Hellwig wrote: > > On Thu, Mar 29, 2018 at 11:22:31AM -0700, Jakub Kicinski wrote: > >> Some user space depends on driver allowing sriov_totalvfs to be > >> enabled. > > > > I can't make sen

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-04-02 Thread Jakub Kicinski
On Fri, 30 Mar 2018 04:49:05 -0700, Christoph Hellwig wrote: > On Thu, Mar 29, 2018 at 11:22:31AM -0700, Jakub Kicinski wrote: > > Some user space depends on driver allowing sriov_totalvfs to be > > enabled. > > I can't make sene of this sentence. Can you explain what user space > code depends

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-03-30 Thread Alexander Duyck
On Fri, Mar 30, 2018 at 4:49 AM, Christoph Hellwig wrote: > On Thu, Mar 29, 2018 at 11:22:31AM -0700, Jakub Kicinski wrote: >> Some user space depends on driver allowing sriov_totalvfs to be >> enabled. > > I can't make sene of this sentence. Can you explain what user space > code depends on what

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-03-30 Thread Christoph Hellwig
On Thu, Mar 29, 2018 at 11:22:31AM -0700, Jakub Kicinski wrote: > Some user space depends on driver allowing sriov_totalvfs to be > enabled. I can't make sene of this sentence. Can you explain what user space code depends on what semantics? The sriov_totalvfs file should show up for any device s