RE: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver

2019-03-13 Thread Keller, Jacob E
> -Original Message- > From: Harini Katakam [mailto:hari...@xilinx.com] > Sent: Tuesday, March 12, 2019 11:00 PM > To: Keller, Jacob E > Cc: Paul Thomas ; netdev@vger.kernel.org > Subject: Re: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver > > Hi Paul, Jake, >

RE: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver

2019-03-13 Thread Keller, Jacob E
> -Original Message- > From: Harini Katakam [mailto:hari...@xilinx.com] > Sent: Tuesday, March 12, 2019 10:40 PM > To: Paul Thomas > Cc: Keller, Jacob E ; netdev@vger.kernel.org > Subject: Re: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver > > Hi Paul, Jake, >

Re: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver

2019-03-12 Thread Harini Katakam
To: netdev@vger.kernel.org > > Subject: Re: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver > > > > On Tue, Mar 12, 2019 at 3:51 PM Paul Thomas wrote: > > > > > > /* First, update TX stats if needed */ > > >

Re: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver

2019-03-12 Thread Harini Katakam
sday, March 12, 2019 3:05 PM > > > To: Keller, Jacob E > > > Cc: netdev@vger.kernel.org > > > Subject: Re: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver > > > > > > Hi Jake, thanks for all the help and for looking at this! > > > > > &

Re: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver

2019-03-12 Thread Paul Thomas
On Tue, Mar 12, 2019 at 7:07 PM Keller, Jacob E wrote: > > > > > -Original Message- > > From: Paul Thomas [mailto:pthomas8...@gmail.com] > > Sent: Tuesday, March 12, 2019 3:05 PM > > To: Keller, Jacob E > > Cc: netdev@vger.kernel.org > > Subj

RE: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver

2019-03-12 Thread Keller, Jacob E
> -Original Message- > From: Paul Thomas [mailto:pthomas8...@gmail.com] > Sent: Tuesday, March 12, 2019 3:05 PM > To: Keller, Jacob E > Cc: netdev@vger.kernel.org > Subject: Re: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver > > Hi Jake, thanks for all the

Re: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver

2019-03-12 Thread Paul Thomas
Hi Jake, thanks for all the help and for looking at this! > > You have two conditionals inside, and I misread where you were doing the > checking of the SKBTX_HW_TSTAMP flag. > > I would do the following : > > if (unlikely(skb_shinfo(skb)->tx_flags & SKBTX_HWTSTAMP) && > gem_ptp_do_txstamp(qu

RE: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver

2019-03-12 Thread Keller, Jacob E
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of Keller, Jacob E > Sent: Tuesday, March 12, 2019 2:35 PM > To: Paul Thomas ; netdev@vger.kernel.org > Subject: RE: [PATCH] Check for SKBTX_HW_TST

RE: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver

2019-03-12 Thread Keller, Jacob E
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of Paul Thomas > Sent: Tuesday, March 12, 2019 1:05 PM > To: netdev@vger.kernel.org > Subject: Re: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver > > O

RE: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver

2019-03-12 Thread Keller, Jacob E
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of Paul Thomas > Sent: Tuesday, March 12, 2019 12:51 PM > To: netdev@vger.kernel.org > Cc: Paul Thomas > Subject: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver > > Make sure SKBT

Re: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver

2019-03-12 Thread Paul Thomas
On Tue, Mar 12, 2019 at 3:51 PM Paul Thomas wrote: > > Make sure SKBTX_HW_TSTAMP (i.e. SOF_TIMESTAMPING_TX_HARDWARE) has been > enabled for this skb > This is a concept for discussion, more testing is needed. > It does fix the issue where normal socks that aren't expecting a timestamp > will not