RE: [PATCH] [TC U32] Fix input parsing to support more than 9 flow id'scorrectly

2008-02-12 Thread Waskiewicz Jr, Peter P
> Sorry, can't change the api, update the documentation instead. Yes, this is much more reasonable. I'll send a patch shortly to do that. Thanks -PJ Waskiewicz -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo inf

Re: [PATCH] [TC U32] Fix input parsing to support more than 9 flow id'scorrectly

2008-02-12 Thread Stephen Hemminger
Waskiewicz Jr, Peter P wrote: From: PJ Waskiewicz <[EMAIL PROTECTED]> Using strtoul with a base of 16 converts flowid 10 into 0x10, which makes it flowid 16. This is interpreted by the kernel incorrectly, and causes traffic flows above 9 to be classified into band 0 on multiband qdiscs. This

RE: [PATCH] [TC U32] Fix input parsing to support more than 9 flow id'scorrectly

2008-02-12 Thread Waskiewicz Jr, Peter P
> From: PJ Waskiewicz <[EMAIL PROTECTED]> > > Using strtoul with a base of 16 converts flowid 10 into 0x10, > which makes it flowid 16. This is interpreted by the kernel > incorrectly, and causes traffic flows above 9 to be > classified into band 0 on multiband qdiscs. > This changes the base