RE: [3/5] [NET]: Add software TSOv4

2006-06-26 Thread Ravinandan Arakali
We are working on it. Ravi -Original Message- From: YOSHIFUJI Hideaki / mailto:[EMAIL PROTECTED] Sent: Friday, June 23, 2006 6:33 PM To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; netdev@vger.kernel.org; [EMAIL PROTECTED] Subject: Re: [3/5] [NET]: Add software TSOv4 In

Re: [3/5] [NET]: Add software TSOv4

2006-06-25 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Fri, 23 Jun 2006 20:08:41 -0700 > On Sat, 2006-06-24 at 09:53 +1000, Herbert Xu wrote: > > > Nevermind, I obviously complete ignored your other fix to the length of > > the last segment :) Here is a fixed version. > > > > [NET]: Fix CHECKSUM_HW GSO

Re: [3/5] [NET]: Add software TSOv4

2006-06-23 Thread Michael Chan
On Sat, 2006-06-24 at 09:53 +1000, Herbert Xu wrote: > Nevermind, I obviously complete ignored your other fix to the length of > the last segment :) Here is a fixed version. > > [NET]: Fix CHECKSUM_HW GSO problems. > > Fix checksum problems in the GSO code path for CHECKSUM_HW packets. > > The

Re: [3/5] [NET]: Add software TSOv4

2006-06-23 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 23 Jun 2006 17:28:12 -0700), "Ravinandan Arakali" <[EMAIL PROTECTED]> says: > Neterion's Xframe adapter supports TSO over IPv6. I remember you posted some patches. Would you post revised version reflecting Stephen's comment, please? --yoshfuji - To unsubs

RE: [3/5] [NET]: Add software TSOv4

2006-06-23 Thread Ravinandan Arakali
Neterion's Xframe adapter supports TSO over IPv6. Ravi -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Behalf Of David Miller Sent: Thursday, June 22, 2006 2:32 PM To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED]; netdev@vger.kernel.org Subject: Re: [3/5] [NET]

Re: [3/5] [NET]: Add software TSOv4

2006-06-23 Thread Herbert Xu
On Sat, Jun 24, 2006 at 09:38:40AM +1000, herbert wrote: > > Good catch. Obviously the only CHECKSUM_HW I tested was loop :) > Looking at this again it seems that we can optimise it further so > how about this? Nevermind, I obviously complete ignored your other fix to the length of the last segm

Re: [3/5] [NET]: Add software TSOv4

2006-06-23 Thread Herbert Xu
On Fri, Jun 23, 2006 at 02:26:16PM -0700, Michael Chan wrote: > > This patch is more correct. Please ignore the previous one. > > [NET]: Fix CHECKSUM_HW GSO problems. > > Fix checksum problems in the GSO code path for CHECKSUM_HW packets. > > The ipv4 TCP pseudo header checksum has to be adjust

Re: [3/5] [NET]: Add software TSOv4

2006-06-23 Thread Michael Chan
On Fri, 2006-06-23 at 12:33 -0700, Michael Chan wrote: > On Thu, 2006-06-22 at 18:14 +1000, Herbert Xu wrote: > > [NET]: Add software TSOv4 > > > > This patch adds the GSO implementation for IPv4 TCP. > > Herbert, Looks like there were some problems in the CHECKSUM_HW case. > This patch should fi

Re: [3/5] [NET]: Add software TSOv4

2006-06-23 Thread Michael Chan
On Thu, 2006-06-22 at 18:14 +1000, Herbert Xu wrote: > [NET]: Add software TSOv4 > > This patch adds the GSO implementation for IPv4 TCP. Herbert, Looks like there were some problems in the CHECKSUM_HW case. This patch should fix it. Please double-check my checksum math. [NET]: Fix CHECKSUM_HW

Re: [3/5] [NET]: Add software TSOv4

2006-06-22 Thread David Miller
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Fri, 23 Jun 2006 00:04:03 +0900 (JST) > In article <[EMAIL PROTECTED]> (at Thu, 22 Jun 2006 18:14:00 +1000), Herbert > Xu <[EMAIL PROTECTED]> says: > > > [NET]: Add software TSOv4 > > > > This patch adds the GSO implementation for IPv4 TCP. > >

Re: [3/5] [NET]: Add software TSOv4

2006-06-22 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 22 Jun 2006 18:14:00 +1000), Herbert Xu <[EMAIL PROTECTED]> says: > [NET]: Add software TSOv4 > > This patch adds the GSO implementation for IPv4 TCP. > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> I'd appreciate if you code up IPv6 TCP as well. :-)

Re: [3/5] [NET]: Add software TSOv4

2006-06-22 Thread Herbert Xu
On Thu, Jun 22, 2006 at 06:14:00PM +1000, herbert wrote: > > [NET]: Add software TSOv4 Doh, forgot to remove an unused declaration. Here is an updated version. [NET]: Add software TSOv4 This patch adds the GSO implementation for IPv4 TCP. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Cheers,