Re: Question on DSA switches, IGMP forwarding and switchdev

2020-06-20 Thread Daniel Mack
On 6/20/20 4:35 PM, Andrew Lunn wrote: >> So yes, we can read the code here, but I'm wondering which packet types >> would then get this flag set, and which won't. Because in case of >> IGMP/MLD, the packets are in fact forwarded, but the meaning of the flag >> in skb is to prevent the skb from bei

Re: Question on DSA switches, IGMP forwarding and switchdev

2020-06-20 Thread Andrew Lunn
> So yes, we can read the code here, but I'm wondering which packet types > would then get this flag set, and which won't. Because in case of > IGMP/MLD, the packets are in fact forwarded, but the meaning of the flag > in skb is to prevent the skb from being forwarded further, which seems > wrong i

Re: Question on DSA switches, IGMP forwarding and switchdev

2020-06-19 Thread Daniel Mack
On 6/20/20 12:36 AM, Andrew Lunn wrote: >> I've run into the same issue. To resolve it, In my case, in the same file, >> I've had to send all IGMP control traffic to the CPU: >> skb->offload_fwd_mark = 1; >> switch (ih->type) { >> case IGMP_HOST_MEMBERSHIP_REPORT: >>

Re: Question on DSA switches, IGMP forwarding and switchdev

2020-06-19 Thread Daniel Mack
Hi Andrew, Thanks a lot for the quick reply! On 6/19/20 11:58 PM, Andrew Lunn wrote: > On Fri, Jun 19, 2020 at 11:31:04PM +0200, Daniel Mack wrote: >> When an IGMP query enters the switch, it is redirected to the CPU port >> as all 'external' ports are configured for IGMP/MLP snooping by the >>

Re: Question on DSA switches, IGMP forwarding and switchdev

2020-06-19 Thread Andrew Lunn
> I've run into the same issue. To resolve it, In my case, in the same file, > I've had to send all IGMP control traffic to the CPU: > skb->offload_fwd_mark = 1; > switch (ih->type) { > case IGMP_HOST_MEMBERSHIP_REPORT: > case IGMPV2_HOST_MEMBERSHIP_REPORT:

RE: Question on DSA switches, IGMP forwarding and switchdev

2020-06-19 Thread Jason Cobham
ainelli > Subject: Re: Question on DSA switches, IGMP forwarding and switchdev > > On Fri, Jun 19, 2020 at 11:31:04PM +0200, Daniel Mack wrote: > > Hi, > > > > I'm working on a custom board featuring a Marvell mv88e6085 Ethernet > > switch controlled by the Linux DSA

Re: Question on DSA switches, IGMP forwarding and switchdev

2020-06-19 Thread Andrew Lunn
On Fri, Jun 19, 2020 at 11:31:04PM +0200, Daniel Mack wrote: > Hi, > > I'm working on a custom board featuring a Marvell mv88e6085 Ethernet > switch controlled by the Linux DSA driver, and I'm facing an issue with > IGMP packet flows. > > Consider two Ethernet stations, each connected to the swit

Question on DSA switches, IGMP forwarding and switchdev

2020-06-19 Thread Daniel Mack
Hi, I'm working on a custom board featuring a Marvell mv88e6085 Ethernet switch controlled by the Linux DSA driver, and I'm facing an issue with IGMP packet flows. Consider two Ethernet stations, each connected to the switch on a dedicated port. A Linux bridge combines the two ports. In my setup,