Patrick McHardy wrote:
Ben Greear wrote:
Patrick McHardy wrote:
dst_prev is newly allocated in the loop a couple of lines above.
Ok, that makes sense now.
I also did not find a single neigh_put in the entire xfrm4_policy.c file.
Should include/net/xfrm.h's method: xfrm_dst_destroy rele
Ben Greear wrote:
Patrick McHardy wrote:
dst_prev is newly allocated in the loop a couple of lines above.
Ok, that makes sense now.
I also did not find a single neigh_put in the entire xfrm4_policy.c file.
Should include/net/xfrm.h's method: xfrm_dst_destroy release the
neighbour?
Not n
Patrick McHardy wrote:
Ben Greear wrote:
/* Copy neighbout for reachability confirmation */
dst_prev->neighbour= neigh_clone(rt->u.dst.neighbour)
This code in the method xfrm4_bundle_create appears to over-write
the dst_prev->neighbour member without ever checking to see if
Ben Greear wrote:
/* Copy neighbout for reachability confirmation */
dst_prev->neighbour= neigh_clone(rt->u.dst.neighbour)
This code in the method xfrm4_bundle_create appears to over-write
the dst_prev->neighbour member without ever checking to see if it
needed to release the
/* Copy neighbout for reachability confirmation */
dst_prev->neighbour = neigh_clone(rt->u.dst.neighbour)
This code in the method xfrm4_bundle_create appears to over-write
the dst_prev->neighbour member without ever checking to see if it
needed to release the old
