Re: Possible bug into DSA2 code.

2019-02-20 Thread Andrew Lunn
On Wed, Feb 20, 2019 at 08:54:01AM +0100, Rodolfo Giometti wrote: > On 19/02/2019 01:03, Andrew Lunn wrote: > >>diff --git a/drivers/net/dsa/mv88e6xxx/chip.c > >>b/drivers/net/dsa/mv88e6xxx/chip.c > >>index 54a5b660640a..bb46ebbb2bb8 100644 > >>--- a/drivers/net/dsa/mv88e6xxx/chip.c > >>+++ b/driv

Re: Possible bug into DSA2 code.

2019-02-19 Thread Rodolfo Giometti
On 19/02/2019 01:03, Andrew Lunn wrote: diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 54a5b660640a..bb46ebbb2bb8 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -2399,7 +2399,7 @@ static int mv88e6xxx_setup(struct ds

Re: Possible bug into DSA2 code.

2019-02-18 Thread Andrew Lunn
> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c > b/drivers/net/dsa/mv88e6xxx/chip.c > index 54a5b660640a..bb46ebbb2bb8 100644 > --- a/drivers/net/dsa/mv88e6xxx/chip.c > +++ b/drivers/net/dsa/mv88e6xxx/chip.c > @@ -2399,7 +2399,7 @@ static int mv88e6xxx_setup(struct dsa_switch *ds) > int i

Re: Possible bug into DSA2 code.

2019-02-18 Thread Rodolfo Giometti
On 11/02/2019 20:13, Florian Fainelli wrote: Does that work: diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c index a1917025e155..54cf6a5c865d 100644 --- a/net/dsa/dsa2.c +++ b/net/dsa/dsa2.c @@ -368,6 +368,9 @@ static int dsa_switch_setup(struct dsa_switch *ds) if (err) re

Re: Possible bug into DSA2 code.

2019-02-11 Thread Florian Fainelli
On 2/11/19 10:01 AM, Florian Fainelli wrote: > On 2/11/19 9:51 AM, Rodolfo Giometti wrote: >> On 11/02/2019 18:28, Florian Fainelli wrote: >>> On 2/10/19 3:45 AM, Rodolfo Giometti wrote: On 09/02/2019 20:34, Andrew Lunn wrote: >> So we I see two possible solutions: >> >> 1) having

Re: Possible bug into DSA2 code.

2019-02-11 Thread Florian Fainelli
On 2/11/19 9:51 AM, Rodolfo Giometti wrote: > On 11/02/2019 18:28, Florian Fainelli wrote: >> On 2/10/19 3:45 AM, Rodolfo Giometti wrote: >>> On 09/02/2019 20:34, Andrew Lunn wrote: > So we I see two possible solutions: > > 1) having both ds->slave_mii_bus and ds->ops->phy_read already

Re: Possible bug into DSA2 code.

2019-02-11 Thread Rodolfo Giometti
On 11/02/2019 18:28, Florian Fainelli wrote: On 2/10/19 3:45 AM, Rodolfo Giometti wrote: On 09/02/2019 20:34, Andrew Lunn wrote: So we I see two possible solutions: 1) having both ds->slave_mii_bus and ds->ops->phy_read already defined is an error, then it must be signaled to the calling code,

Re: Possible bug into DSA2 code.

2019-02-11 Thread Florian Fainelli
On 2/10/19 3:45 AM, Rodolfo Giometti wrote: > On 09/02/2019 20:34, Andrew Lunn wrote: >>> So we I see two possible solutions: >>> >>> 1) having both ds->slave_mii_bus and ds->ops->phy_read already >>> defined is an >>> error, then it must be signaled to the calling code, or >> >> I don't think we c

Re: Possible bug into DSA2 code.

2019-02-10 Thread Rodolfo Giometti
On 09/02/2019 20:34, Andrew Lunn wrote: So we I see two possible solutions: 1) having both ds->slave_mii_bus and ds->ops->phy_read already defined is an error, then it must be signaled to the calling code, or I don't think we can do that. mv88e6xxx optionally instantiates the MDIO busses, depe

Re: Possible bug into DSA2 code.

2019-02-09 Thread Andrew Lunn
> So we I see two possible solutions: > > 1) having both ds->slave_mii_bus and ds->ops->phy_read already defined is an > error, then it must be signaled to the calling code, or I don't think we can do that. mv88e6xxx optionally instantiates the MDIO busses, depending on what is in device tree. If

Re: Possible bug into DSA2 code.

2019-02-09 Thread Rodolfo Giometti
Hello, I'm working with EPRESSObin and DSA2 where I added the ability to dynamically load and unload switch configurations by using DT-overlay (a patchwork from here https://lore.kernel.org/patchwork/patch/468129/). During my tests I notice that when I remove the overlay in order to disable th