Michael Wu wrote:
On Saturday 15 September 2007 20:56, Jeff Garzik wrote:
+ if (flags & IFF_PROMISC)
+ dev->flags |= IEEE80211_HW_RX_INCLUDES_FCS;
+ else
+ dev->flags &= ~IEEE80211_HW_RX_INCLUDES_FCS;
why does promisc dictate inclusion of FCS?
Because th
On Sunday 16 September 2007 00:50, David Miller wrote:
> From: Michael Wu <[EMAIL PROTECTED]>
> Date: Sun, 16 Sep 2007 00:47:40 -0400
>
> > Huh? How does a driver use NAPI if it can't pass a struct net_device?
>
> It is now managed by a struct napi_struct which you can embed into any
> object you l
From: Michael Wu <[EMAIL PROTECTED]>
Date: Sun, 16 Sep 2007 00:47:40 -0400
> Huh? How does a driver use NAPI if it can't pass a struct net_device?
It is now managed by a struct napi_struct which you can embed into any
object you like.
NAPI is now totally disconnected from the network device stru
On Saturday 15 September 2007 20:56, Jeff Garzik wrote:
> >>> + if (flags & IFF_PROMISC)
> >>> + dev->flags |= IEEE80211_HW_RX_INCLUDES_FCS;
> >>> + else
> >>> + dev->flags &= ~IEEE80211_HW_RX_INCLUDES_FCS;
> >>
> >> why does promisc dictate inclusion of FCS?
> >
> > Because that's
John W. Linville wrote:
On Sat, Sep 15, 2007 at 11:25:49AM -0700, David Miller wrote:
4) Integrate linville's adm8211 driver into net-2.6.24
We'll see how well that goes.
It sounds like Michael will be respinning in response to Jeff's
comments...?
It's already pulled, so I assume it will be
On Sat, Sep 15, 2007 at 11:25:49AM -0700, David Miller wrote:
> From: "John W. Linville" <[EMAIL PROTECTED]>
> Date: Sat, 15 Sep 2007 13:00:18 -0400
>
> > Come to think of it, this driver will depend on some of the mac80211
> > patches Dave M. has queued for net-2.6.24. Perhaps it would be better
Michael Wu wrote:
On Saturday 15 September 2007 17:32, Jeff Garzik wrote:
Review summary: many minor issues, only one major one: irq handler loop
CCing me would help.
Sorry. I just hit 'reply to all'... apparently you were not CC'd on
the submission.
+ if (flags & IFF_PROMISC)
On Saturday 15 September 2007 17:32, Jeff Garzik wrote:
> Review summary: many minor issues, only one major one: irq handler loop
>
CCing me would help.
> John W. Linville wrote:
> > +static unsigned int tx_ring_size __read_mostly = 16;
> > +static unsigned int rx_ring_size __read_mostly = 16;
>
On Saturday 15 September 2007 09:22, John W. Linville wrote:
> It is reverse-engineered and still has more magic
> initialization numbers than I'd like, but overall I think it would
> be better to have this upstream than not.
>
Not entirely accurate, as ADMtek released specs (publically downloadabl
Review summary: many minor issues, only one major one: irq handler loop
John W. Linville wrote:
+static unsigned int tx_ring_size __read_mostly = 16;
+static unsigned int rx_ring_size __read_mostly = 16;
+
+module_param(tx_ring_size, uint, 0);
+module_param(rx_ring_size, uint, 0);
should b
From: "John W. Linville" <[EMAIL PROTECTED]>
Date: Sat, 15 Sep 2007 13:00:18 -0400
> Come to think of it, this driver will depend on some of the mac80211
> patches Dave M. has queued for net-2.6.24. Perhaps it would be better
> if Dave were to merge it with his tree?
>
> Jeff, if you have no obj
11 matches
Mail list logo
