Re: Per-queue XDP programs, thoughts

2019-04-17 Thread Tom Herbert
On Tue, Apr 16, 2019 at 7:48 AM Jesper Dangaard Brouer wrote: > > On Mon, 15 Apr 2019 10:58:07 -0700 > "Jonathan Lemon" wrote: > > > On 15 Apr 2019, at 9:32, Jesper Dangaard Brouer wrote: > > > > > On Mon, 15 Apr 2019 13:59:03 +0200 Björn Töpel > > > wrote: > > > > > >> Hi, > > >> > > >> As you

Re: Per-queue XDP programs, thoughts

2019-04-17 Thread Björn Töpel
On Mon, 15 Apr 2019 at 18:33, Jesper Dangaard Brouer wrote: > [...] > > > > Ok, please convince me! :-D > > I tried to above... > I think you (and Jakub) did. :-) Looks like a "queue" is a good (necessary) abstraction, but I need to think more about how to e.g. access "dedicated/isolated" AF_XDP

Re: Per-queue XDP programs, thoughts

2019-04-16 Thread Jakub Kicinski
On Tue, 16 Apr 2019 15:55:23 +0200, Jesper Dangaard Brouer wrote: > On Mon, 15 Apr 2019 15:49:32 -0700 > Jakub Kicinski wrote: > > > On Mon, 15 Apr 2019 18:32:58 +0200, Jesper Dangaard Brouer wrote: > > > On Mon, 15 Apr 2019 13:59:03 +0200 Björn Töpel > > > wrote: > > > > Hi, > > > > > >

Re: Per-queue XDP programs, thoughts

2019-04-16 Thread Jakub Kicinski
On Tue, 16 Apr 2019 09:45:24 +0200, Björn Töpel wrote: > > > > If we'd like to slice a netdevice into multiple queues. Isn't macvlan > > > > or similar *virtual* netdevices a better path, instead of introducing > > > > yet another abstraction? > > > > Yes, the question of use cases is extremely i

Re: Per-queue XDP programs, thoughts

2019-04-16 Thread Björn Töpel
On Tue, 16 Apr 2019 at 18:53, Jonathan Lemon wrote: > > On 16 Apr 2019, at 6:55, Jesper Dangaard Brouer wrote: > > > On Mon, 15 Apr 2019 15:49:32 -0700 > > Jakub Kicinski wrote: > > > >> On Mon, 15 Apr 2019 18:32:58 +0200, Jesper Dangaard Brouer wrote: > >>> On Mon, 15 Apr 2019 13:59:03 +0200 Bjö

Re: Per-queue XDP programs, thoughts

2019-04-16 Thread Jonathan Lemon
On 16 Apr 2019, at 6:55, Jesper Dangaard Brouer wrote: On Mon, 15 Apr 2019 15:49:32 -0700 Jakub Kicinski wrote: On Mon, 15 Apr 2019 18:32:58 +0200, Jesper Dangaard Brouer wrote: On Mon, 15 Apr 2019 13:59:03 +0200 Björn Töpel wrote: Hi, As you probably can derive from the amount of time th

Re: Per-queue XDP programs, thoughts

2019-04-16 Thread Jesper Dangaard Brouer
On Mon, 15 Apr 2019 10:58:07 -0700 "Jonathan Lemon" wrote: > On 15 Apr 2019, at 9:32, Jesper Dangaard Brouer wrote: > > > On Mon, 15 Apr 2019 13:59:03 +0200 Björn Töpel > > wrote: > > > >> Hi, > >> > >> As you probably can derive from the amount of time this is taking, > >> I'm > >> not rea

Re: Per-queue XDP programs, thoughts

2019-04-16 Thread Jesper Dangaard Brouer
On Mon, 15 Apr 2019 15:49:32 -0700 Jakub Kicinski wrote: > On Mon, 15 Apr 2019 18:32:58 +0200, Jesper Dangaard Brouer wrote: > > On Mon, 15 Apr 2019 13:59:03 +0200 Björn Töpel > > wrote: > > > Hi, > > > > > > As you probably can derive from the amount of time this is taking, I'm > > > not re

Re: Per-queue XDP programs, thoughts

2019-04-16 Thread Toke Høiland-Jørgensen
Björn Töpel writes: > On 2019-04-16 11:36, Toke Høiland-Jørgensen wrote: >> Björn Töpel writes: >> >>> On Mon, 15 Apr 2019 at 18:33, Jesper Dangaard Brouer >>> wrote: On Mon, 15 Apr 2019 13:59:03 +0200 Björn Töpel wrote: > Hi, > > As you probably can der

Re: Per-queue XDP programs, thoughts

2019-04-16 Thread Björn Töpel
On 2019-04-16 11:36, Toke Høiland-Jørgensen wrote: Björn Töpel writes: On Mon, 15 Apr 2019 at 18:33, Jesper Dangaard Brouer wrote: On Mon, 15 Apr 2019 13:59:03 +0200 Björn Töpel wrote: Hi, As you probably can derive from the amount of time this is taking, I'm not really satisfied with

Re: Per-queue XDP programs, thoughts

2019-04-16 Thread Jason Wang
On 2019/4/16 上午12:32, Jesper Dangaard Brouer wrote: XDP is something that we can attach to a netdevice. Again, very natural from a user perspective. As for XDP sockets, the current mechanism is that we attach to an existing netdevice queue. Ideally what we'd like is to*remove* the queue concep

Re: Per-queue XDP programs, thoughts

2019-04-16 Thread Jason Wang
On 2019/4/16 上午12:32, Jesper Dangaard Brouer wrote: If we'd like to slice a netdevice into multiple queues. Isn't macvlan or similar*virtual* netdevices a better path, instead of introducing yet another abstraction? XDP redirect a more generic abstraction that allow us to implement macvlan.

Re: Per-queue XDP programs, thoughts

2019-04-16 Thread Toke Høiland-Jørgensen
Björn Töpel writes: > On Mon, 15 Apr 2019 at 18:33, Jesper Dangaard Brouer > wrote: >> >> >> On Mon, 15 Apr 2019 13:59:03 +0200 Björn Töpel wrote: >> >> > Hi, >> > >> > As you probably can derive from the amount of time this is taking, I'm >> > not really satisfied with the design of per-queue

Re: Per-queue XDP programs, thoughts

2019-04-16 Thread Björn Töpel
On Tue, 16 Apr 2019 at 00:49, Jakub Kicinski wrote: > > On Mon, 15 Apr 2019 18:32:58 +0200, Jesper Dangaard Brouer wrote: > > On Mon, 15 Apr 2019 13:59:03 +0200 Björn Töpel > > wrote: > > > Hi, > > > > > > As you probably can derive from the amount of time this is taking, I'm > > > not really sa

Re: Per-queue XDP programs, thoughts

2019-04-16 Thread Björn Töpel
On Mon, 15 Apr 2019 at 18:33, Jesper Dangaard Brouer wrote: > > > On Mon, 15 Apr 2019 13:59:03 +0200 Björn Töpel wrote: > > > Hi, > > > > As you probably can derive from the amount of time this is taking, I'm > > not really satisfied with the design of per-queue XDP program. (That, > > plus I'm a

Re: Per-queue XDP programs, thoughts

2019-04-15 Thread Jakub Kicinski
On Mon, 15 Apr 2019 18:32:58 +0200, Jesper Dangaard Brouer wrote: > On Mon, 15 Apr 2019 13:59:03 +0200 Björn Töpel wrote: > > Hi, > > > > As you probably can derive from the amount of time this is taking, I'm > > not really satisfied with the design of per-queue XDP program. (That, > > plus I'm a

Re: Per-queue XDP programs, thoughts

2019-04-15 Thread Jonathan Lemon
On 15 Apr 2019, at 9:32, Jesper Dangaard Brouer wrote: On Mon, 15 Apr 2019 13:59:03 +0200 Björn Töpel wrote: Hi, As you probably can derive from the amount of time this is taking, I'm not really satisfied with the design of per-queue XDP program. (That, plus I'm a terribly slow hacker..

Re: Per-queue XDP programs, thoughts

2019-04-15 Thread Toke Høiland-Jørgensen
Jesper Dangaard Brouer writes: > On Mon, 15 Apr 2019 13:59:03 +0200 Björn Töpel wrote: > >> Hi, >> >> As you probably can derive from the amount of time this is taking, I'm >> not really satisfied with the design of per-queue XDP program. (That, >> plus I'm a terribly slow hacker... ;-)) I'll t

Re: Per-queue XDP programs, thoughts

2019-04-15 Thread Jesper Dangaard Brouer
On Mon, 15 Apr 2019 13:59:03 +0200 Björn Töpel wrote: > Hi, > > As you probably can derive from the amount of time this is taking, I'm > not really satisfied with the design of per-queue XDP program. (That, > plus I'm a terribly slow hacker... ;-)) I'll try to expand my thinking > in this mail