Re: [PATCH] Add a network activity LED trigger

2007-07-18 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 18 Jul 2007 15:54:56 +0200 > Florian Fainelli wrote: > >> Besides missing a declaration and not linking without the network > >> LED config option, its pretty ridiculous to call this for every > >> packet just to make a led blink. > >> > >

Re: [PATCH] Add a network activity LED trigger

2007-07-18 Thread Patrick McHardy
Richard Purdie wrote: On Wed, 2007-07-18 at 15:54 +0200, Patrick McHardy wrote: Florian Fainelli wrote: Besides missing a declaration and not linking without the network LED config option, its pretty ridiculous to call this for every packet just to make a led blink. Could

Re: [PATCH] Add a network activity LED trigger

2007-07-18 Thread Richard Purdie
On Wed, 2007-07-18 at 15:54 +0200, Patrick McHardy wrote: > Florian Fainelli wrote: > >> Besides missing a declaration and not linking without the network > >> LED config option, its pretty ridiculous to call this for every > >> packet just to make a led blink. > >> > > > > Could you suggest m

Re: [PATCH] Add a network activity LED trigger

2007-07-18 Thread Patrick McHardy
Florian Fainelli wrote: Besides missing a declaration and not linking without the network LED config option, its pretty ridiculous to call this for every packet just to make a led blink. Could you suggest me a better way to do so ? The code was highly inspired from what is done with the I

Re: [PATCH] Add a network activity LED trigger

2007-07-18 Thread Florian Fainelli
Hello Patrick, Le mercredi 18 juillet 2007, Patrick McHardy a écrit : > Module isn't possible, you call the led trigger from net/core/dev.c. You are right, it just occured to me. > Besides missing a declaration and not linking without the network > LED config option, its pretty ridiculous to cal

Re: [PATCH] Add a network activity LED trigger

2007-07-18 Thread Stephen Hemminger
On Wed, 18 Jul 2007 15:27:38 +0200 Florian Fainelli <[EMAIL PROTECTED]> wrote: > Hi all, > > This patch adds a new LED trigger, based on network activity. It gathers > activity from net/core/dev.c and can be used as a LED trigger by > specifying "network-activity". Further version should allow

Re: [PATCH] Add a network activity LED trigger

2007-07-18 Thread Patrick McHardy
Florian Fainelli wrote: > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig > index 87d2046..fdc5a8a 100644 > --- a/drivers/leds/Kconfig > +++ b/drivers/leds/Kconfig > @@ -128,5 +128,12 @@ config LEDS_TRIGGER_HEARTBEAT > load average. > If unsure, say Y. > > +config LEDS_TR

[PATCH] Add a network activity LED trigger

2007-07-18 Thread Florian Fainelli
Hi all, This patch adds a new LED trigger, based on network activity. It gathers activity from net/core/dev.c and can be used as a LED trigger by specifying "network-activity". Further version should allow the user to specify the network interface to bind a LED to. This trigger is a "simple" t

Re: Network activity LED trigger

2007-05-23 Thread jamal
You know that you posted this exact message last time? ;-> And i responded here: http://marc.info/?l=linux-netdev&m=117882888105536&w=2 cheers, jamal On Wed, 2007-23-05 at 23:02 +0200, Florian Fainelli wrote: > Here comes a basic patch that adds a network led activity. It is not > configurable

Network activity LED trigger

2007-05-23 Thread Florian Fainelli
Here comes a basic patch that adds a network led activity. It is not configurable yet, but is enough to make a LED configured with the "network-activity" trigger to blink on network activity. Netdev people can probably comment on the place of ledtrig_network_activity(), which is probably not ad

Re: Network activity LED trigger

2007-05-10 Thread jamal
On Thu, 2007-10-05 at 21:21 +0200, Florian Fainelli wrote: > Netdev people can probably comment on the place of > ledtrig_network_activity(), > which is probably not adequate. Also the ledtrig_network_activity can be > network device specific for instance. Thanks for CCing me Florian. Yes, le

Re: Network activity LED trigger

2007-05-10 Thread Florian Fainelli
Hi all, Here comes a basic patch that adds a network led activity. It is not configurable yet, but is enough to make a LED configured with the "network-activity" trigger to blink on network activity. Netdev people can probably comment on the place of ledtrig_network_activity(), which is probab

Re: Network activity LED trigger

2007-03-02 Thread Andi Kleen
Florian Fainelli <[EMAIL PROTECTED]> writes: > Hi All, > > I have been talking a bit with Richard, who is the LED API maintainer, and a > LED trigger based on network activity would be something great. You should be aware that normally the kernel doesn't see all packets on a ethernet unless pro

Re: Network activity LED trigger

2007-03-02 Thread jamal
On Fri, 2007-02-03 at 16:03 +, Richard Purdie wrote: > On Fri, 2007-03-02 at 10:16 -0500, jamal wrote: > We already have this API, see drivers/leds ;-) Very cool ;-> I was not aware of the existence of this API. Actually i dont think it was available around 2.6.10. > We have LEDs which show

Re: Network activity LED trigger

2007-03-02 Thread Richard Purdie
On Fri, 2007-03-02 at 10:16 -0500, jamal wrote: > Heres my view of what would be useful: > Have them accessible via the kernel, but also have an API from user > space. This way user space apps can control the LED, but if i wanted to > do it from the kernel i could as well. In my case i was actually

Re: Network activity LED trigger

2007-03-02 Thread jamal
On Fri, 2007-02-03 at 15:16 +0100, Florian Fainelli wrote: > Hi, > > Le vendredi 2 mars 2007, jamal a écrit : > > Where are these LEDs typically located? Are you talking about LEDs on a > > network card for example? can you light them up in different colors? > > Those LEDS are typically controlle

Re: Network activity LED trigger

2007-03-02 Thread Florian Fainelli
Hi, Le vendredi 2 mars 2007, jamal a écrit : > Where are these LEDs typically located? Are you talking about LEDs on a > network card for example? can you light them up in different colors? Those LEDS are typically controlled by GPIO lines visible in front of the device. It is mostly targeted to

Re: Network activity LED trigger

2007-03-02 Thread jamal
Where are these LEDs typically located? Are you talking about LEDs on a network card for example? can you light them up in different colors? cheers, jamal On Fri, 2007-02-03 at 13:58 +0100, Florian Fainelli wrote: > Hi All, > > Some more thoughts. The IDE activity LED trigger is currently trigg

Re: Network activity LED trigger

2007-03-02 Thread Florian Fainelli
Hi All, Some more thoughts. The IDE activity LED trigger is currently triggered when a function is called in the IDE writing/reading routines. In a similar way, we could call the trigger function in net/core/dev.c in netif_receive_skb and netif_rx ? I was also thinking that some network NIC al

Network activity LED trigger

2007-03-01 Thread Florian Fainelli
Hi All, I have been talking a bit with Richard, who is the LED API maintainer, and a LED trigger based on network activity would be something great. There are somethings that concern the network stack : - should we specify if the network driver is allowed to contribute to the LED activity, just