Re: Netpoll checksum issue

2006-04-27 Thread Herbert Xu
On Thu, Apr 27, 2006 at 08:57:33PM +0800, Aubrey wrote: > > Is there any update of this issue? Assuming that the CHECKSUM_UNNECESSARY line wasn't there, then the problem is simply that your packet has the wrong UDP checksum. So I suggest that you print the packet out and compare it with the origi

Re: Netpoll checksum issue

2006-04-27 Thread Aubrey
Hi Herbert, Is there any update of this issue? Regards, - Aubrey On 4/24/06, Aubrey <[EMAIL PROTECTED]> wrote: > On 4/24/06, Herbert Xu <[EMAIL PROTECTED]> wrote: > > On Mon, Apr 24, 2006 at 01:42:12PM +0800, Aubrey wrote: > > > > > > dev->last_rx = jiffies; > > > skb->dev = dev; > > > skb

Re: Netpoll checksum issue

2006-04-24 Thread Aubrey
On 4/24/06, Herbert Xu <[EMAIL PROTECTED]> wrote: > On Mon, Apr 24, 2006 at 01:42:12PM +0800, Aubrey wrote: > > > > dev->last_rx = jiffies; > > skb->dev = dev; > > skb->protocol = eth_type_trans(skb, dev); > > skb->ip_summed = CHECKSUM_UNNECESSARY; > > netif_rx(skb); > > This doesn't make

Re: Netpoll checksum issue

2006-04-24 Thread Herbert Xu
On Mon, Apr 24, 2006 at 01:42:12PM +0800, Aubrey wrote: > > dev->last_rx = jiffies; > skb->dev = dev; > skb->protocol = eth_type_trans(skb, dev); > skb->ip_summed = CHECKSUM_UNNECESSARY; > netif_rx(skb); This doesn't make sense. First of all you're setting ip_summed to CHECK_UNNECESSARY

Re: Netpoll checksum issue

2006-04-24 Thread Aubrey
Hi Herbert, The following change works properly on my side, it just do the same thing as the driver not in netpoll mode. Let me know it's acceptable, please. Thanks, -Aubrey == int __netpoll_rx(struct sk_buff *skb) { snip if (ip_

Re: Netpoll checksum issue

2006-04-24 Thread Aubrey
Hi Herbert, Things seem to be more clear for me. When not in netpoll mode, before an udp package passed to "udp_rcv", the ip layer will call the routine "__skb_checksum_complete(skb);" to do the checksum. After ip checksum, "skb->ip_summed" will be assigned to CHECKSUM_UNNECESSARY.

Re: Netpoll checksum issue

2006-04-23 Thread Aubrey
On 4/23/06, Herbert Xu <[EMAIL PROTECTED]> wrote: > On Thu, Apr 20, 2006 at 09:54:54AM +0800, Aubrey wrote: > Please send me a copy of the driver source that you were using when > this happened. The driver is attached. > Could you please add a printk in checksum_udp to print out the pertinent > v

Re: Netpoll checksum issue

2006-04-23 Thread Herbert Xu
On Thu, Apr 20, 2006 at 09:54:54AM +0800, Aubrey wrote: > > Hi Herbert - I'm working on blackfin uclinux platform. My network > driver is for blackfin on-chip EMAC. Of course it's open source, but > so far it's not committed into mainline tree. We can be found at here: > http://www.blackfin.uclinux

Re: Netpoll checksum issue

2006-04-19 Thread Aubrey
On 4/20/06, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > The changes to how hardware receive checksums are handled broke > the netpoll checksum code (for CHECKSUM_HW). Since this is not at > all performance critical, try this patch. It changes to always to > normal software checksum. > Hi Stephe

Re: Fw: Netpoll checksum issue

2006-04-19 Thread Herbert Xu
> Date: Thu, 20 Apr 2006 00:22:16 +0800 > From: Aubrey <[EMAIL PROTECTED]> > Newsgroups: linux.dev.kernel > Subject: Netpoll checksum issue > > I'm porting my network driver from 2.6.12 to 2.6.16. It almostly work > without any change, except the netpoll mode. W

Re: Netpoll checksum issue

2006-04-19 Thread Herbert Xu
On Wed, Apr 19, 2006 at 10:31:53AM -0700, Stephen Hemminger wrote: > The changes to how hardware receive checksums are handled broke > the netpoll checksum code (for CHECKSUM_HW). Since this is not at > all performance critical, try this patch. It changes to always to > normal software checksum.

Re: Netpoll checksum issue

2006-04-19 Thread Stephen Hemminger
The changes to how hardware receive checksums are handled broke the netpoll checksum code (for CHECKSUM_HW). Since this is not at all performance critical, try this patch. It changes to always to normal software checksum. --- linux-2.6.orig/net/core/netpoll.c 2006-03-22 09:30:56.0 -0800

Fw: Netpoll checksum issue

2006-04-19 Thread Stephen Hemminger
Begin forwarded message: Date: Thu, 20 Apr 2006 00:22:16 +0800 From: Aubrey <[EMAIL PROTECTED]> Newsgroups: linux.dev.kernel Subject: Netpoll checksum issue Hi all, I'm porting my network driver from 2.6.12 to 2.6.16. It almostly work without any change, except the netpoll mode.