Re: NAPI: Polling function requesting extra calls - difference between 3.18.11 and 4.0.0

2015-04-23 Thread Eric Dumazet
On Thu, 2015-04-23 at 21:08 +0200, Rafał Miłecki wrote: > As you obviously noticed, I fixed bgmac now and submitted the fix. > > Just wanted to say a thanks for helping with that! > Sure, it was a pleasure ;) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

Re: NAPI: Polling function requesting extra calls - difference between 3.18.11 and 4.0.0

2015-04-23 Thread Rafał Miłecki
On 23 April 2015 at 20:28, Eric Dumazet wrote: > On Thu, 2015-04-23 at 20:18 +0200, Rafał Miłecki wrote: > >> >> Can you help us with this, please? Does bgmac use NAPI incorrectly? >> Were there some important changes in 3.19 or 4.0? >> > > Right they were important changes in NAPI indeed : > > 3b

Re: NAPI: Polling function requesting extra calls - difference between 3.18.11 and 4.0.0

2015-04-23 Thread Rafał Miłecki
On 23 April 2015 at 20:33, Eric Dumazet wrote: > On Thu, 2015-04-23 at 11:28 -0700, Eric Dumazet wrote: >> On Thu, 2015-04-23 at 20:18 +0200, Rafał Miłecki wrote: >> >> > >> > Can you help us with this, please? Does bgmac use NAPI incorrectly? >> > Were there some important changes in 3.19 or 4.0?

Re: NAPI: Polling function requesting extra calls - difference between 3.18.11 and 4.0.0

2015-04-23 Thread Eric Dumazet
On Thu, 2015-04-23 at 11:28 -0700, Eric Dumazet wrote: > On Thu, 2015-04-23 at 20:18 +0200, Rafał Miłecki wrote: > > > > > Can you help us with this, please? Does bgmac use NAPI incorrectly? > > Were there some important changes in 3.19 or 4.0? > > > > Right they were important changes in NAPI

Re: NAPI: Polling function requesting extra calls - difference between 3.18.11 and 4.0.0

2015-04-23 Thread Eric Dumazet
On Thu, 2015-04-23 at 20:18 +0200, Rafał Miłecki wrote: > > Can you help us with this, please? Does bgmac use NAPI incorrectly? > Were there some important changes in 3.19 or 4.0? > Right they were important changes in NAPI indeed : 3b47d30396ba net: gro: add a per device gro flush timer d75b1

NAPI: Polling function requesting extra calls - difference between 3.18.11 and 4.0.0

2015-04-23 Thread Rafał Miłecki
Hi, Recently Felix improved bgmac driver to be smarter in situation where new packets were Tx/Rx-ed during bgmac_poll execution. It was handled in: eb64e29 bgmac: leave interrupts disabled as long as there is work to do http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=eb64