Re: NAK: [PATCH 01/18] ipw2200: Fix NETDEV_TX_BUSY erroneous returned

2006-01-25 Thread jamal
On Wed, 2006-25-01 at 10:24 +0100, Stefan Rompf wrote: > Am Mittwoch 25 Januar 2006 07:55 schrieb James Ketrenos: > > > Jamal indicated we should just return NETDEV_TX_BUSY and the stack would > > take care of rescheduling... > > well so even Jamal can be wrong sometimes ;-) > I am never wron

Re: NAK: [PATCH 01/18] ipw2200: Fix NETDEV_TX_BUSY erroneous returned

2006-01-25 Thread Patrick McHardy
Stefan Rompf wrote: > Am Mittwoch 25 Januar 2006 07:55 schrieb James Ketrenos: > > >>The purpose for this code ever coming into existence within ieee80211 >>was based on discussions at OLS this past year in how to support for the >>ability to start/stop independent Tx queues within a single net d

Re: NAK: [PATCH 01/18] ipw2200: Fix NETDEV_TX_BUSY erroneous returned

2006-01-25 Thread Stefan Rompf
Am Mittwoch 25 Januar 2006 07:55 schrieb James Ketrenos: > The purpose for this code ever coming into existence within ieee80211 > was based on discussions at OLS this past year in how to support for the > ability to start/stop independent Tx queues within a single net device > in order to support

Re: NAK: [PATCH 01/18] ipw2200: Fix NETDEV_TX_BUSY erroneous returned

2006-01-25 Thread Stefan Rompf
Am Mittwoch 25 Januar 2006 07:18 schrieb Zhu Yi: > > This is what leads to the high ksoftirqd usage I reported October 2005 > > into the ipw bugzilla > > (http://www.bughost.org/bugzilla/show_bug.cgi?id=825). > > Sorry, I'm not aware of this bug since I'm not on the cc list. Hmm, frankly the ipw

Re: NAK: [PATCH 01/18] ipw2200: Fix NETDEV_TX_BUSY erroneous returned

2006-01-24 Thread James Ketrenos
Stefan Rompf wrote: >Am Dienstag 24 Januar 2006 09:36 schrieb Zhu Yi: > > >>Two problems in ipw2200: >>1. We now have the ieee_device->is_queue_full interface, and it will be >> called at the beginning of ieee80211_xmit function. So no need to call >> it at the driver xmit function. >> >

Re: NAK: [PATCH 01/18] ipw2200: Fix NETDEV_TX_BUSY erroneous returned

2006-01-24 Thread Zhu Yi
On Tue, 2006-01-24 at 23:09 +0100, Stefan Rompf wrote: > This interface is totally broken. Actually this happens in ipw2200 since > version 1.0.8: > > -dev->hard_start_xmit() calls ieee80211_xmit() > -ieee80211_xmit() calls into ieee->is_queue_full() which is > ipw_net_is_queue_full() for the ip

NAK: [PATCH 01/18] ipw2200: Fix NETDEV_TX_BUSY erroneous returned

2006-01-24 Thread Stefan Rompf
Am Dienstag 24 Januar 2006 09:36 schrieb Zhu Yi: > Two problems in ipw2200: > 1. We now have the ieee_device->is_queue_full interface, and it will be >called at the beginning of ieee80211_xmit function. So no need to call >it at the driver xmit function. This interface is totally broken.