Re: Large performance regression with 6in4 tunnel (sit)

2016-11-28 Thread Stephen Rothwell
Hi Alex, On Mon, 28 Nov 2016 13:32:21 -0800 Alexander Duyck wrote: > > So I think I have this root caused. The problem seems to be the fact > that I chose to use lco_csum when trying to cancel out the inner IP > header from the checksum and it turns out that the transport offset is > never upda

Re: Large performance regression with 6in4 tunnel (sit)

2016-11-28 Thread Alexander Duyck
On Sat, Nov 26, 2016 at 7:23 PM, Stephen Rothwell wrote: > Hi Sven-Haegar, > > On Fri, 25 Nov 2016 05:06:53 +0100 (CET) Sven-Haegar Koch > wrote: >> >> Somehow this problem description really reminds me of a report on >> netdev a bit ago, which the following patch fixed: >> >> commit 9ee6c5dc816

Re: Large performance regression with 6in4 tunnel (sit)

2016-11-28 Thread Lance Richardson
> From: "Lance Richardson" > To: "Stephen Rothwell" > Cc: "Sven-Haegar Koch" , "Eli Cooper" , > netdev@vger.kernel.org, "Eric Dumazet" > > Sent: Monday, November 28, 2016 12:54:07 PM > Subject: Re: Large performance re

Re: Large performance regression with 6in4 tunnel (sit)

2016-11-28 Thread Lance Richardson
> From: "Stephen Rothwell" > To: "Sven-Haegar Koch" > Cc: "Eli Cooper" , netdev@vger.kernel.org, "Eric Dumazet" > > Sent: Saturday, November 26, 2016 10:23:40 PM > Subject: Re: Large performance regression with 6in4 tunnel (sit) > &

Re: Large performance regression with 6in4 tunnel (sit)

2016-11-27 Thread Eli Cooper
Hi Stephen, On 2016/11/27 10:02, Stephen Rothwell wrote: > Hi Eli, > > On Sun, 27 Nov 2016 11:54:41 +1100 Stephen Rothwell > wrote: >> On Fri, 25 Nov 2016 14:05:04 +0800 Eli Cooper wrote: >>> I think this is similar to the bug I fixed in commit ae148b085876 >>> ("ip6_tunnel: Update skb->protoc

Re: Large performance regression with 6in4 tunnel (sit)

2016-11-26 Thread Stephen Rothwell
Hi Sven-Haegar, On Fri, 25 Nov 2016 05:06:53 +0100 (CET) Sven-Haegar Koch wrote: > > Somehow this problem description really reminds me of a report on > netdev a bit ago, which the following patch fixed: > > commit 9ee6c5dc816aa8256257f2cd4008a9291ec7e985 > Author: Lance Richardson > Date:

Re: Large performance regression with 6in4 tunnel (sit)

2016-11-26 Thread Stephen Rothwell
Hi Eli, On Sun, 27 Nov 2016 11:54:41 +1100 Stephen Rothwell wrote: > > On Fri, 25 Nov 2016 14:05:04 +0800 Eli Cooper wrote: > > > > I think this is similar to the bug I fixed in commit ae148b085876 > > ("ip6_tunnel: Update skb->protocol to ETH_P_IPV6 in ip6_tnl_xmit()"). > > > > I can reproduc

Re: Large performance regression with 6in4 tunnel (sit)

2016-11-26 Thread Stephen Rothwell
Hi Eli, On Fri, 25 Nov 2016 14:05:04 +0800 Eli Cooper wrote: > > I think this is similar to the bug I fixed in commit ae148b085876 > ("ip6_tunnel: Update skb->protocol to ETH_P_IPV6 in ip6_tnl_xmit()"). > > I can reproduce a similar problem by applying xfrm to sit traffic. > TSO/GSO packets are

Re: Large performance regression with 6in4 tunnel (sit)

2016-11-24 Thread Stephen Rothwell
Hi Eric, On Thu, 24 Nov 2016 19:54:04 -0800 Eric Dumazet wrote: > > Could you now report : > > ethtool -k eth0 Features for eth0: rx-checksumming: on tx-checksumming: on tx-checksum-ipv4: off [fixed] tx-checksum-ip-generic: on tx-checksum-ipv6: off [fixed] tx-c

Re: Large performance regression with 6in4 tunnel (sit)

2016-11-24 Thread Eli Cooper
Hi Stephen, On 2016/11/25 10:45, Stephen Rothwell wrote: > Hi Eli, > > On Fri, 25 Nov 2016 10:18:12 +0800 Eli Cooper wrote: >> Sounds like TSO/GSO packets are not properly segmented and therefore >> dropped. >> >> Could you first try turning off segmentation offloading for the tunnel >> interface

Re: Large performance regression with 6in4 tunnel (sit)

2016-11-24 Thread Sven-Haegar Koch
On Fri, 25 Nov 2016, Stephen Rothwell wrote: > On Fri, 25 Nov 2016 10:18:12 +0800 Eli Cooper wrote: > > > > Sounds like TSO/GSO packets are not properly segmented and therefore > > dropped. > > > > Could you first try turning off segmentation offloading for the tunnel > > interface? > > etht

Re: Large performance regression with 6in4 tunnel (sit)

2016-11-24 Thread Eric Dumazet
On Fri, 2016-11-25 at 14:09 +1100, Stephen Rothwell wrote: > Hi Eric, > > On Thu, 24 Nov 2016 19:01:28 -0800 Eric Dumazet > wrote: > > > > Since I do not have this problem at all on my hosts, it could be a buggy > > ethernet driver. > > > > Could you share what NIC card and driver you are using

Re: Large performance regression with 6in4 tunnel (sit)

2016-11-24 Thread Stephen Rothwell
Hi Eric, On Thu, 24 Nov 2016 19:01:28 -0800 Eric Dumazet wrote: > > Since I do not have this problem at all on my hosts, it could be a buggy > ethernet driver. > > Could you share what NIC card and driver you are using ? # uname -a Linux bilbo 4.7.0-1-amd64 #1 SMP Debian 4.7.8-1 (2016-10-19) x

Re: Large performance regression with 6in4 tunnel (sit)

2016-11-24 Thread Eric Dumazet
On Fri, 2016-11-25 at 13:45 +1100, Stephen Rothwell wrote: > So turning off tso brings performance up to IPv4 levels ... ok. > > Thanks for that, it solves my immediate problem. Since I do not have this problem at all on my hosts, it could be a buggy ethernet driver. Could you share what NIC

Re: Large performance regression with 6in4 tunnel (sit)

2016-11-24 Thread Stephen Rothwell
Hi Eli, On Fri, 25 Nov 2016 10:18:12 +0800 Eli Cooper wrote: > > Sounds like TSO/GSO packets are not properly segmented and therefore > dropped. > > Could you first try turning off segmentation offloading for the tunnel > interface? > ethtool -K sit0 tso off gso off On Thu, 24 Nov 2016 18:3

Re: Large performance regression with 6in4 tunnel (sit)

2016-11-24 Thread Eric Dumazet
On Fri, 2016-11-25 at 12:09 +1100, Stephen Rothwell wrote: > Hi all, > > This is a typical user error report i.e. a net well specified one :-) > > I am using a 6in4 tunnel from my Linux server at home (since my ISP > does not provide native IPv6) to another hosted Linus server (that has > native

Re: Large performance regression with 6in4 tunnel (sit)

2016-11-24 Thread Eli Cooper
Hi Stephen, On 2016/11/25 9:09, Stephen Rothwell wrote: > Hi all, > > This is a typical user error report i.e. a net well specified one :-) > > I am using a 6in4 tunnel from my Linux server at home (since my ISP > does not provide native IPv6) to another hosted Linus server (that has > native IPv6

Large performance regression with 6in4 tunnel (sit)

2016-11-24 Thread Stephen Rothwell
Hi all, This is a typical user error report i.e. a net well specified one :-) I am using a 6in4 tunnel from my Linux server at home (since my ISP does not provide native IPv6) to another hosted Linus server (that has native IPv6 connectivity). The throughput for IPv6 connections has dropped from