Re: IPv6: avoid dereference of null route entry in ipv6_del_addr()

2006-03-07 Thread Herbert Xu
Ingo Oeser <[EMAIL PROTECTED]> wrote: > > Would you mind queueing a patch nearly citing your first comment like this? There is no point in singling this out. We assume this all over the place. We even cast dst entries directly to IPv4/IPv6 route entries. Cheers, -- Visit Openswan at http://www

Re: IPv6: avoid dereference of null route entry in ipv6_del_addr()

2006-03-07 Thread Ingo Oeser
YOSHIFUJI Hideaki wrote: > In article <[EMAIL PROTECTED]> (at Tue, 7 Mar 2006 11:26:13 +0100), Ingo > Oeser <[EMAIL PROTECTED]> says: > > > What about sth. like this simple defensive patch instead > > (against Linux 2.6.16-rc4)? > > I disagree again. Sorry. Fine with me. If somebody changes

Re: IPv6: avoid dereference of null route entry in ipv6_del_addr()

2006-03-07 Thread David S. Miller
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Tue, 07 Mar 2006 19:45:42 +0900 (JST) > In article <[EMAIL PROTECTED]> (at Tue, 7 Mar 2006 11:26:13 +0100), Ingo > Oeser <[EMAIL PROTECTED]> says: > > > What about sth. like this simple defensive patch instead > > (against Linux 2.6.16-rc4)? >

Re: IPv6: avoid dereference of null route entry in ipv6_del_addr()

2006-03-07 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Tue, 7 Mar 2006 11:26:13 +0100), Ingo Oeser <[EMAIL PROTECTED]> says: > What about sth. like this simple defensive patch instead > (against Linux 2.6.16-rc4)? I disagree again. Sorry. --yoshfuji - To unsubscribe from this list: send the line "unsubscribe netd

Re: IPv6: avoid dereference of null route entry in ipv6_del_addr()

2006-03-07 Thread Ingo Oeser
Hi, YOSHIFUJI Hideaki wrote: > In article <[EMAIL PROTECTED]> (at Mon, 06 Mar 2006 21:50:33 +0100), > Jean-Mickael Guerin <[EMAIL PROTECTED]> says: > > This patch fixes potential null pointer dereference (I never experiment > > such crash). > > The patch is made for net-2.6.17. > > I disagree.

Re: IPv6: avoid dereference of null route entry in ipv6_del_addr()

2006-03-06 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Mon, 06 Mar 2006 21:50:33 +0100), Jean-Mickael Guerin <[EMAIL PROTECTED]> says: > Hi, > > This patch fixes potential null pointer dereference (I never experiment > such crash). > The patch is made for net-2.6.17. I disagree. It never happen, because (void *)

IPv6: avoid dereference of null route entry in ipv6_del_addr()

2006-03-06 Thread Jean-Mickael Guerin
Hi, This patch fixes potential null pointer dereference (I never experiment such crash). The patch is made for net-2.6.17. Regards, Jean-Mickael Signed-off-by: [EMAIL PROTECTED] -- diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 8df9eb9..8393f45 100644 --- a/net/ipv6/addrconf.c