Re: IPSec kernel oops on ppc64

2006-08-31 Thread Joy Latten
It works! I applied the patch to linux-2.6.17 + patch-2.6.17-rc1 and tried icmp, tcp and udp as well as sftp with ipsec and they all worked. Thanks Regards, Joy >Herbert Xu writes: > >> Interesting. We were previously off by 28 bytes, now we're off by 8 :) > >You missed a couple of 'beql

Re: IPSec kernel oops on ppc64

2006-08-30 Thread Paul Mackerras
Herbert Xu writes: > BTW, did you see the "cmpldi r1,..." stuff in the code? That's a typo, > right? Yes it is a typo, but fixing it is lower priority since both r1 and cr1 equal 1. Paul. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PRO

Re: IPSec kernel oops on ppc64

2006-08-30 Thread Herbert Xu
Hi Paul: On Thu, Aug 31, 2006 at 01:22:07PM +1000, Paul Mackerras wrote: > > You missed a couple of 'beqlr' instructions (branch if equal to LR). > I'd be interested to know if it still fails with the patch below. Yes that'd do it. BTW, did you see the "cmpldi r1,..." stuff in the code? That's

Re: IPSec kernel oops on ppc64

2006-08-30 Thread Paul Mackerras
Herbert Xu writes: > Interesting. We were previously off by 28 bytes, now we're off by 8 :) You missed a couple of 'beqlr' instructions (branch if equal to LR). I'd be interested to know if it still fails with the patch below. Thanks, Paul. diff --git a/arch/powerpc/lib/memcpy_64.S b/arch/powe

Re: IPSec kernel oops on ppc64

2006-08-30 Thread Herbert Xu
On Wed, Aug 30, 2006 at 11:36:26AM -0500, Joy Latten wrote: > > I tried the patch on the following: > linux-2.6.17 + patch-2.6.18-rc1 > > The good news is that the pings worked great! > So perhaps ESP is working ok with ICMP. > > But when I tried to do sftp, I still got the oops. > I don't think

Re: IPSec kernel oops on ppc64

2006-08-30 Thread Paul Mackerras
Joy Latten writes: > The good news is that the pings worked great! > So perhaps ESP is working ok with ICMP. > > But when I tried to do sftp, I still got the oops. > I don't think TCP and ESP are working. You're hitting the BUG_ON(len) at line 611 of net/xfrm/xfrm_algo.c. Is that the same thing

Re: IPSec kernel oops on ppc64

2006-08-30 Thread Joy Latten
>-- >diff --git a/arch/powerpc/lib/memcpy_64.S b/arch/powerpc/lib/memcpy_64.S >index fd66acf..9e8d9e7 100644 >--- a/arch/powerpc/lib/memcpy_64.S >+++ b/arch/powerpc/lib/memcpy_64.S >@@ -11,6 +11,7 @@ #include > > .align 7 > _GLOBAL(memcpy) >+ std r3,-8(r1) > mtcrf 0x01,r5

Re: IPSec kernel oops on ppc64

2006-08-30 Thread Herbert Xu
Hi: Thanks to some excellent info from Joy, I've trakced the problem down to a broken implementation of memmove on ppc64, which in turn is due to a broken memcpy. Both memmove and memcpy need to return the destination pointer as per the C standard. The ppc64 version of memcpy returns a pointer t

Re: IPSec kernel oops on ppc64

2006-08-29 Thread Joy Latten
>> I can try patch-2.6.18-rc1, etc... to see which one it stops >> working on to narrow it down. > >If you could do this in the meanwhile, it would help us out >a lot. > It stops working in patch-2.6.18-rc1. Regards, Joy - To unsubscribe from this list: send the line "unsubscribe netdev" in the b

Re: IPSec kernel oops on ppc64

2006-08-28 Thread Herbert Xu
On Mon, Aug 28, 2006 at 05:25:15PM -0500, Joy Latten wrote: > > A straight 2.6.17 kernel does not crash and my pings work. > A 2.6.17 + patch-2.6.18-rc4 does crash and my pings do not work. > The above tests were done on a ppc64. Thanks for that info. This does sound like a bug. Could you plea

Re: IPSec kernel oops on ppc64

2006-08-28 Thread David Miller
From: Joy Latten <[EMAIL PROTECTED]> Date: Mon, 28 Aug 2006 17:25:15 -0500 > I can try patch-2.6.18-rc1, etc... to see which one it stops > working on to narrow it down. If you could do this in the meanwhile, it would help us out a lot. Thanks. - To unsubscribe from this list: send the line "uns

Re: IPSec kernel oops on ppc64

2006-08-28 Thread Joy Latten
>Joy Latten <[EMAIL PROTECTED]> wrote: >> I installed 2.6.17 + patch-2.6.18-rc4 + 2.6.18-rc4-mm2 >> onto two pSeries power 5 (ppc64 lpars) machines. I configured >> IPSec using the configuration listed below. > >Could you try straight 2.6.17? If that crashes too, then at least we >can be sure that

Re: IPSec kernel oops on ppc64

2006-08-25 Thread Herbert Xu
Joy Latten <[EMAIL PROTECTED]> wrote: > I installed 2.6.17 + patch-2.6.18-rc4 + 2.6.18-rc4-mm2 > onto two pSeries power 5 (ppc64 lpars) machines. I configured > IPSec using the configuration listed below. Could you try straight 2.6.17? If that crashes too, then at least we can be sure that it isn

Re: IPSec kernel oops on ppc64

2006-08-25 Thread David Miller
From: James Morris <[EMAIL PROTECTED]> Date: Fri, 25 Aug 2006 19:15:57 -0400 (EDT) > On Fri, 25 Aug 2006, Joy Latten wrote: > > > I installed 2.6.17 + patch-2.6.18-rc4 + 2.6.18-rc4-mm2 > > onto two pSeries power 5 (ppc64 lpars) machines. I configured > > IPSec using the configuration listed below

Re: IPSec kernel oops on ppc64

2006-08-25 Thread James Morris
On Fri, 25 Aug 2006, Joy Latten wrote: > I installed 2.6.17 + patch-2.6.18-rc4 + 2.6.18-rc4-mm2 > onto two pSeries power 5 (ppc64 lpars) machines. I configured > IPSec using the configuration listed below. Confirming that this does not crash on i686 or x86_64. - james -- James Morris <[EMAIL

IPSec kernel oops on ppc64

2006-08-25 Thread Joy Latten
I installed 2.6.17 + patch-2.6.18-rc4 + 2.6.18-rc4-mm2 onto two pSeries power 5 (ppc64 lpars) machines. I configured IPSec using the configuration listed below. A ping from one machine to the other, hangs. No packets leave the machine issuing the ping. When I tried sftp, I received following oop