From: Igor Druzhinin
Date: Thu, 28 Feb 2019 12:48:03 +
> Zero-copy callback flag is not yet set on frag list skb at the moment
> xenvif_handle_frag_list() returns -ENOMEM. This eventually results in
> leaking grant ref mappings since xenvif_zerocopy_callback() is never
> call
On Thu, Feb 28, 2019 at 12:48:03PM +, Igor Druzhinin wrote:
> Zero-copy callback flag is not yet set on frag list skb at the moment
> xenvif_handle_frag_list() returns -ENOMEM. This eventually results in
> leaking grant ref mappings since xenvif_zerocopy_callback() is never
> call
Zero-copy callback flag is not yet set on frag list skb at the moment
xenvif_handle_frag_list() returns -ENOMEM. This eventually results in
leaking grant ref mappings since xenvif_zerocopy_callback() is never
called for these fragments. Those eventually build up and cause Xen
to kill Dom0 as the
On Thu, Feb 28, 2019 at 12:07:07PM +, Paul Durrant wrote:
> Yes, I meant kfree_skb(nskb).
>
In that case I think your patch looks fine.
Wei.
...@lists.xenproject.org;
> da...@davemloft.net
> Subject: Re: [Xen-devel] [PATCH] xen-netback: fix occasional leak of grant
> ref mappings under memory
> pressure
>
> > -Original Message-
> > From: Wei Liu [mailto:wei.l...@citrix.com]
> > Sent: 28 Februar
Subject: Re: [PATCH] xen-netback: fix occasional leak of grant ref mappings
> under memory pressure
>
> On 28/02/2019 11:21, Paul Durrant wrote:
> >>> @@ -1153,6 +1152,10 @@ static int xenvif_tx_submit(struct xenvif_queue
> >>> *q
On 28/02/2019 11:21, Paul Durrant wrote:
>>> @@ -1153,6 +1152,10 @@ static int xenvif_tx_submit(struct xenvif_queue
>>> *queue)
>>> kfree_skb(skb);
>>> continue;
>>> }
>>> +
>>> + /* Copie
t.net
> Subject: Re: [PATCH] xen-netback: fix occasional leak of grant ref mappings
> under memory pressure
>
> On Thu, Feb 28, 2019 at 09:46:57AM +, Paul Durrant wrote:
> > > -Original Message-
> > > From: Igor Druzhinin [mailto:igor.druzhi...@citrix
..@vger.kernel.org
> > Cc: Wei Liu ; Paul Durrant ;
> > da...@davemloft.net; Igor
> > Druzhinin
> > Subject: [PATCH] xen-netback: fix occasional leak of grant ref mappings
> > under memory pressure
> >
> > Zero-copy callback flag is not yet set on frag li
On 28/02/2019 02:03, Igor Druzhinin wrote:
> Zero-copy callback flag is not yet set on frag list skb at the moment
> xenvif_handle_frag_list() returns -ENOMEM. This eventually results in
> leaking grant ref mappings since xenvif_zerocopy_callback() is never
> called for these frag
gt; Druzhinin
> Subject: [PATCH] xen-netback: fix occasional leak of grant ref mappings under
> memory pressure
>
> Zero-copy callback flag is not yet set on frag list skb at the moment
> xenvif_handle_frag_list() returns -ENOMEM. This eventually results in
> leaking grant ref ma
Zero-copy callback flag is not yet set on frag list skb at the moment
xenvif_handle_frag_list() returns -ENOMEM. This eventually results in
leaking grant ref mappings since xenvif_zerocopy_callback() is never
called for these fragments. Those eventually build up and cause Xen
to kill Dom0 as the
I, Mikhail Fridman have selected you specifically as one of my beneficiaries
for my Charitable Donation of $5 Million Dollars,
Check the link below for confirmation:
https://www.rt.com/business/343781-mikhail-fridman-will-charity/
I await your earliest response for further directives.
Best Reg
--
I Mikhail Fridman. has selected you specially as one of my beneficiaries
for my Charitable Donation, Just as I have declared on May 23, 2016 to give
my fortune as charity.
Check the link below for confirmation:
http://www.ibtimes.co.uk/russias-second-wealthiest-man-mikhail-fridman-plans-l
I Mikhail Fridman. has selected you specially as one of my beneficiaries
for my Charitable Donation, Just as I have declared on May 23, 2016 to give
my fortune as charity.
Check the link below for confirmation:
http://www.ibtimes.co.uk/russias-second-wealthiest-man-mikhail-fridman-plans-leavin
I Mikhail Fridman. has selected you specially as one of my beneficiaries
for my Charitable Donation, Just as I have declared on May 23, 2016 to give
my fortune as charity.
Check the link below for confirmation:
http://www.ibtimes.co.uk/russias-second-wealthiest-man-mikhail-fridman-plans-leaving-1
() and free_page() on a compound page causes a reference
counting error which is detected when DEBUG_VM is enabled.
Signed-off-by: Ross Lagerwall
---
drivers/xen/grant-table.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant
My wife and I have awarded you with a donation of $ 1,000,000.00, respond with
your details for claims.
Best Regards,
Friedrich And Annand Mayrhofer.
My wife and I have awarded you with a donation of $ 1,000,000.00, respond with
your details for claims.
Best Regards,
Friedrich And Annand Mayrhofer.
--
Good Day,
My wife and I have awarded you with a donation of $ 1,000,000.00
Dollars from part of our Jackpot Lottery of 50 Million Dollars,
respond with your details for claims to our private email on:
fmayrhoferfam...@gmail.com .
We await your earliest response and God Bless you.
Fr
Good Day,
My wife and I have awarded you with a donation of $ 1,000,000.00 Dollars from
part of our Jackpot Lottery of 50 Million Dollars, respond with your details
for claims.
We await your earliest response and God Bless you.
Friedrich And Annand Mayrhofer.
---
This email has been checked f
--
Good Day,
My wife and I have awarded you with a donation of $ 1,000,000.00 Dollars from
part of our Jackpot Lottery of 50 Million Dollars, respond with your details
for claims.
We await your earliest response and God Bless you.
Friedrich And Annand Mayrhofer.
Good Day,
My wife and I have awarded you with a donation of $ 1,000,000.00 Dollars from
part of our Jackpot Lottery of 50 Million Dollars, respond with your details
for claims.
We await your earliest response and God Bless you.
Friedrich And Annand Mayrhofer.
---
This email has been checked f
You are a recipient to Mrs Julie Leach Donation of $3 million USD. Contact
(julieleac...@gmail.com ) for claims.
You are a recipient to Mrs Julie Leach Donation of $2 million USD. Contact
(julieleach...@gmail.com) for claims
From: Dongli Zhang
Date: Wed, 2 Nov 2016 09:04:33 +0800
> IS_ERR_VALUE() in commit 87557efc27f6a50140fb20df06a917f368ce3c66
> ("xen-netfront: do not cast grant table reference to signed short") would
> not return true for error code unless we cast ref first to type int.
IS_ERR_VALUE() in commit 87557efc27f6a50140fb20df06a917f368ce3c66
("xen-netfront: do not cast grant table reference to signed short") would
not return true for error code unless we cast ref first to type int.
Signed-off-by: Dongli Zhang
---
drivers/net/xen-netfront.c | 4 ++--
1 file
From: Dongli Zhang
Date: Mon, 31 Oct 2016 21:46:09 -0700 (PDT)
> David, I am very sorry for this error and I will be careful the next time.
> Would you please let me know if I should resend a new patch or an incremental
> based on previous one at
> https://git.kernel.org/cgit/linux/kernel/git/da
-de...@lists.xenproject.org,
netdev@vger.kernel.org, boris.ostrov...@oracle.com, david.vra...@citrix.com,
jgr...@suse.com
Sent: Tuesday, November 1, 2016 4:06:27 AM GMT +08:00 Beijing / Chongqing /
Hong Kong / Urumqi
Subject: Re: [PATCH 1/1] xen-netfront: do not cast grant table reference to
signed short
From: Don
From: Dongli Zhang
Date: Mon, 31 Oct 2016 13:38:29 +0800
> While grant reference is of type uint32_t, xen-netfront erroneously casts
> it to signed short in BUG_ON().
>
> This would lead to the xen domU panic during boot-up or migration when it
> is attached with lots of para
>>> On 31.10.16 at 09:28, wrote:
>> > ref = gnttab_claim_grant_reference(&queue->gref_rx_head);
>> > -BUG_ON((signed short)ref < 0);
>> > +WARN_ON_ONCE(IS_ERR_VALUE((unsigned long)ref));
>
>> You really need to cast to plain (or signed) long here -
ber 31, 2016 3:48:03 PM GMT +08:00 Beijing / Chongqing / Hong
Kong / Urumqi
Subject: Re: [Xen-devel] [PATCH 1/1] xen-netfront: do not cast grant table
reference to signed short
>>> On 31.10.16 at 06:38, wrote:
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.
>>> On 31.10.16 at 06:38, wrote:
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -304,7 +304,7 @@ static void xennet_alloc_rx_buffers(struct netfront_queue
> *queue)
> queue->rx_skbs[id] = skb;
>
> ref = gnttab_claim_grant_reference(&queue-
While grant reference is of type uint32_t, xen-netfront erroneously casts
it to signed short in BUG_ON().
This would lead to the xen domU panic during boot-up or migration when it
is attached with lots of paravirtual devices.
Signed-off-by: Dongli Zhang
---
drivers/net/xen-netfront.c | 4
--
You have a cash grant donation of $2,500.000.00 USD, I am Julie Leach;Won
$310.5 million Powerball jackpot winner. To verify the genuineness of this
email and my winnings, please you can read more about me by viewing the below
links:
http://www.powerball.com/powerball/winners/2015
From: Eran Ben Elisha
Each physical function has a guarantee of two counters per port, one
for a default counter and one for the IB driver.
Each virtual function has a guarantee of one counter per port.
All other counters are free and can be obtained on demand.
This is a preparation step for su
From: Eran Ben Elisha
Each physical function has a guarantee of two counters per port, one
for a default counter and one for the IB driver.
Each virtual function has a guarantee of one counter per port.
All other counters are free and can be obtained on demand.
This is a preparation step for su
On 29 May 2015, at 08:53, Yuzhou (C) wrote:
> Hi,
>
> About rx zerocopy, I have a question:
>
> If some application make a socket, then listen and accept, the client
> sends packets to it, but it doesn't recv from this socket right now, all
> persist
Hi,
About rx zerocopy, I have a question:
If some application make a socket, then listen and accept, the client
sends packets to it, but it doesn't recv from this socket right now, all
persistent grant page would be in used.
So other application cannot receive any packets
e persistent grants ops that could potentially live
outside.
Joao
>> [1] http://article.gmane.org/gmane.linux.network/249383
>> [2] http://bit.ly/1IhJfXD
>> [3] http://lists.xen.org/archives/html/xen-devel/2015-02/msg02292.html
>>
>> Joao Martins (13):
>
Valerie Henson wrote:
With Grant's help I was able to get the tulip driver to work with 64 bit
MIPS.
[VAL: I'm happy with the 1.5 ms max delay; it doesn't seem excessive.]
Signed-off-by: Valerie Henson <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Cc: Jeff Garzik <[EMAIL
With Grant's help I was able to get the tulip driver to work with 64 bit
MIPS.
[VAL: I'm happy with the 1.5 ms max delay; it doesn't seem excessive.]
Signed-off-by: Valerie Henson <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Cc: Jeff Garzik <[EMAIL PROTECTED]>
---
drive
42 matches
Mail list logo
