Re: FW: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode

2007-11-16 Thread Patrick McHardy
Herbert Xu wrote: BTW, how does the VLAN TX acceleration work at all? It's using skb->cb to carry the tags but then calls dev_queue_xmit. Once you do that packet schedulers can scribble all over skb->cb. Also vlan_skb_recv should be moved out-of-line. It's absolutely humongous. It'll generate

Re: FW: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode

2007-11-16 Thread Herbert Xu
On Fri, Nov 16, 2007 at 08:49:02PM +0900, Joonwoo Park wrote: > > Not anymore about just e1000 :) > I made an another patch with different approach which doesn't fix nic driver. > In addition, this patch does disable all hw vlan acceleration features (rx, > tx, filter) for promiscuous netdevice.

FW: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode

2007-11-16 Thread Joonwoo Park
2007/11/11, Joonwoo Park <[EMAIL PROTECTED]>: > IMHO even though netdevice is in the promiscuous mode, we should receive all > of ingress packets. > This disable the vlan filtering feature when a vlan hw accel configured e1000 > device goes into promiscuous mode. > This make packets visible to sn