Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-12 Thread Jiri Olsa
On Fri, Feb 12, 2021 at 11:22:41AM -0800, Andrii Nakryiko wrote: SNIP > > +static int is_ftrace_func(struct elf_function *func, __u64 *addrs, > > + __u64 count, bool kmod) > > +{ > > + /* > > +* For vmlinux image both addrs[x] and functions[x]::addr > > +

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-12 Thread Andrii Nakryiko
On Fri, Feb 12, 2021 at 8:39 AM Jiri Olsa wrote: > > On Thu, Feb 11, 2021 at 11:59:02AM -0800, Andrii Nakryiko wrote: > > SNIP > > > > > So in my previous example I assumed we have address ranges for ftrace > > section, which is exactly the opposite from what we have. So this > > binary search sho

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-12 Thread Jiri Olsa
On Thu, Feb 11, 2021 at 11:59:02AM -0800, Andrii Nakryiko wrote: SNIP > > So in my previous example I assumed we have address ranges for ftrace > section, which is exactly the opposite from what we have. So this > binary search should be a bit different. start <= addr seems wrong > here as well.

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-11 Thread Jiri Olsa
On Thu, Feb 11, 2021 at 11:59:02AM -0800, Andrii Nakryiko wrote: SNIP > > return strcmp(a->name, b->name); > > } > > > > +static int functions_cmp_addr(const void *_a, const void *_b) > > +{ > > + const struct elf_function *a = _a; > > + const struct elf_function *b = _b; > >

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-11 Thread Andrii Nakryiko
On Thu, Feb 11, 2021 at 7:08 AM Jiri Olsa wrote: > > On Wed, Feb 10, 2021 at 09:13:47PM +0100, Jiri Olsa wrote: > > On Wed, Feb 10, 2021 at 10:20:20AM -0800, Andrii Nakryiko wrote: > > > > SNIP > > > > > > but below is change for checking that ftrace addrs are within elf > > > > functions > > > >

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-11 Thread Nathan Chancellor
On Thu, Feb 11, 2021 at 04:08:11PM +0100, Jiri Olsa wrote: > On Wed, Feb 10, 2021 at 09:13:47PM +0100, Jiri Olsa wrote: > > On Wed, Feb 10, 2021 at 10:20:20AM -0800, Andrii Nakryiko wrote: > > > > SNIP > > > > > > but below is change for checking that ftrace addrs are within elf > > > > function

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-11 Thread Sedat Dilek
On Thu, Feb 11, 2021 at 5:07 PM Jiri Olsa wrote: > > On Thu, Feb 11, 2021 at 04:43:48PM +0100, Sedat Dilek wrote: > > SNIP > > > > > filled with elf functions start/end values, right? > > > > > > > > > /* > > > > > * We iterate over sorted array, so

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-11 Thread Jiri Olsa
On Thu, Feb 11, 2021 at 04:43:48PM +0100, Sedat Dilek wrote: SNIP > > > filled with elf functions start/end values, right? > > > > > > > /* > > > > * We iterate over sorted array, so we can > > > > easily skip > > > > * no

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-11 Thread Sedat Dilek
On Thu, Feb 11, 2021 at 4:08 PM Jiri Olsa wrote: > > On Wed, Feb 10, 2021 at 09:13:47PM +0100, Jiri Olsa wrote: > > On Wed, Feb 10, 2021 at 10:20:20AM -0800, Andrii Nakryiko wrote: > > > > SNIP > > > > > > but below is change for checking that ftrace addrs are within elf > > > > functions > > > >

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-11 Thread Jiri Olsa
On Wed, Feb 10, 2021 at 09:13:47PM +0100, Jiri Olsa wrote: > On Wed, Feb 10, 2021 at 10:20:20AM -0800, Andrii Nakryiko wrote: > > SNIP > > > > but below is change for checking that ftrace addrs are within elf > > > functions > > > > > > seems to work in my tests, I'll run some more tests and sen

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-10 Thread Jiri Olsa
On Wed, Feb 10, 2021 at 10:20:20AM -0800, Andrii Nakryiko wrote: SNIP > > but below is change for checking that ftrace addrs are within elf functions > > > > seems to work in my tests, I'll run some more tests and send full patch > > It seems unnecessarily convoluted. I was thinking about someth

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-10 Thread Andrii Nakryiko
On Wed, Feb 10, 2021 at 11:11 AM Jiri Olsa wrote: > > On Wed, Feb 10, 2021 at 10:20:20AM -0800, Andrii Nakryiko wrote: > > On Wed, Feb 10, 2021 at 5:26 AM Jiri Olsa wrote: > > > > > > On Tue, Feb 09, 2021 at 02:00:29PM -0800, Andrii Nakryiko wrote: > > > > > > SNIP > > > > > > > > > > I'm still t

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-10 Thread Jiri Olsa
On Wed, Feb 10, 2021 at 10:20:20AM -0800, Andrii Nakryiko wrote: > On Wed, Feb 10, 2021 at 5:26 AM Jiri Olsa wrote: > > > > On Tue, Feb 09, 2021 at 02:00:29PM -0800, Andrii Nakryiko wrote: > > > > SNIP > > > > > > > > I'm still trying to build the kernel.. however ;-) > > > > > > > > > > > > patch

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-10 Thread Sedat Dilek
On Wed, Feb 10, 2021 at 7:20 PM Andrii Nakryiko wrote: > > On Wed, Feb 10, 2021 at 5:26 AM Jiri Olsa wrote: > > > > On Tue, Feb 09, 2021 at 02:00:29PM -0800, Andrii Nakryiko wrote: > > > > SNIP > > > > > > > > I'm still trying to build the kernel.. however ;-) > > > > > > > > > > > > patch below

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-10 Thread Andrii Nakryiko
On Wed, Feb 10, 2021 at 5:26 AM Jiri Olsa wrote: > > On Tue, Feb 09, 2021 at 02:00:29PM -0800, Andrii Nakryiko wrote: > > SNIP > > > > > > I'm still trying to build the kernel.. however ;-) > > > > > > > > > > patch below adds the ftrace check only for static functions > > > > > and lets the exter

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-10 Thread Nathan Chancellor
On Wed, Feb 10, 2021 at 02:26:43PM +0100, Jiri Olsa wrote: > On Tue, Feb 09, 2021 at 02:00:29PM -0800, Andrii Nakryiko wrote: > > SNIP > > > > > > I'm still trying to build the kernel.. however ;-) > > > > > > > > > > patch below adds the ftrace check only for static functions > > > > > and lets

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-10 Thread Jiri Olsa
On Tue, Feb 09, 2021 at 02:00:29PM -0800, Andrii Nakryiko wrote: SNIP > > > > I'm still trying to build the kernel.. however ;-) > > > > > > > > patch below adds the ftrace check only for static functions > > > > and lets the externa go through.. but as you said, in this > > > > case we'll need t

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-10 Thread Jiri Olsa
On Wed, Feb 10, 2021 at 11:34:25AM +, David Laight wrote: > > > > vfs_truncate disasm: > > > > > > > > 80001031f430 : > > > > 80001031f430: 5f 24 03 d5 hint#34 > > > > 80001031f434: 1f 20 03 d5 nop > > > > 80001031f438: 1f 20 03 d5 nop >

RE: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-10 Thread David Laight
> > > vfs_truncate disasm: > > > > > > 80001031f430 : > > > 80001031f430: 5f 24 03 d5 hint#34 > > > 80001031f434: 1f 20 03 d5 nop > > > 80001031f438: 1f 20 03 d5 nop > > > 80001031f43c: 3f 23 03 d5 hint#25 > > > > > > thats

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-09 Thread Daniel Kiss
> On 10 Feb 2021, at 01:02, Nathan Chancellor wrote: > > On Tue, Feb 09, 2021 at 12:09:31PM -0800, Nick Desaulniers wrote: >> On Tue, Feb 9, 2021 at 11:06 AM Jiri Olsa wrote: >>> >>> On Tue, Feb 09, 2021 at 05:13:42PM +0100, Jiri Olsa wrote: On Tue, Feb 09, 2021 at 04:09:36PM +0100, Jiri O

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-09 Thread Nathan Chancellor
On Tue, Feb 09, 2021 at 12:09:31PM -0800, Nick Desaulniers wrote: > On Tue, Feb 9, 2021 at 11:06 AM Jiri Olsa wrote: > > > > On Tue, Feb 09, 2021 at 05:13:42PM +0100, Jiri Olsa wrote: > > > On Tue, Feb 09, 2021 at 04:09:36PM +0100, Jiri Olsa wrote: > > > > > > SNIP > > > > > > > > > > >

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-09 Thread Nathan Chancellor
On Tue, Feb 09, 2021 at 10:41:44PM +0100, Jiri Olsa wrote: > On Tue, Feb 09, 2021 at 09:50:48PM +0100, Jiri Olsa wrote: > > On Tue, Feb 09, 2021 at 12:09:31PM -0800, Nick Desaulniers wrote: > > > On Tue, Feb 9, 2021 at 11:06 AM Jiri Olsa wrote: > > > > > > > > On Tue, Feb 09, 2021 at 05:13:42PM +0

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-09 Thread Andrii Nakryiko
On Tue, Feb 9, 2021 at 1:55 PM Jiri Olsa wrote: > > On Tue, Feb 09, 2021 at 12:59:51PM -0800, Andrii Nakryiko wrote: > > On Tue, Feb 9, 2021 at 7:09 AM Jiri Olsa wrote: > > > > > > On Tue, Feb 09, 2021 at 01:36:41PM +0100, Jiri Olsa wrote: > > > > On Tue, Feb 09, 2021 at 12:49:04AM -0700, Nathan

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-09 Thread Jiri Olsa
On Tue, Feb 09, 2021 at 09:50:48PM +0100, Jiri Olsa wrote: > On Tue, Feb 09, 2021 at 12:09:31PM -0800, Nick Desaulniers wrote: > > On Tue, Feb 9, 2021 at 11:06 AM Jiri Olsa wrote: > > > > > > On Tue, Feb 09, 2021 at 05:13:42PM +0100, Jiri Olsa wrote: > > > > On Tue, Feb 09, 2021 at 04:09:36PM +010

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-09 Thread Jiri Olsa
On Tue, Feb 09, 2021 at 12:59:51PM -0800, Andrii Nakryiko wrote: > On Tue, Feb 9, 2021 at 7:09 AM Jiri Olsa wrote: > > > > On Tue, Feb 09, 2021 at 01:36:41PM +0100, Jiri Olsa wrote: > > > On Tue, Feb 09, 2021 at 12:49:04AM -0700, Nathan Chancellor wrote: > > > > On Mon, Feb 08, 2021 at 10:56:36PM

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-09 Thread Andrii Nakryiko
On Tue, Feb 9, 2021 at 7:09 AM Jiri Olsa wrote: > > On Tue, Feb 09, 2021 at 01:36:41PM +0100, Jiri Olsa wrote: > > On Tue, Feb 09, 2021 at 12:49:04AM -0700, Nathan Chancellor wrote: > > > On Mon, Feb 08, 2021 at 10:56:36PM -0800, Andrii Nakryiko wrote: > > > > On Mon, Feb 8, 2021 at 10:13 PM Andri

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-09 Thread Jiri Olsa
On Tue, Feb 09, 2021 at 12:09:31PM -0800, Nick Desaulniers wrote: > On Tue, Feb 9, 2021 at 11:06 AM Jiri Olsa wrote: > > > > On Tue, Feb 09, 2021 at 05:13:42PM +0100, Jiri Olsa wrote: > > > On Tue, Feb 09, 2021 at 04:09:36PM +0100, Jiri Olsa wrote: > > > > > > SNIP > > > > > > > > > > >

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-09 Thread Jiri Olsa
adding Arnaldo to the loop jirka On Tue, Feb 09, 2021 at 08:06:16PM +0100, Jiri Olsa wrote: > On Tue, Feb 09, 2021 at 05:13:42PM +0100, Jiri Olsa wrote: > > On Tue, Feb 09, 2021 at 04:09:36PM +0100, Jiri Olsa wrote: > > > > SNIP > > > > > > > > > DW_AT_prototyped(true) >

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-09 Thread Jiri Olsa
On Tue, Feb 09, 2021 at 05:13:42PM +0100, Jiri Olsa wrote: > On Tue, Feb 09, 2021 at 04:09:36PM +0100, Jiri Olsa wrote: > > SNIP > > > > > > > DW_AT_prototyped(true) > > > > > > DW_AT_type (0x01cfdfe4 "long int") > > > > > > DW_AT_exter

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-09 Thread Sedat Dilek
On Tue, Feb 9, 2021 at 6:12 PM Nick Desaulniers wrote: > > On Tue, Feb 9, 2021 at 9:07 AM Sedat Dilek wrote: > > > > We should ask linux-kbuild/Masahiro to have an option to OVERRIDE: > > When scripts/link-vmlinux.sh fails all generated files like vmlinux get > > removed. > > For further debuggi

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-09 Thread Sedat Dilek
On Tue, Feb 9, 2021 at 5:35 PM Nathan Chancellor wrote: > > On Tue, Feb 09, 2021 at 05:13:38PM +0100, Jiri Olsa wrote: > > On Tue, Feb 09, 2021 at 04:09:36PM +0100, Jiri Olsa wrote: > > > > SNIP > > > > > > > > > DW_AT_prototyped(true) > > > > > > > DW_AT_ty

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-09 Thread Nathan Chancellor
On Tue, Feb 09, 2021 at 05:13:38PM +0100, Jiri Olsa wrote: > On Tue, Feb 09, 2021 at 04:09:36PM +0100, Jiri Olsa wrote: > > SNIP > > > > > > > DW_AT_prototyped(true) > > > > > > DW_AT_type (0x01cfdfe4 "long int") > > > > > > DW_AT_exter

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-09 Thread Jiri Olsa
On Tue, Feb 09, 2021 at 04:09:36PM +0100, Jiri Olsa wrote: SNIP > > > > > DW_AT_prototyped(true) > > > > > DW_AT_type (0x01cfdfe4 "long int") > > > > > DW_AT_external (true) > > > > > > > > > > > > > Ok, the problem appears to be not

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-09 Thread Jiri Olsa
On Tue, Feb 09, 2021 at 01:36:41PM +0100, Jiri Olsa wrote: > On Tue, Feb 09, 2021 at 12:49:04AM -0700, Nathan Chancellor wrote: > > On Mon, Feb 08, 2021 at 10:56:36PM -0800, Andrii Nakryiko wrote: > > > On Mon, Feb 8, 2021 at 10:13 PM Andrii Nakryiko > > > wrote: > > > > > > > > On Mon, Feb 8, 202

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-09 Thread Jiri Olsa
On Tue, Feb 09, 2021 at 12:49:04AM -0700, Nathan Chancellor wrote: > On Mon, Feb 08, 2021 at 10:56:36PM -0800, Andrii Nakryiko wrote: > > On Mon, Feb 8, 2021 at 10:13 PM Andrii Nakryiko > > wrote: > > > > > > On Mon, Feb 8, 2021 at 10:09 PM Andrii Nakryiko > > > wrote: > > > > > > > > On Mon, Feb

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-08 Thread Nathan Chancellor
On Mon, Feb 08, 2021 at 10:56:36PM -0800, Andrii Nakryiko wrote: > On Mon, Feb 8, 2021 at 10:13 PM Andrii Nakryiko > wrote: > > > > On Mon, Feb 8, 2021 at 10:09 PM Andrii Nakryiko > > wrote: > > > > > > On Mon, Feb 8, 2021 at 9:23 PM Nathan Chancellor > > > wrote: > > > > > > > > On Mon, Feb 08

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-08 Thread Andrii Nakryiko
On Mon, Feb 8, 2021 at 10:13 PM Andrii Nakryiko wrote: > > On Mon, Feb 8, 2021 at 10:09 PM Andrii Nakryiko > wrote: > > > > On Mon, Feb 8, 2021 at 9:23 PM Nathan Chancellor wrote: > > > > > > On Mon, Feb 08, 2021 at 08:45:43PM -0800, Andrii Nakryiko wrote: > > > > On Mon, Feb 8, 2021 at 7:44 PM

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-08 Thread Andrii Nakryiko
On Mon, Feb 8, 2021 at 10:09 PM Andrii Nakryiko wrote: > > On Mon, Feb 8, 2021 at 9:23 PM Nathan Chancellor wrote: > > > > On Mon, Feb 08, 2021 at 08:45:43PM -0800, Andrii Nakryiko wrote: > > > On Mon, Feb 8, 2021 at 7:44 PM Nathan Chancellor > > > wrote: > > > > > > > > Hi all, > > > > > > > >

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-08 Thread Andrii Nakryiko
On Mon, Feb 8, 2021 at 9:23 PM Nathan Chancellor wrote: > > On Mon, Feb 08, 2021 at 08:45:43PM -0800, Andrii Nakryiko wrote: > > On Mon, Feb 8, 2021 at 7:44 PM Nathan Chancellor wrote: > > > > > > Hi all, > > > > > > Recently, an issue with CONFIG_DEBUG_INFO_BTF was reported for arm64: > > > http

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-08 Thread Nathan Chancellor
On Mon, Feb 08, 2021 at 08:45:43PM -0800, Andrii Nakryiko wrote: > On Mon, Feb 8, 2021 at 7:44 PM Nathan Chancellor wrote: > > > > Hi all, > > > > Recently, an issue with CONFIG_DEBUG_INFO_BTF was reported for arm64: > > https://groups.google.com/g/clang-built-linux/c/de_mNh23FOc/m/E7cu5BwbBAAJ >

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-08 Thread Andrii Nakryiko
On Mon, Feb 8, 2021 at 7:44 PM Nathan Chancellor wrote: > > Hi all, > > Recently, an issue with CONFIG_DEBUG_INFO_BTF was reported for arm64: > https://groups.google.com/g/clang-built-linux/c/de_mNh23FOc/m/E7cu5BwbBAAJ > > $ make -skj"$(nproc)" ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- \ >

FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-08 Thread Nathan Chancellor
Hi all, Recently, an issue with CONFIG_DEBUG_INFO_BTF was reported for arm64: https://groups.google.com/g/clang-built-linux/c/de_mNh23FOc/m/E7cu5BwbBAAJ $ make -skj"$(nproc)" ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- \ LLVM=1 O=build/aarch64 defconfig $ scripts/config \