Re: Excess use of packed attribute

2006-08-09 Thread David Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Wed, 09 Aug 2006 11:37:31 -0700 > Agreed (although not really RISC -- sparc64 and ia64 have this > problem, while ppc is fine with unaligned access). However > __attribute__((packed,aligned)) has just been brought to my attention. > For example, on sp

Re: Excess use of packed attribute

2006-08-09 Thread Ville Nuorvala
David Miller wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Mon, 7 Aug 2006 13:34:23 -0700 > >> Silly offenders: include/net/ipx.h >> include/net/ieee80211.h >> include/net/ip6_tunnel.h >> include/net/ndisc.h >>

Re: Excess use of packed attribute

2006-08-09 Thread Roland Dreier
David> For the cases where it is no actually necessary, the code David> generation cost on RISC cpus is very high. Byte loads and David> stores will be used to access _every_ member of such David> structures on RISC machines because the compiler cannot David> guarentee the alig

Re: Excess use of packed attribute

2006-08-07 Thread David Miller
From: Sridhar Samudrala <[EMAIL PROTECTED]> Date: Mon, 07 Aug 2006 17:02:08 -0700 > All the structures in sctp.h that use packed atrribute define > standard on-wire SCTP chunk/parameter formats. They need to be at the > exact offsets as they go on wire. > I think we saw some issues without the pac

Re: Excess use of packed attribute

2006-08-07 Thread Sridhar Samudrala
On Mon, 2006-08-07 at 13:34 -0700, Stephen Hemminger wrote: > After reading: > http://bugzilla.kernel.org/show_bug.cgi?id=6693 > > I noticed there were stupid uses of packed attribute in several network > headers. > > Silly offenders: include/net/ipx.h > include/

Re: Excess use of packed attribute

2006-08-07 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 7 Aug 2006 13:34:23 -0700 > Silly offenders: include/net/ipx.h > include/net/ieee80211.h > include/net/ip6_tunnel.h > include/net/ndisc.h > include/li

Excess use of packed attribute

2006-08-07 Thread Stephen Hemminger
After reading: http://bugzilla.kernel.org/show_bug.cgi?id=6693 I noticed there were stupid uses of packed attribute in several network headers. Silly offenders:include/net/ipx.h include/net/ieee80211.h include/net/ip6_tunnel.h