Re: mv88e6xxx -- DSA support for Marvell 88e6065 switch (and maybe 88e6060?)

2019-01-29 Thread Vivien Didelot
Hi Pavel, On Tue, 29 Jan 2019 23:57:32 +0100, Pavel Machek wrote: > Ok, so I took a long look at mv88e6xxx... and got it to work. > > Good news is that modifications needed are not too heavy. Most are > inlined below. (tag_daddr is still needed. I can send that too). > > Bad news is that onl

Re: mv88e6xxx -- DSA support for Marvell 88e6065 switch (and maybe 88e6060?)

2019-01-29 Thread Andrew Lunn
> Is someone is interested in getting 6060 to work with mv88e6xxx? Vivien is. I also have a set of patches which modernize the driver. That might be a step towards merging it in. > @@ -2126,6 +2146,7 @@ static int mv88e6xxx_setup_egress_floods(struct > mv88e6xxx_chip *chip, int port) > >

mv88e6xxx -- DSA support for Marvell 88e6065 switch (and maybe 88e6060?)

2019-01-29 Thread Pavel Machek
Hi! > > > > I'm trying to create support for Marvell 88e6065 switch... and it > > > > seems like drivers/net/dsa supports everything, but this model. > > > > > > > > Did someone work with this hardware before? Any idea if it would be > > > > more suitable to support by existing 88e6060 code, or i

Re: DSA support for Marvell 88e6065 switch

2018-12-06 Thread Pavel Machek
Hi! > >>> 6065 indeed has some kind of "egress tagging mode" (with four > >>> options), but I have trouble understanding what it really does. > >> > >> What are the options? > > > > "transmit unmodified", "transmit untagged", "transmit tagged" and > > "transmit all frames double tagged". > > It

Re: DSA support for Marvell 88e6065 switch

2018-12-05 Thread Florian Fainelli
On 12/5/18 12:46 PM, Pavel Machek wrote: > Hi! > > But I'm running into problems with tagging code, and I guess I'd like > some help understanding. > > tag_trailer: allocates new skb, then copies data around. > > tag_qca: does dev->stats.tx_packets++, and reuses existing sk

Re: DSA support for Marvell 88e6065 switch

2018-12-05 Thread Pavel Machek
Hi! > > > > But I'm running into problems with tagging code, and I guess I'd like > > > > some help understanding. > > > > > > > > tag_trailer: allocates new skb, then copies data around. > > > > > > > > tag_qca: does dev->stats.tx_packets++, and reuses existing skb. > > > > > > > > tag_brcm: r

Re: DSA support for Marvell 88e6065 switch

2018-12-02 Thread Lennert Buytenhek
On Thu, Nov 22, 2018 at 09:27:24PM +0100, Pavel Machek wrote: > Hi! Hello! > > > > > If I wanted it to work, what do I need to do? AFAICT phy autoprobing > > > > > should just attach it as soon as it is compiled in? > > > > > > > > Nope. It is a switch, not a PHY. Switches are never auto-probe

Re: DSA support for Marvell 88e6065 switch

2018-11-22 Thread Pavel Machek
Hi! > > > > If I wanted it to work, what do I need to do? AFAICT phy autoprobing > > > > should just attach it as soon as it is compiled in? > > > > > > Nope. It is a switch, not a PHY. Switches are never auto-probed > > > because they are not guaranteed to have ID registers. > > > > > > You nee

Re: DSA support for Marvell 88e6065 switch

2018-11-22 Thread Lennert Buytenhek
On Thu, Nov 22, 2018 at 02:21:23PM +0100, Pavel Machek wrote: > > > If I wanted it to work, what do I need to do? AFAICT phy autoprobing > > > should just attach it as soon as it is compiled in? > > > > Nope. It is a switch, not a PHY. Switches are never auto-probed > > because they are not guara

Re: DSA support for Marvell 88e6065 switch

2018-11-22 Thread Pavel Machek
On Mon 2018-11-19 04:25:35, Andrew Lunn wrote: > > If I wanted it to work, what do I need to do? AFAICT phy autoprobing > > should just attach it as soon as it is compiled in? > > Nope. It is a switch, not a PHY. Switches are never auto-probed > because they are not guaranteed to have ID registers

Re: DSA support for Marvell 88e6065 switch

2018-11-18 Thread Andrew Lunn
> If I wanted it to work, what do I need to do? AFAICT phy autoprobing > should just attach it as soon as it is compiled in? Nope. It is a switch, not a PHY. Switches are never auto-probed because they are not guaranteed to have ID registers. You need to use the legacy device tree binding. Look i

Re: DSA support for Marvell 88e6065 switch

2018-11-18 Thread Pavel Machek
HI! > > > > I'm trying to create support for Marvell 88e6065 switch... and it > > > > seems like drivers/net/dsa supports everything, but this model. > > > > > > > > Did someone work with this hardware before? Any idea if it would be > > > > more suitable to support by existing 88e6060 code, or i

Re: DSA support for Marvell 88e6065 switch

2018-11-18 Thread Andrew Lunn
On Sun, Nov 18, 2018 at 07:07:12PM +0100, Pavel Machek wrote: > On Thu 2018-11-15 21:26:18, Andrew Lunn wrote: > > On Thu, Nov 15, 2018 at 08:51:11PM +0100, Pavel Machek wrote: > > > Hi! > > > > > > I'm trying to create support for Marvell 88e6065 switch... and it > > > seems like drivers/net/dsa

Re: DSA support for Marvell 88e6065 switch

2018-11-18 Thread Pavel Machek
On Thu 2018-11-15 21:26:18, Andrew Lunn wrote: > On Thu, Nov 15, 2018 at 08:51:11PM +0100, Pavel Machek wrote: > > Hi! > > > > I'm trying to create support for Marvell 88e6065 switch... and it > > seems like drivers/net/dsa supports everything, but this model. > > > > Did someone work with this h

Re: DSA support for Marvell 88e6065 switch

2018-11-15 Thread Andrew Lunn
On Thu, Nov 15, 2018 at 08:51:11PM +0100, Pavel Machek wrote: > Hi! > > I'm trying to create support for Marvell 88e6065 switch... and it > seems like drivers/net/dsa supports everything, but this model. > > Did someone work with this hardware before? Any idea if it would be > more suitable to su

DSA support for Marvell 88e6065 switch

2018-11-15 Thread Pavel Machek
Hi! I'm trying to create support for Marvell 88e6065 switch... and it seems like drivers/net/dsa supports everything, but this model. Did someone work with this hardware before? Any idea if it would be more suitable to support by existing 88e6060 code, or if 88e6xxx code should serve as a base?