Re: Clang warning in drivers/net/ethernet/intel/igc/igc_ethtool.c

2019-03-01 Thread Michal Kubecek
On Fri, Mar 01, 2019 at 10:28:35AM -0800, Nick Desaulniers wrote: > On Fri, Feb 8, 2019 at 6:34 AM Michal Kubecek wrote: > > > > On Thu, Feb 07, 2019 at 10:09:21PM -0700, Nathan Chancellor wrote: > > > Hi all, > > > > > > After commit 8c5ad0dae93c ("igc: Add ethtool support"), Clang warns: > > > >

Re: Clang warning in drivers/net/ethernet/intel/igc/igc_ethtool.c

2019-03-01 Thread Nick Desaulniers
On Fri, Feb 8, 2019 at 6:34 AM Michal Kubecek wrote: > > On Thu, Feb 07, 2019 at 10:09:21PM -0700, Nathan Chancellor wrote: > > Hi all, > > > > After commit 8c5ad0dae93c ("igc: Add ethtool support"), Clang warns: > > > > drivers/net/ethernet/intel/igc/igc_ethtool.c:9:19: warning: variable > > 'ig

Re: Clang warning in drivers/net/ethernet/intel/igc/igc_ethtool.c

2019-02-08 Thread Michal Kubecek
On Thu, Feb 07, 2019 at 10:09:21PM -0700, Nathan Chancellor wrote: > Hi all, > > After commit 8c5ad0dae93c ("igc: Add ethtool support"), Clang warns: > > drivers/net/ethernet/intel/igc/igc_ethtool.c:9:19: warning: variable > 'igc_priv_flags_strings' is not needed and will not be emitted > [-Wun

Clang warning in drivers/net/ethernet/intel/igc/igc_ethtool.c

2019-02-07 Thread Nathan Chancellor
Hi all, After commit 8c5ad0dae93c ("igc: Add ethtool support"), Clang warns: drivers/net/ethernet/intel/igc/igc_ethtool.c:9:19: warning: variable 'igc_priv_flags_strings' is not needed and will not be emitted [-Wunneeded-internal-declaration] static const char igc_priv_flags_strings[][ETH_GSTRI