Re: Bug report (with fix) for DEC Tulip driver (de2104x.c)

2019-09-20 Thread Thomas Bogendoerfer
On Mon, Sep 16, 2019 at 02:50:53PM -0700, Arlie Davis wrote: > See section 4.2.2 for the specs on the transfer descriptor. > > Here's my patch that fixes it: > > diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c > b/drivers/net/ethernet/dec/tulip/de2104x.c > index f1a2da15dd0a..3a420ceb52

Re: Bug report (with fix) for DEC Tulip driver (de2104x.c)

2019-09-19 Thread Sven Schnelle
Hi, On Wed, Sep 18, 2019 at 07:56:16AM +0200, Helge Deller wrote: > On 18.09.19 00:51, John David Anglin wrote: > > On 2019-09-17 5:36 p.m., Arlie Davis wrote: > >> Likewise, I'm at a loss for testing with real hardware. It's hard to > >> find such things, now. > > How does de2104x compare to ds21

Re: Bug report (with fix) for DEC Tulip driver (de2104x.c)

2019-09-18 Thread Thomas Bogendoerfer
On Wed, Sep 18, 2019 at 07:56:16AM +0200, Helge Deller wrote: > On 18.09.19 00:51, John David Anglin wrote: > > On 2019-09-17 5:36 p.m., Arlie Davis wrote: > >> Likewise, I'm at a loss for testing with real hardware. It's hard to > >> find such things, now. > > How does de2104x compare to ds2142/43

Re: Bug report (with fix) for DEC Tulip driver (de2104x.c)

2019-09-17 Thread Helge Deller
On 18.09.19 00:51, John David Anglin wrote: > On 2019-09-17 5:36 p.m., Arlie Davis wrote: >> Likewise, I'm at a loss for testing with real hardware. It's hard to >> find such things, now. > How does de2104x compare to ds2142/43?  I have a c3750 with ds2142/43 tulip.  > Helge > or some others might

Re: Bug report (with fix) for DEC Tulip driver (de2104x.c)

2019-09-17 Thread John David Anglin
On 2019-09-17 5:36 p.m., Arlie Davis wrote: > Likewise, I'm at a loss for testing with real hardware. It's hard to > find such things, now. How does de2104x compare to ds2142/43?  I have a c3750 with ds2142/43 tulip.  Helge or some others might have a machine with a de2104x. Dave -- John David

Re: Bug report (with fix) for DEC Tulip driver (de2104x.c)

2019-09-17 Thread Arlie Davis
I checked QEMU v3.1, and I don't see any Tulip implementation for it. I haven't checked any other emulators. A few cursory searches didn't turn up anything. I checked the FreeBSD driver for the same device. It just treats the control field as a write-only field; the driver just uses its own intern

Re: Bug report (with fix) for DEC Tulip driver (de2104x.c)

2019-09-17 Thread Andrew Lunn
On Mon, Sep 16, 2019 at 02:50:53PM -0700, Arlie Davis wrote: > Hello. I'm a developer on GCE, Google's virtual machine platform. As > part of my work, we needed to emulate a DEC Tulip 2104x NIC, so I > implemented a basic virtual device for it. > > While doing so, I believe I found a bug in the Li

Bug report (with fix) for DEC Tulip driver (de2104x.c)

2019-09-16 Thread Arlie Davis
Hello. I'm a developer on GCE, Google's virtual machine platform. As part of my work, we needed to emulate a DEC Tulip 2104x NIC, so I implemented a basic virtual device for it. While doing so, I believe I found a bug in the Linux driver for this device, in de2104x.c. I see in MAINTAINERS that thi