Re: ATM firestream bug

2006-10-01 Thread chas williams - CONTRACTOR
In message <[EMAIL PROTECTED]>,Jeff Garzik writes: >1) not safe on 64-bit firestream is not the only driver that's likely 32-bit safe only. zatm, nicstar, horizon and ambassdor all use virt_to_bus(). >2) variable 'tmc0' is indeed potentially used uninit'd, in particular if >make_rate() returns a

Re: ATM firestream bug

2006-10-01 Thread Mitchell Blank Jr
Jeff Garzik wrote: > 1) not safe on 64-bit Almost certainly correct. Probably never will be -- IIRC this SAR was mainly used in embedded apps. I don't know if any commercially-available PCI cards were ever made with it. I could be wrong though, it's been awhile since I was up on the ATM industr

ATM firestream bug

2006-10-01 Thread Jeff Garzik
The gcc warning "may be used uninitialized" is correct here, as well: drivers/atm/firestream.c: In function ‘top_off_fp’: drivers/atm/firestream.c:1501: warning: cast to pointer from integer of different size drivers/atm/firestream.c: In function ‘fs_open’: drivers/atm/firestream.c:870: warning