Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-10-05 Thread Jean Tourrilhes
On Thu, Oct 05, 2006 at 06:37:53PM -0400, Pavel Roskin wrote: > Hello! > > On Tue, 2006-10-03 at 09:34 -0700, Jean Tourrilhes wrote: > > I don't really want to overstep my authority there, my goal > > was to minimise the changes. Pavel will have to clean up my mess, so I > > don't want change

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-10-05 Thread Pavel Roskin
Hello! On Tue, 2006-10-03 at 09:34 -0700, Jean Tourrilhes wrote: > I don't really want to overstep my authority there, my goal > was to minimise the changes. Pavel will have to clean up my mess, so I > don't want change things too much. Sorry for a long delay. I'm actually not very interes

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-10-03 Thread Jean Tourrilhes
On Tue, Oct 03, 2006 at 06:45:35PM +0200, Samuel Tardieu wrote: > On 3/10, Jean Tourrilhes wrote: > > | > I suggest that you revert the memset() to IW_ESSID_MAX_SIZE+1 so that > | > the last byte is cleared as well. Or am I missing something? > | > | No, that would bring back the slab/memory ove

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-10-03 Thread Samuel Tardieu
On 3/10, Jean Tourrilhes wrote: | > I suggest that you revert the memset() to IW_ESSID_MAX_SIZE+1 so that | > the last byte is cleared as well. Or am I missing something? | | No, that would bring back the slab/memory overflow we are | trying to get rid of. Then I am puzzled by the function decl

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-10-03 Thread Jean Tourrilhes
On Tue, Oct 03, 2006 at 05:58:31PM +0200, Samuel Tardieu wrote: > > "Jean" == Jean Tourrilhes <[EMAIL PROTECTED]> writes: > > Jean> @@ -2500,9 +2501,9 @@ static int orinoco_hw_get_essid(struct o > Jean> len = le16_to_cpu(essidbuf.len); > Jean> BUG_ON(len > IW_ESSID_MAX_SIZE); >

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-10-03 Thread Samuel Tardieu
> "Jean" == Jean Tourrilhes <[EMAIL PROTECTED]> writes: Jean> @@ -2500,9 +2501,9 @@ static int orinoco_hw_get_essid(struct o Jean> len = le16_to_cpu(essidbuf.len); Jean> BUG_ON(len > IW_ESSID_MAX_SIZE); Jean> Jean> - memset(buf, 0, IW_ESSID_MAX_SIZE+1); Jean> + memset(buf, 0, IW_ESSID_MA

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-10-02 Thread Valdis . Kletnieks
On Mon, 02 Oct 2006 10:52:45 PDT, Jean Tourrilhes said: > On Fri, Sep 29, 2006 at 06:20:08PM -0700, Andrew Morton wrote: > > On Fri, 29 Sep 2006 20:01:54 -0400 > > > > > > % grep ioctl /tmp/foo2 | sort -u | more > > > ioctl(13, SIOCGIWESSID, 0xbfbcdb9c) = 0 > > > ioctl(13, SIOCGIWRANGE, 0xbfbc

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-10-02 Thread Jean Tourrilhes
On Fri, Sep 29, 2006 at 06:20:08PM -0700, Andrew Morton wrote: > On Fri, 29 Sep 2006 20:01:54 -0400 > > > > % grep ioctl /tmp/foo2 | sort -u | more > > ioctl(13, SIOCGIWESSID, 0xbfbcdb9c) = 0 > > ioctl(13, SIOCGIWRANGE, 0xbfbcdbdc) = 0 > > ioctl(13, SIOCGIWRATE, 0xbfbcdbbc) = 0 > > Y

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-09-30 Thread Andrew Morton
On Sat, 30 Sep 2006 03:50:43 -0400 [EMAIL PROTECTED] wrote: > On Fri, 29 Sep 2006 23:31:07 EDT, [EMAIL PROTECTED] said: > > Fair enough, I'm going to try reverting the 2 commits and see if things > > behave better. > > OK, it's definitely something in those 2 commits - I reverted them and the >

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-09-30 Thread Valdis . Kletnieks
On Fri, 29 Sep 2006 23:31:07 EDT, [EMAIL PROTECTED] said: > Fair enough, I'm going to try reverting the 2 commits and see if things > behave better. OK, it's definitely something in those 2 commits - I reverted them and the resulting 2.6.18-mm2 kernel has been up and stable for 4 hours, even with

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-09-29 Thread Valdis . Kletnieks
On Fri, 29 Sep 2006 18:33:48 PDT, Jean Tourrilhes said: > On Fri, Sep 29, 2006 at 06:20:08PM -0700, Andrew Morton wrote: > > On Fri, 29 Sep 2006 20:01:54 -0400 > > > > > > Here's the traceback I got: > > > > > > slab error in verify_redzone_free(): cache `size-32': memory outside > > > object wa

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-09-29 Thread Valdis . Kletnieks
On Fri, 29 Sep 2006 18:40:43 PDT, Jean Tourrilhes said: > On Fri, Sep 29, 2006 at 06:20:08PM -0700, Andrew Morton wrote: > > On Fri, 29 Sep 2006 20:01:54 -0400 > > > > > > A quick strace of gkrellm finds these likely ioctl's causing the problem: > > > > > > % grep ioctl /tmp/foo2 | sort -u | more

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-09-29 Thread Jean Tourrilhes
On Fri, Sep 29, 2006 at 06:20:08PM -0700, Andrew Morton wrote: > On Fri, 29 Sep 2006 20:01:54 -0400 > > > > A quick strace of gkrellm finds these likely ioctl's causing the problem: > > > > % grep ioctl /tmp/foo2 | sort -u | more > > ioctl(13, SIOCGIWESSID, 0xbfbcdb9c) = 0 > > ioctl(13, SIOCG

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-09-29 Thread Jean Tourrilhes
On Fri, Sep 29, 2006 at 06:20:08PM -0700, Andrew Morton wrote: > On Fri, 29 Sep 2006 20:01:54 -0400 > > > > Here's the traceback I got: > > > > slab error in verify_redzone_free(): cache `size-32': memory outside object > > was overwritten > > [] dump_trace+0x64/0x1cd > > [] show_trace_log_lvl+0

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-09-29 Thread Andrew Morton
On Fri, 29 Sep 2006 20:01:54 -0400 [EMAIL PROTECTED] wrote: > On Fri, 29 Sep 2006 12:45:58 PDT, Andrew Morton said: > > (Adding a bunch of people to the cc: list now that I have a clue what is > going on) > > > I'd expect it's the same bug - slab data structures have gone bad. > > *bing*! W

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-09-29 Thread Valdis . Kletnieks
On Fri, 29 Sep 2006 12:45:58 PDT, Andrew Morton said: (Adding a bunch of people to the cc: list now that I have a clue what is going on) > I'd expect it's the same bug - slab data structures have gone bad. *bing*! We have a winner. A quick check showed the kernel wasn't built with slab debu