Re: 答复: [PATCH,v2] ipvlan: add the check of ip header checksum

2020-07-24 Thread David Miller
From: "Guodeqing (A)" Date: Fri, 24 Jul 2020 03:35:02 + > The ihl check maybe not suitable in ip_fast_csum, the correct of the > ihl value can be checked before calling the ip_fast_csum. ip_fast_csum() must be able to handle any value that could fit in the ihl field of the ip protocol header

答复: 答复: [PATCH,v2] ipvlan: add the check of ip header checksum

2020-07-24 Thread Guodeqing (A)
> -邮件原件- > 发件人: Eric Dumazet [mailto:eric.duma...@gmail.com] > 发送时间: Friday, July 24, 2020 13:14 > 收件人: Guodeqing (A) ; Eric Dumazet > > 抄送: David Miller ; k...@kernel.org; > mahe...@google.com; netdev@vger.kernel.org > 主题: Re: 答复: [PATCH,v2] ipvlan: add the che

Re: 答复: [PATCH,v2] ipvlan: add the check of ip header checksum

2020-07-23 Thread Eric Dumazet
Please do not top-post on netdev / lkml ( https://www.mediawiki.org/wiki/Mailing_list_etiquette ) On 7/23/20 8:35 PM, Guodeqing (A) wrote: > The ihl check maybe not suitable in ip_fast_csum, the correct of the ihl > value can be checked before calling the ip_fast_csum. > > The implementation

答复: [PATCH,v2] ipvlan: add the check of ip header checksum

2020-07-23 Thread Guodeqing (A)
The ihl check maybe not suitable in ip_fast_csum, the correct of the ihl value can be checked before calling the ip_fast_csum. The implementation of ip_fast_csum is different in different cpu architecture. the IP packet will do ip forward in the ipvlan l3/l3s mode and the corrupted ip packet s

答复: [PATCH,v2] ipvlan: add the check of ip header checksum

2020-07-22 Thread Guodeqing (A)
Because ipvlan will do the ip forward, it will do a route lookup.if the ihl of the ip header is smaller than 5, this cause ip_fast_csum access the illegal address. -邮件原件- 发件人: Eric Dumazet [mailto:eduma...@google.com] 发送时间: Thursday, July 23, 2020 0:30 收件人: Guodeqing (A) 抄送: David Mill

答复: [PATCH,v2] ipvlan: add the check of ip header checksum

2020-07-22 Thread Guodeqing (A)
I am sorry, the mail is not sent to you directly; If do the following test,this will cause a panic in a arm64 VM. this can be reproduced easily. Linux osc 5.8.0-rc6+ #3 SMP Thu Jul 23 01:40:47 UTC 2020 aarch64 The programs included with the Debian GNU/Linux system are free software; the exact