Re: [v4 2/4] samples: pktgen: fix proc_cmd command result check logic

2019-10-04 Thread Daniel T. Lee
On Fri, Oct 4, 2019 at 10:24 PM Jesper Dangaard Brouer wrote: > > [...] > > Is this comment still relevant? You just excluded "pgctrl" from > getting into this section. > Oops, will fix it right away. > > +if [[ "$result" == "" ]]; then > > +grep "Result:" $proc_ctrl >&2 > > Mis

Re: [v4 2/4] samples: pktgen: fix proc_cmd command result check logic

2019-10-04 Thread Jesper Dangaard Brouer
On Fri, 4 Oct 2019 10:32:59 +0900 "Daniel T. Lee" wrote: > Currently, proc_cmd is used to dispatch command to 'pg_ctrl', 'pg_thread', > 'pg_set'. proc_cmd is designed to check command result with grep the > "Result:", but this might fail since this string is only shown in > 'pg_thread' and 'pg_s

[v4 2/4] samples: pktgen: fix proc_cmd command result check logic

2019-10-03 Thread Daniel T. Lee
Currently, proc_cmd is used to dispatch command to 'pg_ctrl', 'pg_thread', 'pg_set'. proc_cmd is designed to check command result with grep the "Result:", but this might fail since this string is only shown in 'pg_thread' and 'pg_set'. This commit fixes this logic by grep-ing the "Result:" string