"Daniel T. Lee" writes:
> On Fri, Oct 4, 2019 at 9:52 PM Jesper Dangaard Brouer
> wrote:
>
>>
>> On Fri, 4 Oct 2019 10:32:58 +0900 "Daniel T. Lee"
>> wrote:
>>
>> > [...]
>>
>>
> Thanks for the review!
>
>
>> A general comment, you forgot a cover letter for your patchset.
>>
>>
> At first, I t
On Fri, Oct 4, 2019 at 10:41 PM Jesper Dangaard Brouer
wrote:
>
> On Fri, 4 Oct 2019 22:28:26 +0900
> "Daniel T. Lee" wrote:
>
> > On Fri, Oct 4, 2019 at 9:52 PM Jesper Dangaard Brouer
> > wrote:
> > >
> > >
> > > On Fri, 4 Oct 2019 10:32:58 +0900 "Daniel T. Lee"
> > > wrote:
> > >
> > > > [
On Fri, 4 Oct 2019 22:28:26 +0900
"Daniel T. Lee" wrote:
> On Fri, Oct 4, 2019 at 9:52 PM Jesper Dangaard Brouer
> wrote:
> >
> >
> > On Fri, 4 Oct 2019 10:32:58 +0900 "Daniel T. Lee"
> > wrote:
> >
> > > [...]
> >
>
> Thanks for the review!
>
> > A general comment, you forgot a cove
On Fri, Oct 4, 2019 at 9:52 PM Jesper Dangaard Brouer wrote:
>
>
> On Fri, 4 Oct 2019 10:32:58 +0900 "Daniel T. Lee"
> wrote:
>
> > [...]
>
Thanks for the review!
> A general comment, you forgot a cover letter for your patchset.
>
At first, I thought the size of the patchset (the feature to
On Fri, 4 Oct 2019 10:32:58 +0900
"Daniel T. Lee" wrote:
> This commit changes variable names that can cause confusion.
>
> For example, variable DST_MIN is quite confusing since the
> keyword 'udp_dst_min' and keyword 'dst_min' is used with pg_ctrl.
>
> On the following commit, 'dst_min' will
On Fri, 4 Oct 2019 10:32:58 +0900 "Daniel T. Lee"
wrote:
> [...]
A general comment, you forgot a cover letter for your patchset.
And also forgot the "PATCH" part of subj. but patchwork still found it:
https://patchwork.ozlabs.org/project/netdev/list/?series=134102&state=2a
--
Best regard
This commit changes variable names that can cause confusion.
For example, variable DST_MIN is quite confusing since the
keyword 'udp_dst_min' and keyword 'dst_min' is used with pg_ctrl.
On the following commit, 'dst_min' will be used to set destination IP,
and the existing variable name DST_MIN s
