Re: [v3,1/4] tools: bpftool: add net attach command to attach XDP on interface

2019-08-08 Thread Daniel T. Lee
On Fri, Aug 9, 2019 at 2:50 AM Jakub Kicinski wrote: > > On Thu, 8 Aug 2019 07:15:22 +0900, Daniel T. Lee wrote: > > > > + return -EINVAL; > > > > + } > > > > + > > > > + NEXT_ARG(); > > > > > > nit: the new line should be before NEXT_ARG(), IOV NEXT_ARG() belongs > > > to the

Re: [v3,1/4] tools: bpftool: add net attach command to attach XDP on interface

2019-08-08 Thread Jakub Kicinski
On Thu, 8 Aug 2019 07:15:22 +0900, Daniel T. Lee wrote: > > > + return -EINVAL; > > > + } > > > + > > > + NEXT_ARG(); > > > > nit: the new line should be before NEXT_ARG(), IOV NEXT_ARG() belongs > > to the code which consumed the argument > > > > I'm not sure I'm following

Re: [v3,1/4] tools: bpftool: add net attach command to attach XDP on interface

2019-08-08 Thread Daniel T. Lee
On Thu, Aug 8, 2019 at 5:42 AM Jakub Kicinski wrote: > > On Wed, 7 Aug 2019 11:25:06 +0900, Daniel T. Lee wrote: > > By this commit, using `bpftool net attach`, user can attach XDP prog on > > interface. New type of enum 'net_attach_type' has been made, as stated at > > cover-letter, the meaning

Re: [v3,1/4] tools: bpftool: add net attach command to attach XDP on interface

2019-08-07 Thread Jakub Kicinski
On Wed, 7 Aug 2019 11:25:06 +0900, Daniel T. Lee wrote: > By this commit, using `bpftool net attach`, user can attach XDP prog on > interface. New type of enum 'net_attach_type' has been made, as stated at > cover-letter, the meaning of 'attach' is, prog will be attached on interface. > > With 'o

Re: [v3,1/4] tools: bpftool: add net attach command to attach XDP on interface

2019-08-07 Thread Y Song
On Tue, Aug 6, 2019 at 7:25 PM Daniel T. Lee wrote: > > By this commit, using `bpftool net attach`, user can attach XDP prog on > interface. New type of enum 'net_attach_type' has been made, as stated at > cover-letter, the meaning of 'attach' is, prog will be attached on interface. > > With 'over

[v3,1/4] tools: bpftool: add net attach command to attach XDP on interface

2019-08-06 Thread Daniel T. Lee
By this commit, using `bpftool net attach`, user can attach XDP prog on interface. New type of enum 'net_attach_type' has been made, as stated at cover-letter, the meaning of 'attach' is, prog will be attached on interface. With 'overwrite' option at argument, attached XDP program could be replace