Re: [v2 PATCH 5/13] crypto: testmgr - Switch to new AEAD interface

2015-06-07 Thread Herbert Xu
On Fri, Jun 05, 2015 at 03:10:00PM -0700, Tadeusz Struk wrote: > > Yes, assuming that one is using req->assoclen not only req->assoc ;) You're quite right. I found two more drivers that need to be fixed before this goes mainline. > When do you expect the assoc will be removed? It will be remov

Re: [v2 PATCH 5/13] crypto: testmgr - Switch to new AEAD interface

2015-06-05 Thread Tadeusz Struk
On 06/04/2015 08:57 PM, Herbert Xu wrote: > Existing AEAD implementations should be completely unaware of > the new interface because we recreate the old req->assoc in the > crypto API. Yes, assuming that one is using req->assoclen not only req->assoc ;) > > However, if you are creating a new AE

Re: [v2 PATCH 5/13] crypto: testmgr - Switch to new AEAD interface

2015-06-04 Thread Herbert Xu
On Thu, Jun 04, 2015 at 03:15:19PM -0700, Tadeusz Struk wrote: > Hi Herbert, > On 05/22/2015 01:30 AM, Herbert Xu wrote: > > This patch makes use of the new AEAD interface which uses a single > > SG list instead of separate lists for the AD and plain text. > > The fact the src and assoc point to t

Re: [v2 PATCH 5/13] crypto: testmgr - Switch to new AEAD interface

2015-06-04 Thread Tadeusz Struk
Hi Herbert, On 05/22/2015 01:30 AM, Herbert Xu wrote: > This patch makes use of the new AEAD interface which uses a single > SG list instead of separate lists for the AD and plain text. The fact the src and assoc point to the same sgl causes some inconsistency. The input I'm getting is: req->old

[v2 PATCH 5/13] crypto: testmgr - Switch to new AEAD interface

2015-05-22 Thread Herbert Xu
This patch makes use of the new AEAD interface which uses a single SG list instead of separate lists for the AD and plain text. Signed-off-by: Herbert Xu --- crypto/testmgr.c | 84 +++ 1 file changed, 48 insertions(+), 36 deletions(-) diff