Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

2017-03-27 Thread Alexandre Torgue
Hi Joao On 03/24/2017 06:09 PM, Joao Pinto wrote: Hello David, Às 5:05 PM de 3/24/2017, David Miller escreveu: From: Andrew Lunn Date: Fri, 24 Mar 2017 12:17:36 +0100 Yes it would be fantastic to have a set of boards, but I rarely see this in any maintainer :). Being a Marvell SoC and sw

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

2017-03-27 Thread Joao Pinto
Às 10:28 AM de 3/27/2017, Alexandre Torgue escreveu: > Hi Joao > > On 03/24/2017 06:09 PM, Joao Pinto wrote: >> >> Hello David, >> >> Às 5:05 PM de 3/24/2017, David Miller escreveu: >>> From: Andrew Lunn >>> Date: Fri, 24 Mar 2017 12:17:36 +0100 >>> > Yes it would be fantastic to have a set o

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

2017-03-24 Thread Joao Pinto
Às 5:17 PM de 3/24/2017, David Miller escreveu: > From: Joao Pinto > Date: Fri, 24 Mar 2017 15:02:27 + > >> Yes, I agree, it is better to revert and leave the tree functional for all. >> >> @David Miller: >> The multiple-buffer patch introduced some problems in some setups that are >> being

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

2017-03-24 Thread David Miller
From: Joao Pinto Date: Fri, 24 Mar 2017 15:02:27 + > Yes, I agree, it is better to revert and leave the tree functional for all. > > @David Miller: > The multiple-buffer patch introduced some problems in some setups that are > being > hard to debug, so Corentin gave the idea of reverting th

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

2017-03-24 Thread Joao Pinto
Hello David, Às 5:05 PM de 3/24/2017, David Miller escreveu: > From: Andrew Lunn > Date: Fri, 24 Mar 2017 12:17:36 +0100 > >>> Yes it would be fantastic to have a set of boards, but I rarely see this in >>> any >>> maintainer :). >> >> Being a Marvell SoC and switch maintainer, i have around a

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

2017-03-24 Thread David Miller
From: Andrew Lunn Date: Fri, 24 Mar 2017 12:17:36 +0100 >> Yes it would be fantastic to have a set of boards, but I rarely see this in >> any >> maintainer :). > > Being a Marvell SoC and switch maintainer, i have around a dozen > boards. Some i got some simply by asking the manufacture, others

Fwd: Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

2017-03-24 Thread Joao Pinto
Sorry, sending again with David Miller in TO: instead of CC. Às 2:09 PM de 3/24/2017, Corentin Labbe escreveu: > On Thu, Mar 23, 2017 at 07:10:59PM +0100, Thierry Reding wrote: >> On Thu, Mar 23, 2017 at 05:27:08PM +, Joao Pinto wrote: >>> Hi Thierry, >>> >> >> Yes, I can submit a patch for t

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

2017-03-24 Thread Joao Pinto
Às 2:09 PM de 3/24/2017, Corentin Labbe escreveu: > On Thu, Mar 23, 2017 at 07:10:59PM +0100, Thierry Reding wrote: >> On Thu, Mar 23, 2017 at 05:27:08PM +, Joao Pinto wrote: >>> Hi Thierry, >>> >> >> Yes, I can submit a patch for that. >> >> After some more testing I did get a couple (roughly

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

2017-03-24 Thread Corentin Labbe
On Thu, Mar 23, 2017 at 07:10:59PM +0100, Thierry Reding wrote: > On Thu, Mar 23, 2017 at 05:27:08PM +, Joao Pinto wrote: > > Hi Thierry, > > > > Às 5:17 PM de 3/23/2017, Thierry Reding escreveu: > > > On Fri, Mar 17, 2017 at 04:11:05PM +, Joao Pinto wrote: > > >> This patch creates 2 new

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

2017-03-24 Thread Joao Pinto
Às 11:17 AM de 3/24/2017, Andrew Lunn escreveu: >> Yes it would be fantastic to have a set of boards, but I rarely see this in >> any >> maintainer :). > > Being a Marvell SoC and switch maintainer, i have around a dozen > boards. Some i got some simply by asking the manufacture, others i > purch

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

2017-03-24 Thread Andrew Lunn
> Yes it would be fantastic to have a set of boards, but I rarely see this in > any > maintainer :). Being a Marvell SoC and switch maintainer, i have around a dozen boards. Some i got some simply by asking the manufacture, others i purchased. I don't think i'm in the minority here. Without havin

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

2017-03-24 Thread Joao Pinto
Hi Andrew, Às 7:42 AM de 3/24/2017, Andrew Lunn escreveu: > On Thu, Mar 23, 2017 at 05:27:08PM +, Joao Pinto wrote: > >> Yes, you are correct. It should be priv->plat->tx_queues_to_use instead of >> "u32 >> tx_count = priv->dma_cap.number_tx_queues;"... sorry for that, but in my >> setup >>

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

2017-03-24 Thread Andrew Lunn
On Thu, Mar 23, 2017 at 05:27:08PM +, Joao Pinto wrote: > Yes, you are correct. It should be priv->plat->tx_queues_to_use instead of > "u32 > tx_count = priv->dma_cap.number_tx_queues;"... sorry for that, but in my setup > is the same value. Could you please make a patch for it? Hi Joao As

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

2017-03-23 Thread Thierry Reding
On Thu, Mar 23, 2017 at 05:27:08PM +, Joao Pinto wrote: > Hi Thierry, > > Às 5:17 PM de 3/23/2017, Thierry Reding escreveu: > > On Fri, Mar 17, 2017 at 04:11:05PM +, Joao Pinto wrote: > >> This patch creates 2 new structures (stmmac_tx_queue and stmmac_rx_queue) > >> in include/linux/stmma

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

2017-03-23 Thread Joao Pinto
Hi Thierry, Às 5:17 PM de 3/23/2017, Thierry Reding escreveu: > On Fri, Mar 17, 2017 at 04:11:05PM +, Joao Pinto wrote: >> This patch creates 2 new structures (stmmac_tx_queue and stmmac_rx_queue) >> in include/linux/stmmac.h, enabling that each RX and TX queue has its >> own buffers and data.

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

2017-03-23 Thread Thierry Reding
On Fri, Mar 17, 2017 at 04:11:05PM +, Joao Pinto wrote: > This patch creates 2 new structures (stmmac_tx_queue and stmmac_rx_queue) > in include/linux/stmmac.h, enabling that each RX and TX queue has its > own buffers and data. > > Signed-off-by: Joao Pinto > --- > changes v1->v2: > - just to

[PATCH v2 net-next 1/3] net: stmmac: enable multiple buffers

2017-03-17 Thread Joao Pinto
This patch creates 2 new structures (stmmac_tx_queue and stmmac_rx_queue) in include/linux/stmmac.h, enabling that each RX and TX queue has its own buffers and data. Signed-off-by: Joao Pinto --- changes v1->v2: - just to keep up version drivers/net/ethernet/stmicro/stmmac/chain_mode.c | 45