Re: [v2,1/2] tools: bpftool: add net attach command to attach XDP on interface

2019-08-03 Thread Jakub Kicinski
On Sat, 3 Aug 2019 18:39:21 +0900, Daniel T. Lee wrote: > On Sat, Aug 3, 2019 at 3:39 AM Jakub Kicinski wrote: > > Right, I was wondering if we want to call it force, though? force is > > sort of a reuse of iproute2 concept. But it's kind of hard to come up > > with names. > > > > Just to be sure -

Re: [v2,1/2] tools: bpftool: add net attach command to attach XDP on interface

2019-08-03 Thread Daniel T. Lee
On Sat, Aug 3, 2019 at 3:39 AM Jakub Kicinski wrote: > > On Fri, 2 Aug 2019 14:02:29 +0900, Daniel T. Lee wrote: > > On Fri, Aug 2, 2019 at 8:36 AM Jakub Kicinski wrote: > > > On Thu, 1 Aug 2019 17:11:32 +0900, Daniel T. Lee wrote: > > > > By this commit, using `bpftool net attach`, user can att

Re: [v2,1/2] tools: bpftool: add net attach command to attach XDP on interface

2019-08-02 Thread Jakub Kicinski
On Fri, 2 Aug 2019 14:02:29 +0900, Daniel T. Lee wrote: > On Fri, Aug 2, 2019 at 8:36 AM Jakub Kicinski wrote: > > On Thu, 1 Aug 2019 17:11:32 +0900, Daniel T. Lee wrote: > > > By this commit, using `bpftool net attach`, user can attach XDP prog on > > > interface. New type of enum 'net_attach_

Re: [v2,1/2] tools: bpftool: add net attach command to attach XDP on interface

2019-08-02 Thread Daniel T. Lee
On Fri, Aug 2, 2019 at 3:23 PM Y Song wrote: > > On Thu, Aug 1, 2019 at 2:04 AM Daniel T. Lee wrote: > > > > By this commit, using `bpftool net attach`, user can attach XDP prog on > > interface. New type of enum 'net_attach_type' has been made, as stated at > > cover-letter, the meaning of 'atta

Re: [v2,1/2] tools: bpftool: add net attach command to attach XDP on interface

2019-08-01 Thread Y Song
On Thu, Aug 1, 2019 at 2:04 AM Daniel T. Lee wrote: > > By this commit, using `bpftool net attach`, user can attach XDP prog on > interface. New type of enum 'net_attach_type' has been made, as stated at > cover-letter, the meaning of 'attach' is, prog will be attached on interface. > > BPF prog w

Re: [v2,1/2] tools: bpftool: add net attach command to attach XDP on interface

2019-08-01 Thread Daniel T. Lee
On Fri, Aug 2, 2019 at 8:36 AM Jakub Kicinski wrote: > > On Thu, 1 Aug 2019 17:11:32 +0900, Daniel T. Lee wrote: > > By this commit, using `bpftool net attach`, user can attach XDP prog on > > interface. New type of enum 'net_attach_type' has been made, as stated at > > cover-letter, the meaning

Re: [v2,1/2] tools: bpftool: add net attach command to attach XDP on interface

2019-08-01 Thread Jakub Kicinski
On Thu, 1 Aug 2019 17:11:32 +0900, Daniel T. Lee wrote: > By this commit, using `bpftool net attach`, user can attach XDP prog on > interface. New type of enum 'net_attach_type' has been made, as stated at > cover-letter, the meaning of 'attach' is, prog will be attached on interface. > > BPF pro

[v2,1/2] tools: bpftool: add net attach command to attach XDP on interface

2019-08-01 Thread Daniel T. Lee
By this commit, using `bpftool net attach`, user can attach XDP prog on interface. New type of enum 'net_attach_type' has been made, as stated at cover-letter, the meaning of 'attach' is, prog will be attached on interface. BPF prog will be attached through libbpf 'bpf_set_link_xdp_fd'. Signed-of