Re: [take16 1/4] kevent: Core files.

2006-09-07 Thread Evgeniy Polyakov
On Wed, Sep 06, 2006 at 09:23:56AM -0500, Chase Venters ([EMAIL PROTECTED]) wrote: > On Wed, 6 Sep 2006, Evgeniy Polyakov wrote: > >>>+struct kevent_user > >>>+{ > >> > >>These structure names get a little dicey (kevent, kevent_user, ukevent, > >>mukevent)... might there be slightly different name

Re: [take16 1/4] kevent: Core files.

2006-09-06 Thread Chase Venters
On Wed, 6 Sep 2006, Evgeniy Polyakov wrote: + +struct kevent_user +{ These structure names get a little dicey (kevent, kevent_user, ukevent, mukevent)... might there be slightly different names that could be selected to better distinguish the purpose of each? Like what? ukevent means userspa

Re: [take16 1/4] kevent: Core files.

2006-09-06 Thread Evgeniy Polyakov
On Wed, Sep 06, 2006 at 08:40:21AM -0500, Chase Venters ([EMAIL PROTECTED]) wrote: > Evgeniy, > Sorry about the radio silence later. Some reviewer commentary > follows. > >+struct kevent > >+{ > >+/* Used for kevent freeing.*/ > >+struct rcu_head rcu_head; > >+struct u

Re: [take16 1/4] kevent: Core files.

2006-09-06 Thread Chase Venters
On Wed, 6 Sep 2006, Chase Venters wrote: + if (start + num >= KEVENT_MAX_EVENTS || + start >= KEVENT_MAX_EVENTS || + num >= KEVENT_MAX_EVENTS) Since start and num are unsigned, the last two checks are redundant. If start or num is individually

Re: [take16 1/4] kevent: Core files.

2006-09-06 Thread Chase Venters
Evgeniy, Sorry about the radio silence later. Some reviewer commentary follows. On Wed, 6 Sep 2006, Evgeniy Polyakov wrote: Core files. This patch includes core kevent files: - userspace controlling - kernelspace interfaces - initialization - notification state machines Signed-off-by: Evg

[take16 1/4] kevent: Core files.

2006-09-06 Thread Evgeniy Polyakov
Core files. This patch includes core kevent files: - userspace controlling - kernelspace interfaces - initialization - notification state machines Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/arch/i386/kernel/syscall_table.S b/arch/i386/kernel/syscall_table.S index dd63d