Re: [take12 3/3] kevent: Timer notifications.

2006-08-22 Thread Evgeniy Polyakov
On Mon, Aug 21, 2006 at 04:25:49PM +0200, Thomas Gleixner ([EMAIL PROTECTED]) wrote: > > Not everymachine has them > > Every machine has hrtimers - not necessarily with high resolution timer > support, but the core code is there in any case and it is designed to > provide fine grained timers. >

Re: [take12 3/3] kevent: Timer notifications.

2006-08-22 Thread Thomas Gleixner
On Mon, 2006-08-21 at 15:18 +0400, Evgeniy Polyakov wrote: > On Mon, Aug 21, 2006 at 12:12:39PM +0100, Christoph Hellwig ([EMAIL > PROTECTED]) wrote: > > On Mon, Aug 21, 2006 at 02:19:49PM +0400, Evgeniy Polyakov wrote: > > > > > > > > > Timer notifications. > > > > > > Timer notifications can

Re: [take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Evgeniy Polyakov
On Mon, Aug 21, 2006 at 09:36:50PM -0700, Andrew Morton ([EMAIL PROTECTED]) wrote: > On Mon, 21 Aug 2006 16:09:34 +0400 > Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > > > On Mon, Aug 21, 2006 at 12:12:39PM +0100, Christoph Hellwig ([EMAIL > > PROTECTED]) wrote: > > > > +static int __init kevent

Re: [take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Andrew Morton
On Mon, 21 Aug 2006 16:09:34 +0400 Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > On Mon, Aug 21, 2006 at 12:12:39PM +0100, Christoph Hellwig ([EMAIL > PROTECTED]) wrote: > > > +static int __init kevent_init_timer(void) > > > +{ > > > + struct kevent_callbacks tc = { > > > + .callback = &k

Re: [take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Evgeniy Polyakov
On Mon, Aug 21, 2006 at 02:13:49PM +0200, Arjan van de Ven ([EMAIL PROTECTED]) wrote: > > > Call me a cynic, but I'm always a bit sceptical about needing lockdep > > > annotations like this... Can you explain why you need it in this case, > > > including the proof that it's safe? > > > > Ok, agai

Re: [take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Arjan van de Ven
On Mon, 2006-08-21 at 15:59 +0400, Evgeniy Polyakov wrote: > On Mon, Aug 21, 2006 at 01:27:22PM +0200, Arjan van de Ven ([EMAIL > PROTECTED]) wrote: > > On Mon, 2006-08-21 at 15:18 +0400, Evgeniy Polyakov wrote: > > > ]> > +lockdep_set_class(&t->ktimer_storage.lock, &kevent_timer_key); > > > >

Re: [take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Evgeniy Polyakov
On Mon, Aug 21, 2006 at 12:12:39PM +0100, Christoph Hellwig ([EMAIL PROTECTED]) wrote: > > +static int __init kevent_init_timer(void) > > +{ > > + struct kevent_callbacks tc = { > > + .callback = &kevent_timer_callback, > > + .enqueue = &kevent_timer_enqueue, > > +

Re: [take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Evgeniy Polyakov
On Mon, Aug 21, 2006 at 01:27:22PM +0200, Arjan van de Ven ([EMAIL PROTECTED]) wrote: > On Mon, 2006-08-21 at 15:18 +0400, Evgeniy Polyakov wrote: > > ]> > + lockdep_set_class(&t->ktimer_storage.lock, &kevent_timer_key); > > > > > > When looking at the kevent_storage_init callers most need t

Re: [take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Arjan van de Ven
On Mon, 2006-08-21 at 15:18 +0400, Evgeniy Polyakov wrote: > ]> > +lockdep_set_class(&t->ktimer_storage.lock, &kevent_timer_key); > > > > When looking at the kevent_storage_init callers most need to do > > those lockdep_set_class class. Shouldn't kevent_storage_init just > > get a "struct

Re: [take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Evgeniy Polyakov
On Mon, Aug 21, 2006 at 12:12:39PM +0100, Christoph Hellwig ([EMAIL PROTECTED]) wrote: > On Mon, Aug 21, 2006 at 02:19:49PM +0400, Evgeniy Polyakov wrote: > > > > > > Timer notifications. > > > > Timer notifications can be used for fine grained per-process time > > management, since interval t

Re: [take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Christoph Hellwig
On Mon, Aug 21, 2006 at 02:19:49PM +0400, Evgeniy Polyakov wrote: > > > Timer notifications. > > Timer notifications can be used for fine grained per-process time > management, since interval timers are very inconvenient to use, > and they are limited. Shouldn't this at leat use a hrtimer? >

[take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Evgeniy Polyakov
Timer notifications. Timer notifications can be used for fine grained per-process time management, since interval timers are very inconvenient to use, and they are limited. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/kernel/kevent/kevent_timer.c b/kernel/kevent/kevent_ti