Re: [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()")

2017-09-19 Thread Eric Dumazet
On Tue, 2017-09-19 at 15:45 +0300, Ville Syrjälä wrote: > On Mon, Sep 18, 2017 at 12:52:15PM -0700, Eric Dumazet wrote: > > On Mon, Sep 18, 2017 at 12:46 PM, Ville Syrjälä > > wrote: > > > > > And five months later I'm still waiting for this patch to land... > > > > Sure, while I was on vacation

Re: [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()")

2017-09-19 Thread Ville Syrjälä
On Mon, Sep 18, 2017 at 12:52:15PM -0700, Eric Dumazet wrote: > On Mon, Sep 18, 2017 at 12:46 PM, Ville Syrjälä > wrote: > > > And five months later I'm still waiting for this patch to land... > > Sure, while I was on vacation, I received thousands of emails that I > simply have not read. Ah th

Re: [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()")

2017-09-18 Thread Eric Dumazet
On Mon, Sep 18, 2017 at 12:46 PM, Ville Syrjälä wrote: > And five months later I'm still waiting for this patch to land... Sure, while I was on vacation, I received thousands of emails that I simply have not read.

Re: [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()")

2017-09-18 Thread Ville Syrjälä
On Mon, Apr 10, 2017 at 03:11:02PM +0300, Ville Syrjälä wrote: > On Fri, Apr 07, 2017 at 11:38:49AM -0700, Eric Dumazet wrote: > > On Fri, 2017-04-07 at 21:17 +0300, Ville Syrjälä wrote: > > > Hi, > > > > > > My old P3 laptop started to die on me in the middle of larger compile > > > jobs (using d

Re: [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()")

2017-07-05 Thread Ville Syrjälä
On Mon, Jun 19, 2017 at 04:44:45PM +0200, Michal Kubecek wrote: > On Fri, Apr 07, 2017 at 11:38:49AM -0700, Eric Dumazet wrote: > > On Fri, 2017-04-07 at 21:17 +0300, Ville Syrjälä wrote: > > > Hi, > > > > > > My old P3 laptop started to die on me in the middle of larger compile > > > jobs (using

Re: [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()")

2017-06-19 Thread Michal Kubecek
On Fri, Apr 07, 2017 at 11:38:49AM -0700, Eric Dumazet wrote: > On Fri, 2017-04-07 at 21:17 +0300, Ville Syrjälä wrote: > > Hi, > > > > My old P3 laptop started to die on me in the middle of larger compile > > jobs (using distcc) after v4.11-rc. I bisected the problem > > to 617f01211baf ("8139too

Re: [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()")

2017-04-21 Thread Eric Dumazet
On Fri, 2017-04-21 at 06:29 -0700, Eric Dumazet wrote: > Thanks for this report. > > Interesting to see how many drivers got the netpoll stuff wrong :/ > > Can you try : > > diff --git a/drivers/net/ethernet/realtek/r8169.c > b/drivers/net/ethernet/realtek/r8169.c > index > 81f18a8335276495a5

Re: [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()")

2017-04-21 Thread Eric Dumazet
On Fri, 2017-04-21 at 08:09 -0700, Eric Dumazet wrote: > On Fri, 2017-04-21 at 06:29 -0700, Eric Dumazet wrote: > > > Thanks for this report. > > > > Interesting to see how many drivers got the netpoll stuff wrong :/ > > > > Can you try : > > > > diff --git a/drivers/net/ethernet/realtek/r8169.

Re: [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()")

2017-04-21 Thread Eric Dumazet
On Fri, 2017-04-21 at 14:40 +0300, Ville Syrjälä wrote: > BTW I've also been getting some lockdep grief from r8169 netpoll stuff > recently. Not sure if it might be related to these changes or not, but > I don't remember seeing this sort of stuff until quite recently. > > [ 251.911044] ==

Re: [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()")

2017-04-21 Thread Ville Syrjälä
BTW I've also been getting some lockdep grief from r8169 netpoll stuff recently. Not sure if it might be related to these changes or not, but I don't remember seeing this sort of stuff until quite recently. [ 251.911044] == [ 251.911044] [ INFO

Re: [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()")

2017-04-10 Thread Eric Dumazet
On Mon, Apr 10, 2017 at 7:22 AM, tedheadster wrote: > On Sat, Apr 8, 2017 at 6:23 AM, Francois Romieu wrote: >> David Miller : >> [...] >>> One theory is that the interrupt masking isn't working properly >>> and interrupts are still arriving and hitting the NAPI state even >>> when we are active

Re: [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()")

2017-04-10 Thread tedheadster
On Sat, Apr 8, 2017 at 6:23 AM, Francois Romieu wrote: > David Miller : > [...] >> One theory is that the interrupt masking isn't working properly >> and interrupts are still arriving and hitting the NAPI state even >> when we are actively polling NAPI. >> >> And this problem was masked by the lo

Re: [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()")

2017-04-10 Thread Ville Syrjälä
On Fri, Apr 07, 2017 at 11:38:49AM -0700, Eric Dumazet wrote: > On Fri, 2017-04-07 at 21:17 +0300, Ville Syrjälä wrote: > > Hi, > > > > My old P3 laptop started to die on me in the middle of larger compile > > jobs (using distcc) after v4.11-rc. I bisected the problem > > to 617f01211baf ("8139too

Re: [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()")

2017-04-08 Thread Francois Romieu
David Miller : [...] > One theory is that the interrupt masking isn't working properly > and interrupts are still arriving and hitting the NAPI state even > when we are actively polling NAPI. > > And this problem was masked by the locking done here. Yes. Ville, can you rule out irq sharing betw

Re: [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()")

2017-04-07 Thread David Miller
From: Eric Dumazet Date: Fri, 07 Apr 2017 11:38:49 -0700 > I do not really see what could be wrong, the code should run just fine > on UP. One theory is that the interrupt masking isn't working properly and interrupts are still arriving and hitting the NAPI state even when we are actively pollin

Re: [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()")

2017-04-07 Thread Eric Dumazet
On Fri, 2017-04-07 at 21:17 +0300, Ville Syrjälä wrote: > Hi, > > My old P3 laptop started to die on me in the middle of larger compile > jobs (using distcc) after v4.11-rc. I bisected the problem > to 617f01211baf ("8139too: use napi_complete_done()"). > > Unfortunately I wasn't able to capture

[regression v4.11] 617f01211baf ("8139too: use napi_complete_done()")

2017-04-07 Thread Ville Syrjälä
Hi, My old P3 laptop started to die on me in the middle of larger compile jobs (using distcc) after v4.11-rc. I bisected the problem to 617f01211baf ("8139too: use napi_complete_done()"). Unfortunately I wasn't able to capture a full oops as the machine doesn't have serial and ramoops failed me.