I'm dropping all the old comments since the conversation was flattened
and only has one level of marks for everything.
On Thu, Aug 30, 2018 at 7:43 AM Alex Vesker wrote:
> To which devlink interfaces are you referring?
All of them. Not just the ones in this patch. If you are exposing an
inter
On Wed, Aug 29, 2018 at 8:43 AM Alex Vesker wrote:
>
>
> > On Wed, Aug 1, 2018 at 4:13 PM, Saeed Mahameed
> > wrote:
> >> On Wed, Aug 1, 2018 at 3:34 PM, Alexander Duyck
> >> wrote:
> >>> On Wed, Aug 1, 2018 at 2:52 PM, Saeed Mahameed
> >>> wrote:
> Hi Dave,
>
> This series provi
On Wed, Aug 1, 2018 at 4:13 PM, Saeed Mahameed
wrote:
On Wed, Aug 1, 2018 at 3:34 PM, Alexander Duyck
wrote:
On Wed, Aug 1, 2018 at 2:52 PM, Saeed Mahameed
wrote:
Hi Dave,
This series provides devlink parameters updates to both devlink API
and
mlx5 driver, it is a 2nd iteration of the d
On Mon, 6 Aug 2018 16:01:25 +0300, Eran Ben Elisha wrote:
> >> Hi Dave,
> >> I would like to re-state that this feature was not meant to be a generic
> >> one. This feature was added in order to resolve a HW bug which exist in
> >> a small portion of our devices.
> >
> > Would you mind describin
Hi Dave,
I would like to re-state that this feature was not meant to be a generic
one. This feature was added in order to resolve a HW bug which exist in
a small portion of our devices.
Would you mind describing the HW bug in more detail? To a outside
reviewer it really looks like you're addin
On Fri, 3 Aug 2018 19:41:50 +0300, Ido Schimmel wrote:
> On Thu, Aug 02, 2018 at 03:53:15PM -0700, Jakub Kicinski wrote:
> > No one is requesting full RED offload here.. if someone sets the
> > parameters you can't support you simply won't offload them. And ignore
> > the parameters which only ma
On Thu, Aug 02, 2018 at 03:53:15PM -0700, Jakub Kicinski wrote:
> No one is requesting full RED offload here.. if someone sets the
> parameters you can't support you simply won't offload them. And ignore
> the parameters which only make sense in software terms. Look at the
> docs for mlxsw:
>
>
On Thu, 2 Aug 2018 18:07:18 +0300, Eran Ben Elisha wrote:
> On 8/2/2018 4:40 AM, David Miller wrote:
> > From: Jakub Kicinski
> > Date: Wed, 1 Aug 2018 17:00:47 -0700
> >
> >> On Wed, 1 Aug 2018 14:52:45 -0700, Saeed Mahameed wrote:
> >>> - According to the discussion outcome, we are keeping
David Miller writes:
> From: Jakub Kicinski
> Date: Thu, 2 Aug 2018 10:11:12 -0700
>
>> On Thu, 02 Aug 2018 11:29:12 +0300, Petr Machata wrote:
>>> Could you please clarify your remark?
>>
>> Oh, I think David meant the patches I was objecting to a while ago,
>> which were doing buffer configur
From: Jakub Kicinski
Date: Thu, 2 Aug 2018 10:11:12 -0700
> On Thu, 02 Aug 2018 11:29:12 +0300, Petr Machata wrote:
>> Could you please clarify your remark?
>
> Oh, I think David meant the patches I was objecting to a while ago,
> which were doing buffer configuration via the DCB API.
Exactly.
On Thu, 02 Aug 2018 11:29:12 +0300, Petr Machata wrote:
> David Miller writes:
>
> > From: Jakub Kicinski
> > Date: Wed, 1 Aug 2018 17:00:47 -0700
> >
> >> On Wed, 1 Aug 2018 14:52:45 -0700, Saeed Mahameed wrote:
> >>> - According to the discussion outcome, we are keeping the congestion
>
On 8/2/2018 4:40 AM, David Miller wrote:
From: Jakub Kicinski
Date: Wed, 1 Aug 2018 17:00:47 -0700
On Wed, 1 Aug 2018 14:52:45 -0700, Saeed Mahameed wrote:
- According to the discussion outcome, we are keeping the congestion control
setting as mlx5 device specific for the current HW ge
David Miller writes:
> From: Jakub Kicinski
> Date: Wed, 1 Aug 2018 17:00:47 -0700
>
>> On Wed, 1 Aug 2018 14:52:45 -0700, Saeed Mahameed wrote:
>>> - According to the discussion outcome, we are keeping the congestion control
>>> setting as mlx5 device specific for the current HW generation.
Thu, Aug 02, 2018 at 01:13:20AM CEST, sae...@dev.mellanox.co.il wrote:
[...]
>>
>> So after looking over the patch set the one thing I would ask for in
>> this is some sort of documentation at a minimum. As a user I don't see
>> how you can expect someone to be able to use this when the naming of
From: Jakub Kicinski
Date: Wed, 1 Aug 2018 17:00:47 -0700
> On Wed, 1 Aug 2018 14:52:45 -0700, Saeed Mahameed wrote:
>> - According to the discussion outcome, we are keeping the congestion control
>> setting as mlx5 device specific for the current HW generation.
>
> I still see queuing and ma
On Wed, Aug 1, 2018 at 4:13 PM, Saeed Mahameed
wrote:
> On Wed, Aug 1, 2018 at 3:34 PM, Alexander Duyck
> wrote:
>> On Wed, Aug 1, 2018 at 2:52 PM, Saeed Mahameed wrote:
>>> Hi Dave,
>>>
>>> This series provides devlink parameters updates to both devlink API and
>>> mlx5 driver, it is a 2nd iter
On Wed, 1 Aug 2018 14:52:45 -0700, Saeed Mahameed wrote:
> - According to the discussion outcome, we are keeping the congestion control
> setting as mlx5 device specific for the current HW generation.
I still see queuing and marking based on queue level. You want to add
a Qdisc that will mirr
On Wed, Aug 1, 2018 at 3:34 PM, Alexander Duyck
wrote:
> On Wed, Aug 1, 2018 at 2:52 PM, Saeed Mahameed wrote:
>> Hi Dave,
>>
>> This series provides devlink parameters updates to both devlink API and
>> mlx5 driver, it is a 2nd iteration of the dropped patches sent in a previous
>> mlx5 submissi
On Wed, Aug 1, 2018 at 2:52 PM, Saeed Mahameed wrote:
> Hi Dave,
>
> This series provides devlink parameters updates to both devlink API and
> mlx5 driver, it is a 2nd iteration of the dropped patches sent in a previous
> mlx5 submission "net/mlx5: Support PCIe buffer congestion handling via
> Dev
Hi Dave,
This series provides devlink parameters updates to both devlink API and
mlx5 driver, it is a 2nd iteration of the dropped patches sent in a previous
mlx5 submission "net/mlx5: Support PCIe buffer congestion handling via
Devlink" to address review comments [1].
Changes from the original s
20 matches
Mail list logo
