Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-18 Thread Doug Ledford
On Thu, 2017-01-19 at 00:38 -0500, David Miller wrote: > From: Tom Herbert > Date: Wed, 18 Jan 2017 21:22:53 -0800 > > > In principle I  agree, but as I previously wrote backporting this > > driver is already a bear. We need to do something here as this is > > quickly approaching being infeasible

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-18 Thread David Miller
From: Tom Herbert Date: Wed, 18 Jan 2017 21:22:53 -0800 > In principle I agree, but as I previously wrote backporting this > driver is already a bear. We need to do something here as this is > quickly approaching being infeasible to backport. Even if we don't > restructure the directories I'd st

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-18 Thread Tom Herbert
On Wed, Jan 18, 2017 at 9:32 AM, David Miller wrote: > From: Saeed Mahameed > Date: Mon, 16 Jan 2017 22:30:29 +0200 > >>> But please bear with me here, what if we queue this patch up to -stable ? > > You've got to be seriously kidding me that your idea is to submit an > incredibly diruptive drive

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-18 Thread David Miller
From: Saeed Mahameed Date: Mon, 16 Jan 2017 22:30:29 +0200 >> But please bear with me here, what if we queue this patch up to -stable ? You've got to be seriously kidding me that your idea is to submit an incredibly diruptive driver rename to -stable to solve this problem. That is completely a

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-16 Thread Saeed Mahameed
On Mon, Jan 16, 2017 at 11:06 PM, Tom Herbert wrote: > On Mon, Jan 16, 2017 at 12:30 PM, Saeed Mahameed > wrote: >> On Sat, Jan 14, 2017 at 12:07 AM, Saeed Mahameed >> wrote: >>> On Fri, Jan 13, 2017 at 7:14 PM, David Miller wrote: From: Saeed Mahameed Date: Thu, 12 Jan 2017 19:22:34

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-16 Thread Tom Herbert
On Mon, Jan 16, 2017 at 12:30 PM, Saeed Mahameed wrote: > On Sat, Jan 14, 2017 at 12:07 AM, Saeed Mahameed > wrote: >> On Fri, Jan 13, 2017 at 7:14 PM, David Miller wrote: >>> From: Saeed Mahameed >>> Date: Thu, 12 Jan 2017 19:22:34 +0200 >>> This pull request includes one patch from Leon,

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-16 Thread Saeed Mahameed
On Sat, Jan 14, 2017 at 12:07 AM, Saeed Mahameed wrote: > On Fri, Jan 13, 2017 at 7:14 PM, David Miller wrote: >> From: Saeed Mahameed >> Date: Thu, 12 Jan 2017 19:22:34 +0200 >> >>> This pull request includes one patch from Leon, this patch as described >>> below will change the driver director

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-16 Thread Saeed Mahameed
On Sat, Jan 14, 2017 at 12:56 AM, Tom Herbert wrote: > On Fri, Jan 13, 2017 at 2:45 PM, Saeed Mahameed > wrote: >> On Sat, Jan 14, 2017 at 12:06 AM, Tom Herbert wrote: >>> Btw, we did hit one issue in the backport. We started to get rx csum >>> faults (checksum complete value indicates TCP check

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-14 Thread Leon Romanovsky
On Sat, Jan 14, 2017 at 09:37:20AM -0800, Tom Herbert wrote: > On Fri, Jan 13, 2017 at 2:45 PM, Saeed Mahameed > wrote: > > On Sat, Jan 14, 2017 at 12:06 AM, Tom Herbert wrote: > >> On Fri, Jan 13, 2017 at 12:29 PM, Leon Romanovsky wrote: > >>> On Fri, Jan 13, 2017 at 12:14:07PM -0500, David Mil

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-14 Thread Tom Herbert
On Fri, Jan 13, 2017 at 2:45 PM, Saeed Mahameed wrote: > On Sat, Jan 14, 2017 at 12:06 AM, Tom Herbert wrote: >> On Fri, Jan 13, 2017 at 12:29 PM, Leon Romanovsky wrote: >>> On Fri, Jan 13, 2017 at 12:14:07PM -0500, David Miller wrote: From: Saeed Mahameed Date: Thu, 12 Jan 2017 19:22

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-13 Thread Tom Herbert
On Fri, Jan 13, 2017 at 2:59 PM, Rick Jones wrote: > On 01/13/2017 02:56 PM, Tom Herbert wrote: >> >> On Fri, Jan 13, 2017 at 2:45 PM, Saeed Mahameed >>> >>> what configuration are you running ? what traffic ? >>> >> Nothing fancy. 8 queues and 20 concurrent netperf TCP_STREAMs trips >> it. Not a

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-13 Thread Rick Jones
On 01/13/2017 02:56 PM, Tom Herbert wrote: On Fri, Jan 13, 2017 at 2:45 PM, Saeed Mahameed what configuration are you running ? what traffic ? Nothing fancy. 8 queues and 20 concurrent netperf TCP_STREAMs trips it. Not a lot of them, but I don't think we really should ever see these errors.

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-13 Thread Tom Herbert
On Fri, Jan 13, 2017 at 2:45 PM, Saeed Mahameed wrote: > On Sat, Jan 14, 2017 at 12:06 AM, Tom Herbert wrote: >> On Fri, Jan 13, 2017 at 12:29 PM, Leon Romanovsky wrote: >>> On Fri, Jan 13, 2017 at 12:14:07PM -0500, David Miller wrote: From: Saeed Mahameed Date: Thu, 12 Jan 2017 19:22

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-13 Thread Saeed Mahameed
On Sat, Jan 14, 2017 at 12:06 AM, Tom Herbert wrote: > On Fri, Jan 13, 2017 at 12:29 PM, Leon Romanovsky wrote: >> On Fri, Jan 13, 2017 at 12:14:07PM -0500, David Miller wrote: >>> From: Saeed Mahameed >>> Date: Thu, 12 Jan 2017 19:22:34 +0200 >>> >>> > This pull request includes one patch from

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-13 Thread Saeed Mahameed
On Fri, Jan 13, 2017 at 7:14 PM, David Miller wrote: > From: Saeed Mahameed > Date: Thu, 12 Jan 2017 19:22:34 +0200 > >> This pull request includes one patch from Leon, this patch as described >> below will change the driver directory structure and layout for better, >> logical and modular driver

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-13 Thread Tom Herbert
On Fri, Jan 13, 2017 at 12:29 PM, Leon Romanovsky wrote: > On Fri, Jan 13, 2017 at 12:14:07PM -0500, David Miller wrote: >> From: Saeed Mahameed >> Date: Thu, 12 Jan 2017 19:22:34 +0200 >> >> > This pull request includes one patch from Leon, this patch as described >> > below will change the driv

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-13 Thread Leon Romanovsky
On Fri, Jan 13, 2017 at 12:14:07PM -0500, David Miller wrote: > From: Saeed Mahameed > Date: Thu, 12 Jan 2017 19:22:34 +0200 > > > This pull request includes one patch from Leon, this patch as described > > below will change the driver directory structure and layout for better, > > logical and mod

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-13 Thread David Miller
From: Saeed Mahameed Date: Thu, 12 Jan 2017 19:22:34 +0200 > This pull request includes one patch from Leon, this patch as described > below will change the driver directory structure and layout for better, > logical and modular driver files separation. > > This change is important to both rdma

[pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-12 Thread Saeed Mahameed
Hi Dave and Doug, This pull request includes one patch from Leon, this patch as described below will change the driver directory structure and layout for better, logical and modular driver files separation. This change is important to both rdma and net maintainers in order to have smoother mana