On 03/13/2018 11:04 AM, David Woodhouse wrote:
On Tue, 2018-03-13 at 07:51 -0700, Alexander Duyck wrote:
Actually the suggestion I had from Don Dutile was that we should be
looking at creating a pci-stub like driver specifically for those type
of devices, but without the ability to arbitrarily
On Tue, 2018-03-13 at 07:51 -0700, Alexander Duyck wrote:
> Actually the suggestion I had from Don Dutile was that we should be
> looking at creating a pci-stub like driver specifically for those type
> of devices, but without the ability to arbitrarily assign devices.
> Basically we have to white
On Tue, Mar 13, 2018 at 1:12 AM, David Woodhouse wrote:
> On Mon, 2018-03-12 at 10:23 -0700, Alexander Duyck wrote:
>>
>> - .sriov_configure = ena_sriov_configure,
>> +#ifdef CONFIG_PCI_IOV
>> + .sriov_configure = pci_sriov_configure_simple,
>> +#endif
>> };
>
> I'd like to see that i
On Tue, 2018-03-13 at 09:54 +0100, Christoph Hellwig wrote:
> On Tue, Mar 13, 2018 at 08:45:19AM +, David Woodhouse wrote:
> Because binding to pci-stub means that you'd now enable the simple
> SR-IOV for any device bound to PCI stub. Which often might be the wrong
> thing.
No, *using* it w
On Tue, Mar 13, 2018 at 08:45:19AM +, David Woodhouse wrote:
>
>
> On Tue, 2018-03-13 at 09:16 +0100, Christoph Hellwig wrote:
> > On Tue, Mar 13, 2018 at 08:12:52AM +, David Woodhouse wrote:
> > >
> > > I'd also *really* like to see a way to enable this for PFs which don't
> > > have (a
On Tue, 2018-03-13 at 09:16 +0100, Christoph Hellwig wrote:
> On Tue, Mar 13, 2018 at 08:12:52AM +, David Woodhouse wrote:
> >
> > I'd also *really* like to see a way to enable this for PFs which don't
> > have (and don't need) a driver. We seem to have lost that along the
> > way.
> We've b
On Tue, Mar 13, 2018 at 08:12:52AM +, David Woodhouse wrote:
> I'd also *really* like to see a way to enable this for PFs which don't
> have (and don't need) a driver. We seem to have lost that along the
> way.
We've been forth and back on that. I agree that not having any driver
just seems d
On Mon, 2018-03-12 at 10:23 -0700, Alexander Duyck wrote:
>
> - .sriov_configure = ena_sriov_configure,
> +#ifdef CONFIG_PCI_IOV
> + .sriov_configure = pci_sriov_configure_simple,
> +#endif
> };
I'd like to see that ifdef go away, as discussed. I agree that just
#define pci_sriov_con
From: Alexander Duyck
Instead of implementing our own version of a SR-IOV configuration stub in
the ena driver we can just reuse the existing
pci_sriov_configure_simple function.
Signed-off-by: Alexander Duyck
---
v5: Replaced call to pci_sriov_configure_unmanaged with
pci_sriov_config
