Re: [patch net v3] net: fec: fix compile with CONFIG_M5272

2016-12-05 Thread David Miller
From: Nikita Yushchenko Date: Mon, 5 Dec 2016 20:41:01 +0300 > Commit 4dfb80d18d05 ("net: fec: cache statistics while device is down") > introduced unconditional statistics-related actions. I do not see this commit in any of my trees: [davem@localhost net-next]$ git describe 4dfb80d18d05 fatal

Re: [patch net v3] net: fec: fix compile with CONFIG_M5272

2016-12-05 Thread Nikita Yushchenko
> +#define FEC_STATS_SIZE (ARRAY_SIZE(fec_stats) * sizeof(u64)) > > > Do I take it right this actually translates to (sizeof(fec_stats) / > sizeof(u64) * sizeof(u64))? No. fec_stats is an array of structs, each struct has car arrsy and integer, and size of that is definitely not byt

[patch net v3] net: fec: fix compile with CONFIG_M5272

2016-12-05 Thread Nikita Yushchenko
Commit 4dfb80d18d05 ("net: fec: cache statistics while device is down") introduced unconditional statistics-related actions. However, when driver is compiled with CONFIG_M5272, staticsics-related definitions do not exist, which results into build errors. Fix that by adding explicit handling of !d