Re: [patch net-next v6_repost 2/3] net: core: add SW stats to if_stats_msg

2016-08-23 Thread Roopa Prabhu
On 8/23/16, 7:52 AM, Jiri Pirko wrote: > Tue, Aug 23, 2016 at 04:46:37PM CEST, ro...@cumulusnetworks.com wrote: >> On 8/23/16, 12:26 AM, Jiri Pirko wrote: >>> Tue, Aug 23, 2016 at 09:04:15AM CEST, da...@davemloft.net wrote: From: Jiri Pirko Date: Tue, 23 Aug 2016 08:53:18 +0200

Re: [patch net-next v6_repost 2/3] net: core: add SW stats to if_stats_msg

2016-08-23 Thread Jiri Pirko
Tue, Aug 23, 2016 at 04:46:37PM CEST, ro...@cumulusnetworks.com wrote: >On 8/23/16, 12:26 AM, Jiri Pirko wrote: >> Tue, Aug 23, 2016 at 09:04:15AM CEST, da...@davemloft.net wrote: >>> From: Jiri Pirko >>> Date: Tue, 23 Aug 2016 08:53:18 +0200 >>> Anyway I think that next level of nesting is n

Re: [patch net-next v6_repost 2/3] net: core: add SW stats to if_stats_msg

2016-08-23 Thread Roopa Prabhu
On 8/23/16, 12:26 AM, Jiri Pirko wrote: > Tue, Aug 23, 2016 at 09:04:15AM CEST, da...@davemloft.net wrote: >> From: Jiri Pirko >> Date: Tue, 23 Aug 2016 08:53:18 +0200 >> >>> Anyway I think that next level of nesting is not necessary. On >>> contrary, it is wrong. The current level is extensible,

Re: [patch net-next v6_repost 2/3] net: core: add SW stats to if_stats_msg

2016-08-23 Thread Jiri Pirko
Tue, Aug 23, 2016 at 07:51:57AM CEST, ro...@cumulusnetworks.com wrote: >On 8/19/16, 6:17 AM, Jiri Pirko wrote: >> From: Nogah Frankel >> >> Add a nested attribute of SW stats to if_stats_msg >> under IFLA_STATS_LINK_SW_64. >> >> Signed-off-by: Nogah Frankel >> Reviewed-by: Ido Schimmel >> Signed

Re: [patch net-next v6_repost 2/3] net: core: add SW stats to if_stats_msg

2016-08-23 Thread Jiri Pirko
Tue, Aug 23, 2016 at 09:04:15AM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Tue, 23 Aug 2016 08:53:18 +0200 > >> Anyway I think that next level of nesting is not necessary. On >> contrary, it is wrong. The current level is extensible, mixed and >> flagged already. I don't see any rea

Re: [patch net-next v6_repost 2/3] net: core: add SW stats to if_stats_msg

2016-08-23 Thread David Miller
From: Jiri Pirko Date: Tue, 23 Aug 2016 08:53:18 +0200 > Anyway I think that next level of nesting is not necessary. On > contrary, it is wrong. The current level is extensible, mixed and > flagged already. I don't see any reason why not to add whatever kind of > stats here. What makes IFLA_STATS

Re: [patch net-next v6_repost 2/3] net: core: add SW stats to if_stats_msg

2016-08-22 Thread Roopa Prabhu
On 8/19/16, 6:17 AM, Jiri Pirko wrote: > From: Nogah Frankel > > Add a nested attribute of SW stats to if_stats_msg > under IFLA_STATS_LINK_SW_64. > > Signed-off-by: Nogah Frankel > Reviewed-by: Ido Schimmel > Signed-off-by: Jiri Pirko > --- > include/uapi/linux/if_link.h | 1 + > net/core/rt

[patch net-next v6_repost 2/3] net: core: add SW stats to if_stats_msg

2016-08-19 Thread Jiri Pirko
From: Nogah Frankel Add a nested attribute of SW stats to if_stats_msg under IFLA_STATS_LINK_SW_64. Signed-off-by: Nogah Frankel Reviewed-by: Ido Schimmel Signed-off-by: Jiri Pirko --- include/uapi/linux/if_link.h | 1 + net/core/rtnetlink.c | 21 + 2 files chang