Re: [patch net-next v3 11/15] netdevsim: implement proper devlink reload

2019-10-04 Thread Jiri Pirko
Fri, Oct 04, 2019 at 07:42:17PM CEST, jakub.kicin...@netronome.com wrote: >On Fri, 4 Oct 2019 08:19:14 +0200, Jiri Pirko wrote: >> >> @@ -84,20 +82,10 @@ int nsim_fib_set_max(struct nsim_fib_data *fib_data, >> >> entry = &fib_data->ipv6.rules; >> >> break; >> >> default: >> >>

Re: [patch net-next v3 11/15] netdevsim: implement proper devlink reload

2019-10-04 Thread Jakub Kicinski
On Fri, 4 Oct 2019 08:19:14 +0200, Jiri Pirko wrote: > >> @@ -84,20 +82,10 @@ int nsim_fib_set_max(struct nsim_fib_data *fib_data, > >>entry = &fib_data->ipv6.rules; > >>break; > >>default: > >> - return 0; > >> - } > >> - > >> - /* not allowing a new max to b

Re: [patch net-next v3 11/15] netdevsim: implement proper devlink reload

2019-10-03 Thread Jiri Pirko
Fri, Oct 04, 2019 at 01:17:30AM CEST, jakub.kicin...@netronome.com wrote: >On Thu, 3 Oct 2019 11:49:36 +0200, Jiri Pirko wrote: >> From: Jiri Pirko >> >> During devlink reload, all driver objects should be reinstantiated with >> the exception of devlink instance and devlink resources and params.

Re: [patch net-next v3 11/15] netdevsim: implement proper devlink reload

2019-10-03 Thread Jakub Kicinski
On Thu, 3 Oct 2019 11:49:36 +0200, Jiri Pirko wrote: > From: Jiri Pirko > > During devlink reload, all driver objects should be reinstantiated with > the exception of devlink instance and devlink resources and params. > Move existing devlink_resource_size_get() calls into fib_create() just > bef

[patch net-next v3 11/15] netdevsim: implement proper devlink reload

2019-10-03 Thread Jiri Pirko
From: Jiri Pirko During devlink reload, all driver objects should be reinstantiated with the exception of devlink instance and devlink resources and params. Move existing devlink_resource_size_get() calls into fib_create() just before fib notifier is registered. Also, make sure that extack is pro